Daniel Nephin
f27934376d
Fix test and lint failures
...
Split test cases.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-07-12 11:37:35 -04:00
Vincent Demeester
bb795aa7af
Merge pull request #323 from dnephin/add-code-owners
...
Add a new CODEOWNERS file, and add a few owners
2017-07-12 13:28:24 +02:00
Vincent Demeester
87345ed117
Merge pull request #277 from thaJeztah/dont-remove-what-isnt-there
...
Don't attempt to remove unsupported resources on older daemon
2017-07-12 10:43:54 +02:00
Vincent Demeester
fa7687a362
Merge pull request #299 from dnephin/less-verbose-fake-cli
...
Less verbose fake cli
2017-07-12 09:56:43 +02:00
Kenfe-Mickaël Laventure
8b451c598f
Merge pull request #322 from dnephin/pin-tools
...
Pin all tools used in the Dockerfiles
2017-07-12 08:58:33 +02:00
Daniel Nephin
42a3800783
Update some tests to remove unnecessary buffers.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-07-11 17:52:43 -04:00
Daniel Nephin
91a5efd882
Add a new CODEOWNERS file, and add a few owners.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-07-11 17:40:25 -04:00
Daniel Nephin
3da0cbfdd1
Remove unnecessary use of SetConfigfile
...
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-07-11 14:49:30 -04:00
Daniel Nephin
69b142b52a
Update FakeCli to remove duplication in tests.
...
Use byte buffers by default, since that is what is done most of the time.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-07-11 14:49:30 -04:00
Daniel Nephin
102a8f0c9d
Pin all tools used in the Dockerfiles
...
Also update gometalinter to use the official version. The update
found some new gosimple errors, which are fixed.
Also update the filewatcher script for the latest version of filewatcher.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-07-11 14:23:27 -04:00
Sebastiaan van Stijn
2429f15672
Don't attempt to remove unsupported resources on older daemon
...
When running `docker stack rm <some stack>` against an older daemon,
a warning was printed for "configs" being ignored;
WARNING: ignoring "configs" (requires API version 1.30, but the Docker daemon API version is 1.26)
Given that an old daemon cannot _have_ configs, there should not be
a need to warn, or _attempt_ to remove these resources.
This patch removes the warning, and skips fetching (and removing)
configs.
A check if _secrets_ are supported by the daemon is also added,
given that this would result in an error when attempted against
an older (pre 1.13) daemon.
There is one situation where this could lead to secrets or
configs being left behind; if the client is connecting to a
daemon that _does_ support secrets, configs, but the API version
is overridden using `DOCKER_API_VERSION`, no warning is printed,
and secrets and configs are not attempted to be removed.
Given that `DOCKER_API_VERSION` is regarded a feature for
debugging / "power users", it should be ok to ignore this.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-07-11 10:29:03 -07:00
Victor Vieux
6908e58f0f
Merge pull request #312 from thaJeztah/remove-unused-prune-functions
...
Remove unused prune functions
2017-07-11 12:15:44 +02:00
Victor Vieux
b7b680590b
Merge pull request #318 from thaJeztah/pin-vndr
...
pin vndr to 9909bb2b8a0b7ea464527b376dc50389c90df587
2017-07-11 12:14:59 +02:00
Victor Vieux
251eafd637
Merge pull request #321 from albers/remove-completion-service-update--network
...
Remove bash completion for `service update --network`
2017-07-11 12:14:27 +02:00
Harald Albers
e7e77b5e65
Remove bash completion for `service update --network`
...
The `--network` option is only available for `docker service create`.
Signed-off-by: Harald Albers <github@albersweb.de>
2017-07-11 11:20:18 +02:00
Sebastiaan van Stijn
008785f5b5
pin vndr to 9909bb2b8a0b7ea464527b376dc50389c90df587
...
This make updating vndr a deliberate action, and
prevents updates to vndr from making the vendor
validation fail in CI.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-07-10 14:31:57 -07:00
Sebastiaan van Stijn
d8a2972cb1
Remove unused prune functions
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-07-10 13:27:19 -07:00
Sebastiaan van Stijn
a765218f19
Merge pull request #316 from thaJeztah/revendor-dependencies
...
Revendor dependencies
2017-07-10 13:23:17 -07:00
Sebastiaan van Stijn
3e3c9d69d8
Revendor dependencies
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-07-10 10:56:42 -07:00
Vincent Demeester
af6c0896f5
Merge pull request #298 from dnephin/fix-stack-out-stream
...
Fix stack output stream
2017-07-10 09:23:23 +02:00
Sebastiaan van Stijn
7ae9bc141c
Merge pull request #259 from aaronlehmann/service-progress-surface-error
...
progress: Show task error in place of progress bar
2017-07-09 00:04:38 -07:00
Sebastiaan van Stijn
c99530b1d2
Merge pull request #270 from tych0/warn-only-about-password-on-cli
...
login: print a big warning when using --password
2017-07-08 16:37:40 -07:00
Aaron Lehmann
534c3d285b
Merge pull request #308 from ProgVal/patch-1
...
Fix typo (proceed -> precede)
2017-07-07 13:45:00 -07:00
Valentin Lorentz
4f3a8aecad
Fix typo (proceed -> precede)
...
Signed-off-by: Valentin Lorentz <progval+git@progval.net>
2017-07-07 13:17:15 +02:00
Aaron Lehmann
dfdbdab651
Merge pull request #303 from yastij/fix-SIGSEGV-runContainer
...
fixing SIGSEGV when running containers
2017-07-06 15:45:38 -07:00
Aaron Lehmann
c9b92a328d
progress: Light refactor
...
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2017-07-06 10:40:35 -07:00
Yassine TIJANI
45b0e7cf1a
fixing SIGSEGV when running containers
...
Signed-off-by: Yassine TIJANI <yasstij11@gmail.com>
moving the deffering of the close after the error checking
Signed-off-by: Yassine TIJANI <yasstij11@gmail.com>
fixing SIGSEGV when running containers
Signed-off-by: Yassine TIJANI <yasstij11@gmail.com>
2017-07-06 18:57:36 +02:00
Vincent Demeester
1aa82bc7df
Merge pull request #211 from ksouf/issue-37-add-tests-on-commands
...
adding network_create tests
2017-07-06 08:59:15 +02:00
Aaron Lehmann
e672589ec0
Merge pull request #296 from thaJeztah/fix-error-overwrite
...
Fix error variable being overwritten
2017-07-05 19:26:27 -07:00
khaled souf
57c1551991
adding unit tests to network
...
Signed-off-by: khaled souf <khaled.souf@gmail.com>
2017-07-06 00:54:30 +02:00
Sebastiaan van Stijn
4d4c789cac
Fix error variable being overwritten
...
The `err` variable was set in a loop, so only
the last result was taken into account to return
"failure" or not.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-07-05 13:54:57 -07:00
Daniel Nephin
0030bfea9f
Remove duplication in task formatting.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-07-05 13:40:47 -04:00
Daniel Nephin
fb6deb1077
Fix stream for 'nothing found in stack' message
...
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-07-05 13:32:54 -04:00
Brian Goff
30933b516b
Merge pull request #286 from thaJeztah/bump-moby
...
Bump moby to 87df0e533b619c088091fd1e2310e92bb9a24822
2017-07-05 09:38:32 -04:00
Sebastiaan van Stijn
e8080dd7e5
update tests for new image struct
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-07-04 20:34:24 -07:00
Sebastiaan van Stijn
366d3ec971
Bump moby to 87df0e533b619c088091fd1e2310e92bb9a24822
...
Includes changes from;
- Add a LastTagTime for images (https://github.com/moby/moby/pull/31497 )
- Fix handling of remote "git@" notation (https://github.com/moby/moby/pull/33696 )
- Move some `api` package functions away (https://github.com/moby/moby/pull/33798 ) (related to https://github.com/docker/cli/pull/236 )
- Set ping version even on error (https://github.com/moby/moby/pull/33827 )
- Do not add duplicate platform information to service spec (https://github.com/moby/moby/pull/33867 )
- Refactor MountPoint Setup function in volume.go (https://github.com/moby/moby/pull/33890 )
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-07-04 20:23:38 -07:00
Vincent Demeester
dc9feff879
Merge pull request #287 from thaJeztah/use-v1.0.0-tag-for-go-difflib
...
Use v1.0.0 tag for go-difflib
2017-07-04 17:32:00 +02:00
Daniel Nephin
3554d02f33
Merge pull request #276 from adshmh/add-unit-tests-to-checkpoint-package
...
add unit tests to checkpoint package
2017-07-04 11:17:25 -04:00
Vincent Demeester
e08cb59c8a
Merge pull request #288 from thaJeztah/bump-go-winio
...
Bump go-winio to 0.4.2
2017-07-04 16:59:32 +02:00
Victor Vieux
306212574a
Merge pull request #248 from albers/completion-network-create--scope
...
Add bash completion for `network create --scope|--config-only|config-from`
2017-07-04 16:48:18 +02:00
Victor Vieux
1f45f1b5f9
Merge pull request #246 from albers/completion-prune--filter-label
...
Add bash completion for `label` filter of `prune` commands
2017-07-04 16:44:23 +02:00
Victor Vieux
42a31ff8c1
Merge pull request #282 from albers/completion-daemon-updates
...
Updates to bash completion for `dockerd`
2017-07-04 16:42:10 +02:00
Victor Vieux
d47bbb8358
Merge pull request #285 from albers/completion-overlay2.size
...
Add bash completion for `dockerd --storage-opt overlay2.size`
2017-07-04 16:41:35 +02:00
Victor Vieux
43fb4a4547
Merge pull request #243 from vieux/scale2
...
add `--detach` to docker scale
2017-07-04 16:36:59 +02:00
Harald Albers
0ea31afd57
Add bash completion for `dockerd --metrics-addr`
...
`--metrics-addr` does not accept network interface names.
Therefore `__docker_local_interfaces` was refined for this feature to
optionally exclude interface names.
Note that although `--metrics-addr` is experimental, it cannot be
selectively enabled in bash completion because the test for the daemon
running in experimental mode requires a running daemon. As this
completion pertains to starting the daemon, this requirement is not met.
Signed-off-by: Harald Albers <github@albersweb.de>
2017-07-04 14:40:22 +02:00
Vincent Demeester
357ff50fa9
Merge pull request #289 from mstanleyjones/multiple-env
...
Provide examples for multiple uses of the same flag
2017-07-04 12:48:20 +02:00
Sebastiaan van Stijn
8df4cd1edc
Merge pull request #292 from thaJeztah/clarify-docker-go-package
...
Clarify docker/go package
2017-07-03 23:44:26 -07:00
Sebastiaan van Stijn
98b7dbe908
Merge pull request #290 from mstanleyjones/d-and-rm-flags
...
Clarify that you can use -d and --rm together now
2017-07-03 23:43:36 -07:00
Sebastiaan van Stijn
60fe70c900
Clarify docker/go package
...
This package is used by Notary. Add a comment to
the vendor.conf file to explain what it contains
and what it's used for.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-07-03 18:00:46 -07:00
Misty Stanley-Jones
c63485b47d
Clarify that you can use -d and --rm together now
...
Signed-off-by: Misty Stanley-Jones <misty@docker.com>
2017-07-03 16:43:41 -07:00