notsoyuzu
/
yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

common/file_util: Remove unnecessary return at end of void StripTailDirSlashes() 

While we're at it, also invert the conditional into a guard clause.
This commit is contained in:
Lioncash 2019-05-23 14:33:27 -04:00
parent 11e9bee91d
commit e7ab0e9127
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/common/file_util.cpp
View File

@ -78,13 +78,15 @@ namespace FileUtil {
// Remove any ending forward slashes from directory paths // Remove any ending forward slashes from directory paths
// Modifies argument. // Modifies argument.
static void StripTailDirSlashes(std::string& fname) { static void StripTailDirSlashes(std::string& fname) {
if (fname.length() > 1) { if (fname.length() <= 1) {
std::size_t i = fname.length();
while (i > 0 && fname[i - 1] == DIR_SEP_CHR)
--i;
fname.resize(i);
}
return; return;
}
std::size_t i = fname.length();
while (i > 0 && fname[i - 1] == DIR_SEP_CHR) {
--i;
}
fname.resize(i);
} }
bool Exists(const std::string& filename) { bool Exists(const std::string& filename) {