notsoyuzu
/
yuzu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

file_util: return string by const reference for GetExeDirectory() 

This disallows modifying the internal string buffer (which shouldn't be
modified anyhow).
This commit is contained in:
Lioncash 2018-07-19 01:27:27 -04:00
parent 368e1d25be
commit 63e64f0131
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/file_util.cpp
View File

@ -592,7 +592,7 @@ std::string GetBundleDirectory() {
#endif #endif
#ifdef _WIN32 #ifdef _WIN32
std::string& GetExeDirectory() { const std::string& GetExeDirectory() {
static std::string exe_path; static std::string exe_path;
if (exe_path.empty()) { if (exe_path.empty()) {
wchar_t wchar_exe_path[2048]; wchar_t wchar_exe_path[2048];

2
src/common/file_util.h
View File

@ -133,7 +133,7 @@ std::string GetBundleDirectory();
#endif #endif
#ifdef _WIN32 #ifdef _WIN32
std::string& GetExeDirectory(); const std::string& GetExeDirectory();
std::string AppDataRoamingDirectory(); std::string AppDataRoamingDirectory();
#endif #endif