eadc1ae1e7
reporter: Pass by const reference where applicable
...
Same behavior, but without memory churn.
2022-12-05 21:48:42 -05:00
e7f9f58fa4
reporter: Eliminate undefined behavior in SaveErrorReport
...
The optionals are unconditionally dereferenced when setting the custom
error text, and in a few cases this function is called using the default
value of the optionals.
This means we'd be dereferencing uninitialized storage.
Since they're used unconditionally, we can use value_or to set a default
when storage is uninitialized.
2022-12-05 21:31:34 -05:00
e6ae720c33
cmake: use sdl2 imported target
2022-12-06 01:26:30 +01:00
fedd857054
applets/controller: Use aliases for callbacks
2022-12-05 19:06:04 -05:00
d8da9a2afd
applets/error: Use aliases for callbacks
2022-12-05 19:06:04 -05:00
2b40cdf04f
applets/mii_edit: Use aliases for callbacks
2022-12-05 19:06:04 -05:00
a84676c2aa
applets/profile_select: Use aliases for callbacks
...
Deduplicates callback definitions and situates it in one place.
2022-12-05 19:06:04 -05:00
e26c86a6e7
applets/web_browser: Use aliases for callbacks
...
Deduplicates a lot of long callback declarations
2022-12-05 19:06:04 -05:00
9bbb77637e
applets/software_keyboard: Use aliases for callbacks
...
Deduplicates really long std::function declarations to make the
interface nicer to read.
2022-12-05 19:06:01 -05:00
e4a16f50ef
emulated_controller: Remove unused parameter in GetMappedDevices()
...
This isn't used, so it can be removed to make the function a little
nicer.
2022-12-05 18:27:18 -05:00
87543b9dea
emulated_controller: Use std::move() in GetMappedDevices()
...
Avoids churning allocations in a loop.
2022-12-05 18:27:15 -05:00
7bf4b45349
emulated_console: Amend cast in SetTouch()
...
id is an int value, not a u32.
2022-12-05 18:15:23 -05:00
4255e30722
emulated_console: std::move() ParamPackages and callbacks where applicable
2022-12-05 18:15:19 -05:00
efa8711bf3
kernel/k_shared_memory: Ensure device_memory is always initialized
2022-12-05 15:27:57 -05:00
c3fd211b43
kernel/k_memory_block: Ensure members are always initialized
2022-12-05 15:27:47 -05:00
dcca650599
kernel/physical_core: Ensure is_interrupted is always initialized
2022-12-05 15:19:37 -05:00
dddc9bb8f1
kernel/thread: Ensure stack_top and argument are always initialized
2022-12-05 15:19:36 -05:00
4769d798f9
kernel/kernel: Ensure shutdown threads are always initialized
2022-12-05 15:19:36 -05:00
3b19f741bd
Merge pull request #6833 from abouvier/unbundle
...
cmake: prefer system libraries
2022-12-05 12:26:09 -05:00
6352c5dc31
Vulkan: Implement Alpha coverage
2022-12-05 12:33:12 +01:00
752236caad
input_common: Allow mifare files
2022-12-04 20:02:48 -06:00
a52d0b82a6
Merge pull request #9381 from liamwhite/uninit
...
service_thread: fix uninitialized memory usage
2022-12-04 22:30:16 +00:00
cec3a3cd5a
service_thread: fix uninitialized memory usage
2022-12-04 16:02:24 -05:00
3b9db85646
Merge pull request #9232 from bunnei/audio-default-thread
...
hle: service: audio: Use default service thread.
2022-12-04 15:31:40 -05:00
522e7c5663
Merge pull request #9273 from ameerj/per-game-profile
...
Configuration: Add per-game input profiles
2022-12-04 13:38:01 -05:00
ec547824f1
Merge pull request #9372 from liamwhite/vk12
...
vulkan_common: promote extension usages to core when possible
2022-12-04 12:14:06 -05:00
8e17b5469f
cmake: prefer system libraries
2022-12-04 17:09:25 +01:00
0cbfdf7ecb
yuzu-cmd: link SDL2 correctly
2022-12-04 10:59:58 -05:00
157981cac5
vulkan_common: add feature test for shaderDrawParameters
2022-12-04 10:55:13 -05:00
18831e0933
vulkan_common: clean up extension usage
2022-12-04 10:55:13 -05:00
ea56d8f388
vulkan_common: correct usage of timeline semaphore fallbacks
2022-12-04 10:55:13 -05:00
f23f875dd8
vulkan_common: ensure all mandatory features are tested in feature report
2022-12-04 10:55:13 -05:00
06a67d2bbd
vulkan_common: unsuffix 16-bit storage feature test structure
2022-12-04 10:55:13 -05:00
bbc1809951
vulkan_common: unsuffix timeline semaphore feature test structure
2022-12-04 10:55:13 -05:00
a9633ba8b2
vulkan_common: add logicOp to feature report
2022-12-04 10:55:13 -05:00
7fc6514be1
vulkan_common: promote host query reset usage to core
2022-12-04 10:55:13 -05:00
e44a804ec7
vulkan_common: promote descriptor update template usage to core
2022-12-04 10:55:13 -05:00
a948ab3e48
vulkan_common: promote timeline semaphore usage to core
2022-12-04 10:55:13 -05:00
02b10a6e4d
Merge pull request #9374 from liamwhite/externals
...
externals: update dynarmic, SDL2
2022-12-04 10:44:12 -05:00
6d2c597371
externals: update dynarmic, SDL2
2022-12-04 10:12:26 -05:00
f77cc6c412
Merge pull request #9344 from liamwhite/null
...
video_core: add null backend
2022-12-03 11:23:25 -08:00
75e16547f8
Merge pull request #9300 from ameerj/pch
...
CMake: Use precompiled headers to improve compile times
2022-12-03 14:10:06 -05:00
22aff09b33
Merge pull request #9289 from liamwhite/fruit-company
...
general: fix compile for Apple Clang
2022-12-03 12:09:21 -05:00
ac0721a4bc
Merge pull request #9353 from vonchenplus/draw_indexed
...
video_core: Fine tuning the index drawing judgment logic
2022-12-03 10:43:34 -05:00
c043ba8467
Merge pull request #9303 from liamwhite/new-vulkan-init
...
Vulkan: update initialization
2022-12-02 18:32:54 -03:00
9a5d8b356a
Merge pull request #9363 from liamwhite/gs
...
shader_recompiler: add gl_Layer translation GS for older hardware
2022-12-02 16:08:12 -03:00
6072b22a0b
core: add option to break on unmapped access
2022-12-02 08:25:45 -05:00
d8bd52c6f1
Merge pull request #9348 from Morph1984/when-the-network-is-down
...
service: nifm: Update stubs for Submit/GetRequestState/GetResult
2022-12-01 22:14:43 -05:00
a4725bcb73
service: nfc: Implement mifare service
2022-12-01 20:43:59 -06:00
3ef006b5ab
shader_recompiler: add gl_Layer translation GS for older hardware
2022-12-01 09:51:27 -05:00
cb5400b34d
video_core: Fine tuning the index drawing judgment logic
2022-12-01 19:14:58 +08:00
be05cb640c
vulkan_common: quiet some validation errors
2022-11-30 19:18:05 -05:00
5b5612c1cc
CMake: Consolidate common PCH headers
2022-11-30 18:30:30 -05:00
3c39c0ac3e
string_util: Fix Mingw compile error
...
Co-Authored-By: liamwhite <9658600+liamwhite@users.noreply.github.com>
2022-11-30 18:26:26 -05:00
4e89979c87
Merge pull request #9320 from yuzu-emu/fix-audio-suspend
...
AudioCore: Take suspend lock when stalling the running process.
2022-11-30 16:41:32 +01:00
8fd4e44014
audio_core: sink_stream: Hold the suspend lock when process is stalled.
...
- Prevents us from clashing with other callers trying to un/stall.
2022-11-29 20:32:06 -08:00
51358d2b5e
CMake: Disable PCH on MSVC + Buildcache configs
2022-11-29 23:01:32 -05:00
a78372110c
Respect render mode override
2022-11-30 01:43:36 +00:00
49219b8a86
Merge pull request #9349 from lat9nq/cmake-322
...
CMakeLists: Bump minimum required CMake version to 3.22
2022-11-29 19:41:47 -05:00
37bc5118ea
CMake: Use precompiled headers
2022-11-29 18:50:49 -05:00
cae6c13ffb
value.h: remove recursive include
2022-11-29 18:50:49 -05:00
d6b63239ae
Merge pull request #9308 from lat9nq/from-scratch
...
startup_checks: Use Windows flow for *nix
2022-11-29 18:45:39 -05:00
cafca891ea
Merge pull request #9322 from german77/pump_events
...
input_common: Pump SDL events from main thread
2022-11-29 18:45:25 -05:00
c845d8a9e8
Merge pull request #9352 from lioncash/vidcast
...
engines: Remove unnecessary casts
2022-11-29 18:45:16 -05:00
b6d93b2c77
host1x/syncpoint_manager: Eliminate unnecessary std::function construction
...
We can just pass the function object through, and if it's a valid
function, then it will automatically be converted.
2022-11-29 08:58:50 -05:00
c4af7b3f5c
host1x/syncpoint_manager: Pass DeregisterAction() handle as const-ref
...
The handle is only compared against and not modified in any way, so we
can pass it by const reference.
This also allows us to mark the respective parameters for
DeregisterGuestAction() and DeregisterHostAction() as const references
as well.
2022-11-29 08:55:33 -05:00
96ffc174aa
maxwell_3d: Mark shifted value as unsigned
...
Otherwise this is technically creating a signed int result that gets
converted. Just a consistency change.
While we're in the area, we can mark Samples() as const.
2022-11-29 08:39:33 -05:00
d7ec031419
engines: Remove unnecessary casts
...
In a few cases we have some casts that can be trivially removed.
2022-11-29 08:38:46 -05:00
55a3cbfa0d
Merge pull request #9340 from lioncash/nvdrv
...
nvdrv: Simplify builder declarations
2022-11-29 08:27:13 -05:00
55b546a110
Merge pull request #9347 from lioncash/vcast
...
video_core/surface: Eliminate casts in GetFormatType()
2022-11-29 08:26:39 -05:00
6b8ab9ed8f
Merge pull request #9346 from lioncash/vtable
...
producer_listener: Add virtual destructor to IProducerListener
2022-11-29 08:26:32 -05:00
a7f1fa7bfc
Merge pull request #9345 from lioncash/fence
...
consumer_base: Pass std::shared_ptr by const reference
2022-11-29 08:26:25 -05:00
b6373c5ea5
Merge pull request #9343 from lioncash/bounds
...
syncpoint_manager: Reduce redundant bounds checks
2022-11-29 08:26:16 -05:00
0941ae0b61
CMake: Directly link to SDL2-static when appropriate
...
Trying to be lazy and alias SDL2 to SDL2-static causes issues in later
versions of CMake. Just use the same condition to tell which one to use.
2022-11-28 23:21:14 -05:00
00fdffec58
service: nifm: Update stubs for Submit/GetRequestState/GetResult
2022-11-28 22:58:10 -05:00
a9efea8ae9
video_core/surface: Eliminate casts in GetFormatType()
...
We can just compare directly and get rid of verbose casting.
2022-11-28 20:25:44 -05:00
89dd7dc180
video_core: add null backend
2022-11-28 19:49:09 -05:00
25dda06f49
producer_listener: Add virtual destructor to IProducerListener
...
Several member variables are shared_ptr's to this base class. Even
though producer listeners are still unimplemented, this ensures we
always have consistent deletion behavior once this ends up being used
polymorphically.
2022-11-28 19:39:13 -05:00
4cbbf590e3
configure_input_player: Fix profile saving when using handheld controller type
2022-11-28 19:22:18 -05:00
3de05726eb
config: Custom profile detection fixes
...
Also only reads/writes applicable configs for the custom profiles.
2022-11-28 19:22:18 -05:00
b1b20ad84a
configure_input_per_game: Allow configuring all 8 players
2022-11-28 19:22:18 -05:00
ae74f46e78
buffer_item_consumer: Pass fence by const-ref in ReleaseBuffer()
...
This isn't directly modified.
Also allows rvalues to be used with it.
2022-11-28 19:16:20 -05:00
3020f72b0c
buffer_queue_consumer: std::move std::shared_ptr in Connect()
...
Avoids an unnecessary reference count increment and decrement
2022-11-28 19:12:26 -05:00
c0c4f6dfa6
consumer_base: Pass shared_ptr by const reference
...
Avoids churning atomic reference count increments and decrements.
2022-11-28 19:09:44 -05:00
260a495a23
consumer_base: Remove redundant virtual
...
override already serves this purpose
2022-11-28 19:06:34 -05:00
7a329ae56c
syncpoint_manager: Mark IsSyncpointAllocated() as const
...
This doesn't modify class state at all.
2022-11-28 16:08:21 -05:00
d0883027d6
syncpoint_manager: Reduce number of bounds checks
...
The only time we need to check bounds is on the first access.
2022-11-28 16:06:01 -05:00
bbb963a31a
Merge pull request #9339 from lioncash/cacheheader
...
common/cache_management: Amend header includes
2022-11-28 13:12:20 -05:00
51abe35e05
Merge pull request #9338 from lioncash/properties
...
input_common/helpers: Mark analog property structs members as static constexpr
2022-11-28 13:12:14 -05:00
64ff79f919
Merge pull request #9337 from lioncash/pbr
...
common/input: Add helper functions for constructing input and output devices
2022-11-28 13:12:08 -05:00
ad787b20ca
nvdrv: Simplify builder declarations
...
We can just use auto here. If one of these ever happens to not be
derived from nvdevice, then this will cause a compilation error.
We can also move the devices into the collection to get rid of an
unnecessary atomic reference count increment and decrement.
2022-11-28 10:43:48 -05:00
c2c9b44749
common/cache_management: Amend header includes
...
Narrows the include in the header to <cstddef>, since that's what houses
size_t's definition, meanwhile the <cstdint> include can be moved into
the cpp file.
2022-11-28 10:19:53 -05:00
8265c167d3
input_common/helpers: Mark analog property structs members as static constexpr
...
These are const with no dependency on any other data members, so we can
make these static constexpr to reduce the overall object size.
2022-11-28 10:10:37 -05:00
780ae92265
core/hid/emulated_controller: Use ranges version of transform
...
Makes the transform calls much nicer to read.
2022-11-28 10:00:42 -05:00
2ec7d0b5fd
common/input: Add helpers functions for creating input and output devices
...
Avoids the redundancy of needing to explictly specify the common
namespace and the type.
2022-11-28 10:00:37 -05:00
7f42432f42
common/input: Pass ParamPackage by const reference in CreateDevice
...
This was previously being passed by value, which was unnecessary and
created more allocations than necessary.
2022-11-28 09:11:58 -05:00
e96f55b6e2
yuzu/main: Merge variable declaration into ifdef
...
This is only used in the non-Windows path.
2022-11-28 08:40:41 -05:00
6291eec700
Merge pull request #9325 from german77/default_by_default
...
yuzu-cmd: Fix default config value
2022-11-28 08:14:32 -05:00
aaada241dc
yuzu-cmd: Fix default config value
2022-11-27 20:43:34 -06:00
6b64557ad6
Merge pull request #8829 from Docteh/qt6_0002
...
CMake: rework for Qt6 support
2022-11-27 17:56:22 -05:00
Lioncash
Alexandre Bouvier
liamwhite
Fernando Sahmkow
Narr the Reg
Liam
bunnei
Matías Locatti
Feng Chen
ameerj
Kelebek1
Morph
lat9nq