DockerCLI/e2e
Ian Campbell ff2ed6efa8 cli-plugins: disable use of dial-stdio
Since #1654 so far we've had problems with it not working on Windows (npipe
lacked the `CloseRead` method) and problems with using tcp with tls (the tls
connection also lacks `CloseRead`). Both of these were workedaround in #1718
which added a nop `CloseRead` method.

However I am now seeing hangs (on Windows) where the `system dial-stdio`
subprocess is not exiting (I'm unsure why so far).

I think the 3rd problem found with this is an indication that `dial-stdio` is
not quite ready for wider use outside of its initial usecase (support for
`ssh://` URLs to connect to remote daemons).

This change simply disables the `dial-stdio` path for all plugins. However
rather than completely reverting 891b3d953e ("cli-plugins: use `docker system
dial-stdio` to call the daemon") I've just disabled the functionality at the
point of use and left in a trap door environment variable so that those who
want to experiment with this mode (and perhaps fully debug it) have an easier
path do doing so.

The e2e test for this case is disabled unless the trap door envvar is set. I
also renamed the test to clarify that it is about cli plugins.

Signed-off-by: Ian Campbell <ijc@docker.com>
2019-03-18 10:58:51 +00:00
..
cli-plugins cli-plugins: disable use of dial-stdio 2019-03-18 10:58:51 +00:00
container Add missing test 2018-11-26 14:02:16 +00:00
image Add option to pull images quietly 2018-12-19 13:48:41 +01:00
internal/fixtures Add missing test 2018-11-26 14:02:16 +00:00
plugin Fix: plugin-tests discarding current environment 2019-03-04 20:18:24 +01:00
stack Fix some typo 2018-09-07 17:18:00 +08:00
system Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
testdata e2e: avoid `usermod -p` by using `useradd`'s `--password` option 2019-03-11 14:25:41 +00:00
trust Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
compose-env.connhelper-ssh.yaml connhelper: add e2e 2018-09-30 10:24:34 +09:00
compose-env.experimental.yaml Make test-e2e run against experimental and non-experimental daemon 2018-06-25 11:46:35 +02:00
compose-env.yaml Add missing test 2018-11-26 14:02:16 +00:00