Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
The Docker CLI
6,299 Commits 11 Branches 241 Tags 240 MiB
Go 91.3%
Shell 5.8%
Go-Checksums 1.3%
Dockerfile 1.1%
Makefile 0.3%
Other 0.2%
Go to file
Sebastiaan van Stijn ee29504923
Do not disable sig-proxy when using a TTY 
This partially reverts e0b59ab52b,
and does not automatically disable proxying signals in TTY-mode

Before this change:
------------------------------------

Start a container with a TTY in one shell:

```
docker run -it --init --name repro-28872 busybox sleep 30
```

then, in another shell, kill the docker cli:

```
kill `pgrep -f repro-28872`
```

Notice that the CLI was killed, but the signal not forwarded to the container;
the container continues running

```
docker container inspect --format '{{ .State.Status }}' repro-28872
running

docker container rm -f repro-28872
```

After this change:
------------------------------------

Start a container with a TTY in one shell:

```
docker run -it --init --name repro-28872 busybox sleep 30
```

then, in another shell, kill the docker cli:

```
kill `pgrep -f repro-28872`
```

Verify that the signal was forwarded to the container, and the container exited

```
docker container inspect --format '{{ .State.Status }}' repro-28872
exited

docker container rm -f repro-28872
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 		2019-06-25 16:29:21 +02:00
.github Remove myself from codeowners 😅 2019-01-10 17:32:07 +01:00
cli Do not disable sig-proxy when using a TTY 2019-06-25 16:29:21 +02:00
cli-plugins cli-plugins: add test names for easier debugging 2019-05-22 15:35:34 +00:00
cmd/docker Use command.Cli instead of command.DockerCli 2019-04-26 15:43:03 +01:00
contrib/completion fix: docker login autocomplete for zsh 2019-06-14 13:23:41 +05:30
dockerfiles Bump golang 1.12.6 2019-06-12 15:36:52 +08:00
docs deprecate registry v2 schema 1 2019-06-24 23:04:27 +02:00
e2e e2e: add a test for `context ls` 2019-05-20 13:28:11 +01:00
experimental Fix link to Kubernetes blog 2018-12-29 01:39:54 +01:00
internal context: produce consistent output on `context create`. 2019-05-13 16:42:03 +01:00
kubernetes Use underlying `NewKubernetesConfig` directly from compose-on-kubernetes. 2019-05-14 15:43:15 +01:00
man Add exit status to docker exec manpage 2019-02-25 18:59:18 +00:00
opts Refactor network parsing, add preliminary support for multiple networks 2019-04-03 16:42:57 +02:00
scripts Support GOARM and windows .exe in binary target 2019-05-06 10:43:18 -07:00
service/logs Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
templates Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
types Remove unused helath check func 2018-10-02 20:52:34 +02:00
vendor bump docker-credential-helpers v0.6.2 2019-06-11 16:01:53 +02:00
.dockerignore make go build and docker build operations faster 2017-04-27 15:06:57 -07:00
.gitignore Update gitignore 2017-09-27 16:45:35 +02:00
.mailmap Update AUTHORS and mailmap 2019-04-27 17:39:39 -07:00
AUTHORS Update AUTHORS and mailmap 2019-04-27 17:39:39 -07:00
CONTRIBUTING.md Add Contribution guidelines 2017-07-28 11:33:19 -07:00
Jenkinsfile Add a Jenkinsfile 2017-08-16 10:46:43 -04:00
LICENSE Add project files 2017-04-17 17:49:33 -04:00
MAINTAINERS Remove outdated completion reviewers file 2018-08-01 15:08:36 +02:00
Makefile Allow control over dirs passed to e2e and unit tests 2019-03-11 16:02:55 +00:00
NOTICE Add project files 2017-04-17 17:49:33 -04:00
README.md Add jenkins build status to readme 2017-09-15 15:08:28 +02:00
TESTING.md Update TESTING.md to replace testify by gotest.tools 2018-07-02 09:24:28 +02:00
VERSION Bump version to 19.09.0-dev 2019-05-10 17:30:44 -07:00
appveyor.yml Bump golang 1.12.6 2019-06-12 15:36:52 +08:00
circle.yml CircleCI: store junit.xml as artifact 2019-05-07 14:02:16 -07:00
codecov.yml Fix PR comments 2018-01-03 10:23:32 +01:00
docker.Makefile Support GOARM and windows .exe in binary target 2019-05-06 10:43:18 -07:00
gometalinter.json Add support for kubernetes in docker cli 2017-12-26 11:22:32 +01:00
poule.yml Add github templates and initial poule configuration 2017-05-09 16:57:46 +02:00
vendor.conf bump docker-credential-helpers v0.6.2 2019-06-11 16:01:53 +02:00

README.md

build status Build Status

docker/cli

This repository is the home of the cli used in the Docker CE and Docker EE products.

Development

docker/cli is developed using Docker.

Build a linux binary:

$ make -f docker.Makefile binary

Build binaries for all supported platforms:

$ make -f docker.Makefile cross

Run all linting:

$ make -f docker.Makefile lint

List all the available targets:

$ make help

In-container development environment

Start an interactive development environment:

$ make -f docker.Makefile shell

In the development environment you can run many tasks, including build binaries:

$ make binary

Legal

Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.

Use and transfer of Docker may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, please see https://www.bis.doc.gov

Licensing

docker/cli is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.