mirror of https://github.com/docker/cli.git
ec7a9ad6e4
This removes the need for the core context code to import
`github.com/docker/cli/cli/context/kubernetes` which in turn reduces the
transitive import tree in this file to not pull in all of Kubernetes.
Note that this means that any calling code which is interested in the
kubernetes endpoint must import `github.com/docker/cli/cli/context/kubernetes`
itself somewhere in order to trigger the dynamic registration. In practice
anything which is interested in Kubernetes must import that package (e.g.
`./cli/command/context.list` does for the `EndpointFromContext` function) to do
anything useful, so this restriction is not too onerous.
As a special case a small amount of Kubernetes related logic remains in
`ResolveDefaultContext` to handle error handling when the stack orchestrator
includes Kubernetes. In order to avoid a circular import loop this hardcodes
the kube endpoint name.
Similarly to avoid an import loop the existing `TestDefaultContextInitializer`
cannot continue to unit test for the Kubernetes case, so that aspect of the
test is carved off into a very similar test in the kubernetes context package.
Lastly, note that the kubernetes endpoint is now modifiable via
`WithContextEndpointType`.
Signed-off-by: Ian Campbell <ijc@docker.com>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| builder | ||
| bundlefile | ||
| checkpoint | ||
| commands | ||
| config | ||
| container | ||
| context | ||
| engine | ||
| formatter | ||
| idresolver | ||
| image | ||
| inspect | ||
| manifest | ||
| network | ||
| node | ||
| plugin | ||
| registry | ||
| secret | ||
| service | ||
| stack | ||
| swarm | ||
| system | ||
| task | ||
| testdata | ||
| trust | ||
| volume | ||
| cli.go | ||
| cli_options.go | ||
| cli_options_test.go | ||
| cli_test.go | ||
| context.go | ||
| defaultcontextstore.go | ||
| defaultcontextstore_test.go | ||
| events_utils.go | ||
| orchestrator.go | ||
| orchestrator_test.go | ||
| registry.go | ||
| registry_test.go | ||
| streams.go | ||
| trust.go | ||
| utils.go | ||
| utils_test.go | ||