The Docker CLI
Go to file
Sebastiaan van Stijn e5d26a8d40
build: allow BuildKit to be used on Windows daemons that advertise it
Commit 6fef143dbc switched the CLI to use
BuildKit by default, but as part of that removed the use of the
BuildkitVersion field as returned by Ping.

Some follow-up changes in commits e38e6c51ff and
e7a8748b93 updated the logic for detecting whether
BuildKit should be used or the legacy builder, but hard-coded using the
legacy builder for Windows daemons.

While Windows / WCOW does not yet support BuildKit by default, there is
work in progress to implement it, so we should not hard-code the assumption
that a Windows daemon cannot support BuildKit.

On the daemon-side, [moby@7b153b9] (Docker v23.0) changed the default as
advertised by the daemon to be BuildKit for Linux daemons. That change
still hardcoded BuildKit to be unsupported for Windows daemons (and does
not yet allow overriding the config), but this may change for future
versions of the daemon, or test-builds.

This patch:

- Re-introduces checks for the BuildkitVersion field in the "Ping" response.
- If the Ping response from the daemon advertises that it supports BuildKit,
  the CLI will now use BuildKit as builder.
- If we didn't get a Ping response, or the Ping response did NOT advertise
  that the daemon supported BuildKit, we continue to use the current
  defaults (BuildKit for Linux daemons, and the legacy builder for Windows)
- Handling of the DOCKER_BUILDKIT environment variable is unchanged; for
  CLI.BuildKitEnabled, DOCKER_BUILDKIT always takes precedence, and for
  processBuilder the value is taken into account, but will print a warning
  when BuildKit is disabled and a Linux daemon is used. For Windows daemons,
  no warning is printed.

[moby@7b153b9]: 7b153b9e28

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-06-20 02:49:22 +02:00
.github gha: e2e: test against v27.0 release candidates 2024-06-18 13:32:40 +02:00
cli build: allow BuildKit to be used on Windows daemons that advertise it 2024-06-20 02:49:22 +02:00
cli-plugins Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
cmd/docker build: allow BuildKit to be used on Windows daemons that advertise it 2024-06-20 02:49:22 +02:00
contrib/completion Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
dockerfiles Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
docs deprecate experimental graphdriver plugins 2024-06-18 16:47:00 +02:00
e2e Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
experimental deprecate experimental graphdriver plugins 2024-06-18 16:47:00 +02:00
hack/otel OTEL collector/prometheus/aspire-dashboard stack for testing purposes 2024-04-30 12:25:19 +00:00
internal/test cli: Wrap Err stream 2024-06-11 17:59:48 +02:00
man Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
opts linting: fmt.Sprintf can be replaced with string concatenation (perfsprint) 2024-06-10 21:19:32 +02:00
scripts Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
service/logs service/logs: use strings.Cut 2022-12-29 15:19:31 +01:00
templates Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
vendor Merge pull request #5169 from thaJeztah/bump_swarmkit 2024-06-18 15:04:39 +02:00
.dockerignore validate manpages target 2022-02-25 17:11:17 +01:00
.gitattributes fix linguist with .gitattributes 2021-12-16 21:16:02 +01:00
.gitignore Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
.golangci.yml update golangci-lint to .v1.59.0 2024-06-10 21:19:32 +02:00
.mailmap update authors and mailmap 2023-12-21 01:12:19 +01:00
AUTHORS update authors and mailmap 2023-12-21 01:12:19 +01:00
CONTRIBUTING.md Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
Dockerfile update to go1.21.11 2024-06-04 23:39:27 +02:00
LICENSE Add project files 2017-04-17 17:49:33 -04:00
MAINTAINERS not actually a maintainer 2023-11-10 21:35:15 +01:00
Makefile Dockerfile: update mvdan/gofumpt to v0.6.0 2024-03-17 13:48:13 +01:00
NOTICE Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
README.md Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
TESTING.md tweak description of login/logout 2022-04-04 10:44:11 +02:00
VERSION bump version to v27.0.1-dev 2024-06-18 13:29:00 +02:00
codecov.yml Drop support for (archived) Compose-on-Kubernetes 2022-02-22 13:47:34 +01:00
docker-bake.hcl update to go1.21.11 2024-06-04 23:39:27 +02:00
docker.Makefile Cleanup of dockerfiles, compose files and env vars 2024-02-13 13:32:45 +00:00
vendor.mod Merge pull request #5169 from thaJeztah/bump_swarmkit 2024-06-18 15:04:39 +02:00
vendor.sum Merge pull request #5169 from thaJeztah/bump_swarmkit 2024-06-18 15:04:39 +02:00

README.md

Docker CLI

PkgGoDev Build Status Test Status Go Report Card Codecov

About

This repository is the home of the Docker CLI.

Development

docker/cli is developed using Docker.

Build CLI from source:

docker buildx bake

Build binaries for all supported platforms:

docker buildx bake cross

Build for a specific platform:

docker buildx bake --set binary.platform=linux/arm64 

Build dynamic binary for glibc or musl:

USE_GLIBC=1 docker buildx bake dynbinary 

Run all linting:

docker buildx bake lint shellcheck

Run test:

docker buildx bake test

List all the available targets:

make help

In-container development environment

Start an interactive development environment:

make -f docker.Makefile shell

Brought to you courtesy of our legal counsel. For more context, see the NOTICE document in this repo.

Use and transfer of Docker may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, see https://www.bis.doc.gov

Licensing

docker/cli is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.