DockerCLI/cli/command/service
Sebastiaan van Stijn c60b360c33
cli: improve argument validation output
Improve the output for these validation errors:

- Removes the short command description from the output. This information
  does not provide much useful help, and distracts from the error message.
- Reduces punctuation, and
- Prefixes the error message with the binary / root-command name
  (usually `docker:`) to be consistent with other similar errors.
- Adds an empty line between the error-message and the "call to action"
  (`Run 'docker volume --help'...` in the example below). This helps
  separating the error message and "usage" from the call-to-action.

Before this patch:

    $ docker volume ls one two three
    "docker volume ls" accepts no arguments.
    See 'docker volume ls --help'.

    Usage:  docker volume ls [OPTIONS]

    List volumes

    $ docker volume create one two three
    "docker volume create" requires at most 1 argument.
    See 'docker volume create --help'.

    Usage:  docker volume create [OPTIONS] [VOLUME]

    Create a volume

With this patch:

    $ docker volume ls one two three
    docker: 'docker volume ls' accepts no arguments

    Usage:  docker volume ls [OPTIONS]

    Run 'docker volume ls --help' for more information

    $ docker voludocker volume create one two three
    docker: 'docker volume create' requires at most 1 argument

    Usage:  docker volume create [OPTIONS] [VOLUME]

    SRun 'docker volume create --help' for more information

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-07-05 03:35:14 +02:00
..
progress linting: fmt.Sprintf can be replaced with string concatenation (perfsprint) 2024-06-10 21:19:32 +02:00
testdata Add support for --limit-pids on service create / update (swarm) 2020-06-18 21:25:02 +02:00
client_test.go vendor: github.com/docker/docker c6aaabc9fc82 (master / v27.0.0-dev) 2024-06-05 16:29:55 +02:00
cmd.go cli/command: use shallower interface for completions 2024-06-04 12:04:11 +02:00
create.go Add support for --detach flag in stack deploy 2024-03-04 09:36:36 +01:00
create_test.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
formatter.go vendor: github.com/docker/docker c6aaabc9fc82 (master / v27.0.0-dev) 2024-06-05 16:29:55 +02:00
formatter_test.go Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
generic_resource_opts.go linting: Consider pre-allocating sliceVar (prealloc) 2023-11-20 16:02:16 +01:00
generic_resource_opts_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-23 00:28:55 +01:00
helpers.go Add support for --detach flag in stack deploy 2024-03-04 09:36:36 +01:00
inspect.go Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
inspect_test.go Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
list.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
list_test.go linting: address assorted issues found by gocritic 2023-11-20 16:02:16 +01:00
logs.go linting: fmt.Sprintf can be replaced with string concatenation (perfsprint) 2024-06-10 21:19:32 +02:00
opts.go Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
opts_test.go vendor: github.com/docker/docker c6aaabc9fc82 (master / v27.0.0-dev) 2024-06-05 16:29:55 +02:00
parse.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
ps.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
ps_test.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
remove.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
rollback.go Add support for --detach flag in stack deploy 2024-03-04 09:36:36 +01:00
rollback_test.go cli: improve argument validation output 2024-07-05 03:35:14 +02:00
scale.go Add support for --detach flag in stack deploy 2024-03-04 09:36:36 +01:00
trust.go migrate reference github.com/distribution/reference 2023-09-05 17:53:20 +02:00
update.go vendor: github.com/docker/docker 1a1f3cff45ec (master, v27.0-dev) 2024-06-20 13:04:54 +02:00
update_test.go vendor: github.com/docker/docker 1a1f3cff45ec (master, v27.0-dev) 2024-06-20 13:04:54 +02:00