mirror of https://github.com/docker/cli.git
787caf2fe4
registerCompletionFuncForGlobalFlags was called from newDockerCommand,
at which time no context-store is initialized yet, so it would return
a nil value, probably resulting in `store.Names` to panic, but these
errors are not shown when running the completion. As a result, the flag
completion would fall back to completing from filenames.
This patch changes the function to dynamically get the context-store;
this fixes the problem mentioned above, because at the time the completion
function is _invoked_, the CLI is fully initialized, and does have a
context-store available.
A (non-exported) interface is defined to allow the function to accept
alternative implementations (not requiring a full command.DockerCLI).
Before this patch:
docker context create one
docker context create two
docker --context <TAB>
.DS_Store .idea/ Makefile
.dockerignore .mailmap build/
...
With this patch:
docker context create one
docker context create two
docker --context <TAB>
default one two
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| internal/signals | ||
| winresources | ||
| aliases.go | ||
| builder.go | ||
| builder_test.go | ||
| builder_windows_test.go | ||
| completions.go | ||
| docker.go | ||
| docker_test.go | ||
| docker_windows_386.go | ||
| docker_windows_amd64.go | ||
| docker_windows_arm.go | ||
| docker_windows_arm64.go | ||