DockerCLI/cli
Sebastiaan van Stijn d0ec8fa5cf
cli/command: ConfigureAuth: fix terminal state not being restored on error
ConfigureAuth used the readInput() utility to read the username and password.
However, this utility did not return errors it encountered, but instead did
an os.Exit(1). A result of this was that the terminal was not restored if
an error happened. When reading the password, the terminal is configured to
disable echo (i.e. characters are not printed), and failing to restore
the previous state means that the terminal is now "non-functional".

This patch:

- changes readInput() to return errors it encounters
- uses a defer() to restore terminal state

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-12 21:17:14 +02:00
..
command cli/command: ConfigureAuth: fix terminal state not being restored on error 2023-04-12 21:17:14 +02:00
compose cli/compose/schema: remove name for unused arg (revive) 2023-03-30 17:22:10 +02:00
config cli/config/configfile: remove deprecated StackOrchestrator field 2023-04-01 20:36:02 +02:00
connhelper cli/connhelper/commandconn: remove name for unused arg (revive) 2023-03-30 17:22:10 +02:00
context cli/context/docker: remove deprecated Endpoint.TLSPassword 2023-04-01 20:36:02 +02:00
debug updated vendoring 2017-09-01 19:41:06 -04:00
flags cli/flags: remove deprecated CommonOptions, NewCommonOptions 2023-04-01 20:36:02 +02:00
manifest manifest: save raw manifest content on download 2023-01-27 13:56:17 +00:00
registry/client replace uses of deprecated api/types.AuthConfig 2023-03-30 19:57:16 +02:00
streams cli/streams: minor refactoring and docs touch-ups 2023-04-03 11:27:26 +02:00
trust replace uses of deprecated api/types.AuthConfig 2023-03-30 19:57:16 +02:00
version Move versioning variables to a separate package. 2019-01-29 11:26:40 +00:00
winresources Use goversioninfo to create Windows Version Info 2021-10-11 16:54:22 +02:00
cobra.go load plugin command stubs when required 2023-03-28 06:16:55 +02:00
cobra_test.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
error.go Import docker/docker/cli 2017-04-17 17:40:59 -04:00
required.go format (GoDoc) comments with Go 1.19 to prepare for go updates 2022-07-19 19:10:16 +02:00
required_test.go cli: remove deprecated io/ioutil 2022-02-25 15:42:19 +01:00