Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
DockerCLI/cli/command
History
Sebastiaan van Stijn 809eb8cdee
images: print hint when invoking "docker images" with ambiguous argument 
The `docker images` top-level subcommand predates the `docker <object> <verb>`
convention (e.g. `docker image ls`), but accepts a positional argument to
search/filter images by name (globbing). It's common for users to accidentally
mistake these commands, and to use (e.g.) `docker images ls`, expecting
to see all images, but ending up with an empty list because no image named
"ls" was found.

Disallowing these search-terms would be a breaking change, but we can print
and informational message to help the users correct their mistake.

Before this patch:

    docker images ls
    REPOSITORY   TAG       IMAGE ID   CREATED   SIZE

With this patch applied:

    docker images ls
    REPOSITORY   TAG       IMAGE ID   CREATED   SIZE

    No images found matching "ls": did you mean "docker image ls"?

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 		2024-02-03 18:10:55 +01:00
..
builder Plumb contexts through commands 2023-12-12 22:30:16 +01:00
checkpoint cli/command: don't use pflags.XXXVarP for flags without shorthand 2024-01-29 11:16:38 +01:00
commands remove exec, push, pull, ps, images, info from "legacy" commands 2022-04-08 16:55:39 +02:00
completion Replace deprecated types.Image* usage 2024-01-24 14:59:10 +01:00
config cli/command: don't use pflags.XXXVarP for flags without shorthand 2024-01-29 11:16:38 +01:00
container cli/command: don't use pflags.XXXVarP for flags without shorthand 2024-01-29 11:16:38 +01:00
context add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
formatter add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
idresolver add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
image images: print hint when invoking "docker images" with ambiguous argument 2024-02-03 18:10:55 +01:00
inspect add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
manifest Plumb contexts through commands 2023-12-12 22:30:16 +01:00
network add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
node add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
plugin add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
registry cli/command: don't use pflags.XXXVarP for flags without shorthand 2024-01-29 11:16:38 +01:00
secret cli/command: don't use pflags.XXXVarP for flags without shorthand 2024-01-29 11:16:38 +01:00
service add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
stack add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
swarm cli/command: don't use pflags.XXXVarP for flags without shorthand 2024-01-29 11:16:38 +01:00
system info: remove printSecurityOptionsWarnings, printServerWarnings 2024-01-23 18:23:35 +01:00
task linting: address slice-append issues found by gocritic 2023-11-20 16:02:17 +01:00
testdata Dynamically register kubernetes context store endpoint type. 2019-05-20 13:28:11 +01:00
trust Replace deprecated types.Image* usage 2024-01-24 14:59:10 +01:00
volume add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
cli.go add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
cli_options.go cli/command: remove deprecated DockerCliOption, InitializeOpt 2024-01-20 21:39:32 +01:00
cli_options_test.go golangci-lint: enable thelper linter 2023-11-20 16:02:17 +01:00
cli_test.go cli/command: initialize client and load content lazily 2022-11-28 16:52:02 +01:00
context.go add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
context_test.go add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
defaultcontextstore.go add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
defaultcontextstore_test.go add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
events_utils.go vendor: github.com/docker/docker 7abd7fa73965 (v25.0.0-dev) 2023-09-05 13:43:35 +02:00
registry.go migrate reference github.com/distribution/reference 2023-09-05 17:53:20 +02:00
registry_test.go cli/command: remove dot-imports and unhandled errors 2023-10-23 15:21:47 +02:00
trust.go Refactor content_trust cli/flags handling 2018-03-08 15:00:43 -05:00
utils.go add //go:build directives to prevent downgrading to go1.16 language 2023-12-14 15:03:46 +01:00
utils_test.go format go with gofumpt (with -lang=1.19) 2022-09-30 19:14:36 +02:00