The Docker CLI
Go to file
Laura Brehm c7f3031f74
tests/run: fix flaky `RunAttachTermination` test
This test was just incorrect (and testing incorrect
behavior): it was checking that `docker run` exited with a `context
canceled` error after signalling the CLI/cancelling the command's
context, but this was incorrect (and was fixed in
991b1303da - which was when this test
started failing).

However, since this test assertion was happening inside of a goroutine,
it would sometimes pass if this assertion didn't get to run before the
test suite terminated. It was flaky because sometimes this assertion
inside the goroutine did get to execute, but after the test finished
execution, which is a big no-no.

As an aside, assertions inside goroutines are generally bad, and `govet`
even has a linter for this (but it only catches `t.Fatal` and `t.FailNow`
calls and not `assert.Xx`.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
(cherry picked from commit eac83574c1)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2024-08-07 12:05:30 +02:00
.github gha: update to macOS 13, add macOS 14 arm64 (Apple Silicon M1) 2024-07-19 13:28:07 +02:00
cli tests/run: fix flaky `RunAttachTermination` test 2024-08-07 12:05:30 +02:00
cli-plugins cli: make initializing the global meter- and tracing providers optional 2024-06-24 15:44:20 +02:00
cmd/docker cmd/docker: fix completion for --context 2024-07-19 01:56:24 +02:00
contrib/completion Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
dockerfiles Merge pull request #5265 from thaJeztah/27.1_backport_bump_buildx_compose 2024-07-19 12:55:55 +02:00
docs Allow for OomScoreAdj 2024-07-19 19:06:39 +02:00
e2e attach: wait for exit code from `ContainerWait` 2024-07-26 15:48:37 +01:00
experimental deprecate experimental graphdriver plugins 2024-06-18 16:47:00 +02:00
hack/otel OTEL collector/prometheus/aspire-dashboard stack for testing purposes 2024-04-30 12:25:19 +00:00
internal/test cli: Wrap Err stream 2024-06-11 17:59:48 +02:00
man Additional typo corrections 2024-06-20 12:18:43 +02:00
opts test spring-cleaning 2024-07-19 13:37:27 +02:00
scripts docs: fix typos and version for cli-docs-tool scripts 2024-07-19 02:04:44 +02:00
service/logs service/logs: use strings.Cut 2022-12-29 15:19:31 +01:00
templates Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
vendor vendor: github.com/docker/docker v27.1.1 2024-07-24 00:23:56 +02:00
.dockerignore validate manpages target 2022-02-25 17:11:17 +01:00
.gitattributes fix linguist with .gitattributes 2021-12-16 21:16:02 +01:00
.gitignore Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
.golangci.yml update golangci-lint to .v1.59.0 2024-06-10 21:19:32 +02:00
.mailmap update mailmap and AUTHORS 2024-06-20 13:22:11 +02:00
AUTHORS update mailmap and AUTHORS 2024-06-20 13:22:11 +02:00
CONTRIBUTING.md Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
Dockerfile Dockerfile: update compose to v2.29.0 2024-07-19 02:46:00 +02:00
LICENSE Add project files 2017-04-17 17:49:33 -04:00
MAINTAINERS not actually a maintainer 2023-11-10 21:35:15 +01:00
Makefile Makefile: add completion target 2024-07-19 01:55:36 +02:00
NOTICE Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
README.md Removed all mentions of "please" from docs and messages 2024-06-11 16:53:40 +02:00
TESTING.md tweak description of login/logout 2022-04-04 10:44:11 +02:00
VERSION bump version to v27.0.1-dev 2024-06-18 13:29:00 +02:00
codecov.yml Drop support for (archived) Compose-on-Kubernetes 2022-02-22 13:47:34 +01:00
docker-bake.hcl update to go1.21.12 2024-07-03 12:16:54 +02:00
docker.Makefile Cleanup of dockerfiles, compose files and env vars 2024-02-13 13:32:45 +00:00
vendor.mod vendor: github.com/docker/docker v27.1.1 2024-07-24 00:23:56 +02:00
vendor.sum vendor: github.com/docker/docker v27.1.1 2024-07-24 00:23:56 +02:00

README.md

Docker CLI

PkgGoDev Build Status Test Status Go Report Card Codecov

About

This repository is the home of the Docker CLI.

Development

docker/cli is developed using Docker.

Build CLI from source:

docker buildx bake

Build binaries for all supported platforms:

docker buildx bake cross

Build for a specific platform:

docker buildx bake --set binary.platform=linux/arm64 

Build dynamic binary for glibc or musl:

USE_GLIBC=1 docker buildx bake dynbinary 

Run all linting:

docker buildx bake lint shellcheck

Run test:

docker buildx bake test

List all the available targets:

make help

In-container development environment

Start an interactive development environment:

make -f docker.Makefile shell

Brought to you courtesy of our legal counsel. For more context, see the NOTICE document in this repo.

Use and transfer of Docker may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, see https://www.bis.doc.gov

Licensing

docker/cli is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.