Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
DockerCLI/opts
History
Sebastiaan van Stijn 95e221ef4d
opts: remove ErrBadKey as it's not used as a sentinel error 
This error was originally introduced `ErrBadEnvVariable` in [moby/moby@500c8ba],
but merely for convenience, and not used as a sentinel error. After the code
was moved from the daemon to the cli repository, it was renamed to be more
generic `ErrBadKey` in commit 2b17f4c8a8.

A search on GitHub shows that there's no consumers using this error as
sentinel error, and it's not used in our own code as such, so it should
be safe to remove this error.

This patch removes the `ErrBadKey` error-type; it also removes the prefix
(`poorly formatted environment:`) to make the error more generic, because
the same function was used both for env-files and label-files.

[moby/moby@500c8ba]: 500c8ba4b6

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 		2024-10-03 17:22:22 +02:00
..
capabilities.go opts: NormalizeCapability(): fix redefinition of the built-in function (revive) 2023-03-30 17:05:31 +02:00
capabilities_test.go format code with gofumpt 2022-09-30 11:59:11 +02:00
config.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
config_test.go format go with gofumpt (with -lang=1.19) 2022-09-30 19:14:36 +02:00
duration.go Move duration opts into an opts package 2017-05-16 17:49:40 +02:00
duration_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-23 00:28:55 +01:00
env.go opts: use strings.Cut for handling key/value pairs 2022-12-29 15:14:15 +01:00
env_test.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
envfile.go format (GoDoc) comments with Go 1.19 to prepare for go updates 2022-07-19 19:10:16 +02:00
envfile_test.go opts: cleanup ParseEnvFile tests 2024-10-03 14:08:22 +02:00
file.go opts: remove ErrBadKey as it's not used as a sentinel error 2024-10-03 17:22:22 +02:00
gpus.go opts: use strings.Cut for handling key/value pairs 2022-12-29 15:14:15 +01:00
gpus_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-23 00:28:55 +01:00
hosts.go Permit '=' separator and '[ipv6]' in --add-host 2023-12-07 18:29:19 +00:00
hosts_test.go linting: fmt.Sprintf can be replaced with string concatenation (perfsprint) 2024-06-10 21:19:32 +02:00
hosts_unix.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
hosts_windows.go gofmt with go1.17 2022-03-26 20:21:00 +01:00
mount.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
mount_test.go mount: add `bind-recursive=<bool|string>` and deprecate `bind-nonrecursive=<bool>` 2023-10-01 02:58:17 +09:00
network.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
network_test.go Test quoted field in --network 2024-05-26 13:14:01 +01:00
opts.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
opts_test.go test/ Improve test coverage in volume.go 2024-03-20 19:53:33 +01:00
parse.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
parse_test.go replace uses of deprecated env.Patch() 2022-09-22 17:28:07 +02:00
port.go test spring-cleaning 2024-07-04 01:35:12 +02:00
port_test.go golangci-lint: enable thelper linter 2023-11-20 16:02:17 +01:00
quotedstring.go opts: fix potential panic in trimQuotes 2022-06-09 08:00:33 +02:00
quotedstring_test.go opts: fix potential panic in trimQuotes 2022-06-09 08:00:33 +02:00
secret.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
secret_test.go format go with gofumpt (with -lang=1.19) 2022-09-30 19:14:36 +02:00
throttledevice.go run: fix GetList return empty issue for throttledevice 2024-08-07 02:48:39 +00:00
ulimit.go vendor: github.com/docker/docker 1a1f3cff45ec (master, v27.0-dev) 2024-06-20 13:04:54 +02:00
ulimit_test.go vendor: github.com/docker/docker 1a1f3cff45ec (master, v27.0-dev) 2024-06-20 13:04:54 +02:00
weightdevice.go linting: Consider pre-allocating sliceVar (prealloc) 2023-11-20 16:02:16 +01:00