The Docker CLI
Go to file
Sebastiaan van Stijn 6f7a931a2d
[20.10] use GO_LDFLAGS instead of LDFLAGS to prevent inheriting unrelated options
When building on Fedora 36, the build failed. I suspect this is because the
rpm tools also set LDFLAGS, but with options that cannot be used;

    GO_LINKMODE=dynamic
    + ./scripts/build/binary
      /go/src/github.com/docker/cli ~/rpmbuild/BUILD/src
      Building dynamic docker-linux-arm64
      + go build -o build/docker-linux-arm64 -tags ' pkcs11' -ldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -Wl,-dT,/root/rpmbuild/BUILD/src/.package_note-docker-ce-cli-0.0.0.20220330082637.68cad50-0.fc36.aarch64.ld -w -X "github.com/docker/cli/cli/version.GitCommit=68cad50" -X "github.com/docker/cli/cli/version.BuildTime=2022-03-30T20:05:36Z" -X "github.com/docker/cli/cli/version.Version=0.0.0-20220330082637-68cad50" -X "github.com/docker/cli/cli/version.PlatformName=Docker Engine - Community"' -buildmode=pie github.com/docker/cli/cmd/docker
    # github.com/docker/cli/cmd/docker
    flag provided but not defined: -Wl,-z,relro
    usage: link [options] main.o

This patch changes the variable we use to `GO_LDFLAGS`, taking a similar approach
as containerd, and various other projects using this name: https://grep.app/search?q=GO_LDFLAGS

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 391e6ad944)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-31 14:12:25 +02:00
.circleci circleCI: update docker engine to 20.10.6 2021-07-02 16:53:15 +02:00
.github GH Actions: run CodeQL only on cron-job, not on pull requests 2020-10-01 16:51:28 +02:00
cli fix innocuous data-race when config.Load called in parallel 2022-01-27 10:37:14 +01:00
cli-plugins Use golang.org/x/sys/execabs 2021-01-28 22:27:59 +00:00
cmd/docker config: print deprecation warning when falling back to ~/.dockercfg 2021-03-08 17:21:15 +01:00
contrib/completion Add docs and completion for docker node ls --filter node.label 2021-02-04 14:33:15 +01:00
dockerfiles [20.10] update to go 1.16.15 to address CVE-2022-24921 2022-03-04 16:45:28 +01:00
docs Fix mistake with env var example in docker run docs 2022-02-18 12:44:39 +01:00
e2e change TestNewAPIClientFromFlagsWithHttpProxyEnv to an e2e test 2021-07-29 12:11:10 +02:00
experimental experimental: fix broken link to "checkpoint and restore" page 2021-10-06 16:48:18 +02:00
internal/test Fix container creation time in test/builders 2020-12-16 08:55:29 +07:00
kubernetes Always enable experimental features 2020-10-02 15:59:42 +02:00
man docs: rewrite reference docs for --stop-signal and --stop-timeout 2021-10-06 16:48:50 +02:00
opts opts: fix potential integer overflow CWE-190, CWE-681 2020-10-24 01:30:42 +02:00
scripts [20.10] use GO_LDFLAGS instead of LDFLAGS to prevent inheriting unrelated options 2022-03-31 14:12:25 +02:00
service/logs bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-23 00:28:55 +01:00
templates bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-23 00:28:55 +01:00
vendor [20.10] vendor: compose-on-kubernetes v0.5.0 to remove github.com/golang/glog 2022-02-14 14:49:04 +01:00
.dockerignore dockerfile based binary building 2021-04-06 19:53:48 +00:00
.gitignore update windows resources generation 2021-04-06 19:53:48 +00:00
.golangci.yml Remove now obsolete gometalinter and use golangci-lint instead 2019-10-31 19:22:44 +01:00
.mailmap Update authors and mailmap 2020-08-06 01:58:32 +02:00
AUTHORS Update authors and mailmap 2020-08-06 01:58:32 +02:00
CONTRIBUTING.md Fix broken link in CONTRIBUTING 2020-03-19 15:03:59 +01:00
Dockerfile [20.10] update to go 1.16.15 to address CVE-2022-24921 2022-03-04 16:45:28 +01:00
Jenkinsfile Jenkinsfile: update old engine version to 19.03 2021-07-02 16:53:13 +02:00
LICENSE Add project files 2017-04-17 17:49:33 -04:00
MAINTAINERS Maintainers: remove Justin and Aaron 2019-12-04 13:08:15 +01:00
Makefile Makefile: have binary, cross, dynbinary targets not use docker for backwards compat 2021-04-06 19:53:48 +00:00
NOTICE switch kr/pty to creack/pty v1.1.7 2019-07-29 16:45:41 -07:00
README.md update readme with new examples 2021-04-06 19:53:48 +00:00
TESTING.md Update TESTING.md to replace testify by gotest.tools 2018-07-02 09:24:28 +02:00
VERSION Update version to 20.10-dev 2020-10-13 09:37:17 +02:00
appveyor.yml [20.10] update to go 1.16.15 to address CVE-2022-24921 2022-03-04 16:45:28 +01:00
codecov.yml Fix PR comments 2018-01-03 10:23:32 +01:00
docker-bake.hcl bake: remove windows targets other than windows/amd64 2021-04-09 03:13:23 +00:00
docker.Makefile remove unused targets 2021-04-06 19:53:48 +00:00
poule.yml Add github templates and initial poule configuration 2017-05-09 16:57:46 +02:00
vendor.conf [20.10] vendor.conf: don't use git:// protocol 2022-03-31 13:34:40 +02:00

README.md

build status Build Status

docker/cli

This repository is the home of the cli used in the Docker CE and Docker EE products.

Development

docker/cli is developed using Docker.

Build CLI from source:

$ docker buildx bake

Build binaries for all supported platforms:

$ docker buildx bake cross

Build for a specific platform:

$ docker buildx bake --set binary.platform=linux/arm64 

Build dynamic binary for glibc or musl:

$ USE_GLIBC=1 docker buildx bake dynbinary 

Run all linting:

$ make -f docker.Makefile lint

List all the available targets:

$ make help

In-container development environment

Start an interactive development environment:

$ make -f docker.Makefile shell

Legal

Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.

Use and transfer of Docker may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, please see https://www.bis.doc.gov

Licensing

docker/cli is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.