DockerCLI/cli/command/system
Sebastiaan van Stijn 88ca4e958f
info: stop printing "Expected" commits
The `Commit` type was introduced in 2790ac68b3,
to assist triaging issues that were reported with an incorrect version of
runc or containerd. At the time, both `runc` and `containerd` were not yet
stable, and had to be built from a specific commit to guarantee compatibility.

We encountered various situations where unexpected (and incompatible) versions
of those binaries were packaged, resulting in hard to trace bug-reports.
For those situations, a "expected" version was set at compile time, to
indicate if the version installed was different from the expected version;

    docker info
    ...
    runc version: a592beb5bc4c4092b1b1bac971afed27687340c5 (expected: 69663f0bd4b60df09991c08812a60108003fa340)

Both `runc` and `containerd` are stable now, and docker 19.03 and up set the
expected version to the actual version since c65f0bd13c
and 23.0 did the same for the `init` binary b585c64e2b,
to prevent the CLI from reporting "unexpected version".

In short; the `Expected` fields no longer serves a real purpose, so we should
no longer print it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-09-10 13:49:12 +02:00
..
testdata info: remove printServerWarningsLegacy 2024-01-20 20:45:59 +01:00
client_test.go vendor: github.com/docker/docker a736d0701c41 (master, v27.0.0-dev) 2024-06-10 17:41:09 +02:00
cmd.go Revert "Disable `docker system dial-stdio` on Windows" 2019-03-12 14:57:52 +00:00
df.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
dial_stdio.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
events.go vendor: github.com/docker/docker a736d0701c41 (master, v27.0.0-dev) 2024-06-10 17:41:09 +02:00
events_test.go vendor: github.com/docker/docker a736d0701c41 (master, v27.0.0-dev) 2024-06-10 17:41:09 +02:00
info.go info: stop printing "Expected" commits 2024-09-10 13:49:12 +02:00
info_test.go cli: make cli.StatusError slightly prettier 2024-07-04 22:08:18 +02:00
inspect.go Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
prune.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
prune_test.go test spring-cleaning 2024-07-04 01:35:12 +02:00
version.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
version_test.go test spring-cleaning 2024-07-04 01:35:12 +02:00