mirror of https://github.com/docker/cli.git
60d0450287
Previously, if while polling for oauth device-code login results a user suspended the process (such as with CTRL-Z) and then restored it with `fg`, an error might occur in the form of: ``` failed waiting for authentication: You are polling faster than the specified interval of 5 seconds. ``` This is due to our use of a `time.Ticker` here - if no receiver drains the ticker channel (and timers/tickers use a buffered channel behind the scenes), more than one tick will pile up, causing the program to "tick" twice, in fast succession, after it is resumed. The new implementation replaces the `time.Ticker` with a `time.Timer` (`time.Ticker` is just a nice wrapper) and introduces a helper function `resetTimer` to ensure that before every `select`, the timer is stopped and it's channel is drained. Signed-off-by: Laura Brehm <laurabrehm@hey.com> |
||
|---|---|---|
| .. | ||
| command | ||
| compose | ||
| config | ||
| connhelper | ||
| context | ||
| debug | ||
| flags | ||
| hints | ||
| internal/oauth | ||
| manifest | ||
| registry/client | ||
| streams | ||
| trust | ||
| version | ||
| winresources | ||
| cobra.go | ||
| cobra_test.go | ||
| error.go | ||
| required.go | ||
| required_test.go | ||