DockerCLI/cli/connhelper/commandconn
Laura Brehm a5ebe2282a
commandconn: don't return error if command closed successfully
---
commandconn: fix race on `Close()`

During normal operation, if a `Read()` or `Write()` call results
in an EOF, we call `onEOF()` to handle the terminating command,
and store it's exit value.

However, if a Read/Write call was blocked while `Close()` is called
the in/out pipes are immediately closed which causes an EOF to be
returned. Here, we shouldn't call `onEOF()`, since the reason why
we got an EOF is because we're already terminating the connection.
This also prevents a race between two calls to the commands `Wait()`,
in the `Close()` call and `onEOF()`

---
Add CLI init timeout to SSH connections

---
connhelper: add 30s ssh default dialer timeout

(same as non-ssh dialer)

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
2023-06-09 11:24:19 +02:00
..
commandconn.go commandconn: don't return error if command closed successfully 2023-06-09 11:24:19 +02:00
commandconn_unix_test.go commandconn: don't return error if command closed successfully 2023-06-09 11:24:19 +02:00
pdeathsig_linux.go commandconn: set SysProcAttr.Setsid 2019-03-06 13:22:54 +09:00
pdeathsig_nolinux.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
session_unix.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
session_windows.go commandconn: set SysProcAttr.Setsid 2019-03-06 13:22:54 +09:00