Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
DockerCLI/cli/command/container
History
Sebastiaan van Stijn 2331e4d521
cli/command/container: don't mutate ConfigFile.DetachKeys 
This code was introduced in 15aa2a663b,
but from those changes, it appears that overwriting the config value was
merely out of convenience, and that struct being used as an intermediate.

While changing the config here should be mostly ephemeral, and not written
back to the config-file, let's be clear on intent, and not mutatte the config
as part of this code.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 		2023-06-08 16:54:41 +02:00
..
testdata docker ps: always use --quiet, also combined with --format 2023-04-10 01:12:00 +02:00
attach.go cli/command/container: don't mutate ConfigFile.DetachKeys 2023-06-08 16:54:41 +02:00
attach_test.go vendor: github.com/docker/docker 2ed904cad7055847796433cc56ef1d1de0da868c 2022-04-30 12:01:37 +02:00
client_test.go cli/command/container: fakeClient: remove name for unused arg (revive) 2023-03-30 17:22:05 +02:00
cmd.go Update gometalinter 2017-10-26 12:21:02 -04:00
commit.go cmd: set double quotes as code delimiter 2023-01-06 19:15:33 +01:00
cp.go Merge pull request #4137 from cpuguy83/fix_cp_no_tty 2023-03-31 21:06:26 +02:00
cp_test.go format code with gofumpt 2022-09-30 11:59:11 +02:00
create.go cli/command/container: createContainer(): return container-ID 2023-06-08 16:54:41 +02:00
create_test.go cli/command/container: createContainer(): return container-ID 2023-06-08 16:54:41 +02:00
diff.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
exec.go cmd: set double quotes as code delimiter 2023-01-06 19:15:33 +01:00
exec_test.go format code with gofumpt 2022-09-30 11:59:11 +02:00
export.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
export_test.go cli/command/container: remove deprecated io/ioutil 2022-02-25 15:36:23 +01:00
formatter_diff.go vendor: github.com/docker/docker v24.0.0-rc.1.0.20230505222407-8d9a40a82034 2023-05-06 00:34:34 +02:00
formatter_diff_test.go vendor: github.com/docker/docker v24.0.0-rc.1.0.20230505222407-8d9a40a82034 2023-05-06 00:34:34 +02:00
formatter_stats.go cli/command/container: use RWMutex for stats to allow concurrent reads 2022-05-13 21:39:03 +02:00
formatter_stats_test.go cli/command/container: add BenchmarkStatsFormat() 2022-05-13 21:26:38 +02:00
hijack.go cli/command/container: hijackedIOStreamer: explicitly ignore err 2023-05-03 17:01:08 +02:00
inspect.go Adopt Cobra completion v2 to support completion by CLI plugins 2022-05-12 12:59:10 +02:00
kill.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
list.go docker ps: print warning if both --format and --quiet are set 2023-04-10 01:17:48 +02:00
list_test.go docker ps: print warning if both --format and --quiet are set 2023-04-10 01:17:48 +02:00
logs.go cmd: set double quotes as code delimiter 2023-01-06 19:15:33 +01:00
logs_test.go format code with gofumpt 2022-09-30 11:59:11 +02:00
opts.go cli/command/container: implement `docker run --annotation` 2023-04-14 12:59:12 +09:00
opts_test.go cli/command/container: rename vars that collided 2023-04-10 00:32:51 +02:00
pause.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
port.go cli/command/container: runPort: sort ports before printing 2022-12-01 10:58:40 +01:00
port_test.go cli/command/container: runPort: sort ports before printing 2022-12-01 10:58:40 +01:00
prune.go cli/command: RunPrune(): remove name for unused "all" parameter (revive) 2023-03-30 17:05:30 +02:00
rename.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
restart.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
rm.go rm: allow `docker container remove` as an alias 2023-01-29 08:46:08 +09:00
rm_test.go cli/rm_test: Fix TestRemoveForce race condition 2023-01-04 10:57:45 +01:00
run.go cli/command/container: don't mutate ConfigFile.DetachKeys 2023-06-08 16:54:41 +02:00
run_test.go container: validate --pull option on create and run 2022-06-28 13:58:50 +02:00
signals.go Fix typo 2021-11-05 18:10:51 +01:00
signals_test.go format code with gofumpt 2022-09-30 11:59:11 +02:00
signals_unix.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
signals_unix_test.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
signals_windows.go Ignore SIGURG on Darwin too 2021-05-24 19:37:53 +01:00
start.go cli/command/container: don't mutate ConfigFile.DetachKeys 2023-06-08 16:54:41 +02:00
stats.go format (GoDoc) comments with Go 1.19 to prepare for go updates 2022-07-19 19:10:16 +02:00
stats_helpers.go cli/command/container: use RWMutex for stats to allow concurrent reads 2022-05-13 21:39:03 +02:00
stats_helpers_test.go calculateMemUsageUnixNoCache: subtract total_inactive_file, not cache 2020-04-11 08:13:21 +09:00
stats_unit_test.go use char to check blockIO type 2019-03-11 10:01:22 +08:00
stop.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
top.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
tty.go Retry initializing TTY size a bit more 2022-05-02 14:23:07 +02:00
tty_test.go Sleep for 1.5 seconds before looking at the resize error 2022-05-02 17:01:01 +02:00
unpause.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
update.go cmd: set double quotes as code delimiter 2023-01-06 19:15:33 +01:00
utils.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
utils_test.go vendor: github.com/docker/docker 2ed904cad7055847796433cc56ef1d1de0da868c 2022-04-30 12:01:37 +02:00
wait.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00