DockerCLI/cli/command/container
Sebastiaan van Stijn 594aeb390a
cli/command: remove dot-imports and unhandled errors
Please the linters in preparation of updating golangci-lint;

- remove dot-imports
- add some checks for unhandled errors
- replace some fixed-value variables for consts

    cli/command/image/build/context.go:238:17: G107: Potential HTTP request made with variable url (gosec)
        if resp, err = http.Get(url); err != nil {
                       ^
    cli/command/idresolver/idresolver_test.go:7:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/registry_test.go:7:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/cli/command" // Prevents a circular import with "github.com/docker/cli/internal/test"
        ^
    cli/command/task/print_test.go:11:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/swarm/update_test.go:10:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/swarm/unlock_key_test.go:9:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/swarm/join_token_test.go:9:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/node/list_test.go:9:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/node/promote_test.go:8:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/node/demote_test.go:8:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package functions
        ^
    cli/command/node/ps_test.go:11:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/node/update_test.go:8:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/node/inspect_test.go:9:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package functions
        ^
    cli/command/secret/ls_test.go:11:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/secret/inspect_test.go:11:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/volume/inspect_test.go:9:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/volume/list_test.go:9:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/config/inspect_test.go:11:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/config/ls_test.go:11:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/network/list_test.go:9:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders"
        ^
    cli/command/container/list_test.go:10:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/service/list_test.go:12:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders"
        ^
    cli/command/service/client_test.go:6:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/stack/list_test.go:8:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/stack/services_test.go:9:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^
    cli/command/stack/ps_test.go:10:2: dot-imports: should not use dot imports (revive)
        . "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
        ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-10-23 15:21:47 +02:00
..
testdata docker ps: always use --quiet, also combined with --format 2023-04-10 01:12:00 +02:00
attach.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
attach_test.go vendor: github.com/docker/docker 2ed904cad7055847796433cc56ef1d1de0da868c 2022-04-30 12:01:37 +02:00
client_test.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
cmd.go Update gometalinter 2017-10-26 12:21:02 -04:00
commit.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
cp.go Merge pull request #4137 from cpuguy83/fix_cp_no_tty 2023-03-31 21:06:26 +02:00
cp_test.go format code with gofumpt 2022-09-30 11:59:11 +02:00
create.go migrate reference github.com/distribution/reference 2023-09-05 17:53:20 +02:00
create_test.go replace uses of deprecated api/types that moved to api/types/system 2023-07-15 01:20:49 +02:00
diff.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
exec.go cmd: set double quotes as code delimiter 2023-01-06 19:15:33 +01:00
exec_test.go format code with gofumpt 2022-09-30 11:59:11 +02:00
export.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
export_test.go cli/command/container: remove deprecated io/ioutil 2022-02-25 15:36:23 +01:00
formatter_diff.go vendor: github.com/docker/docker v24.0.0-rc.1.0.20230505222407-8d9a40a82034 2023-05-06 00:34:34 +02:00
formatter_diff_test.go vendor: github.com/docker/docker v24.0.0-rc.1.0.20230505222407-8d9a40a82034 2023-05-06 00:34:34 +02:00
formatter_stats.go cli/command/container: use RWMutex for stats to allow concurrent reads 2022-05-13 21:39:03 +02:00
formatter_stats_test.go cli/command/container: add BenchmarkStatsFormat() 2022-05-13 21:26:38 +02:00
hijack.go cli/command/container: hijackedIOStreamer: explicitly ignore err 2023-05-03 17:01:08 +02:00
inspect.go Adopt Cobra completion v2 to support completion by CLI plugins 2022-05-12 12:59:10 +02:00
kill.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
list.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
list_test.go cli/command: remove dot-imports and unhandled errors 2023-10-23 15:21:47 +02:00
logs.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
logs_test.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
opts.go mount: add `bind-recursive=<bool|string>` and deprecate `bind-nonrecursive=<bool>` 2023-10-01 02:58:17 +09:00
opts_test.go Add missing opts to --network advanced syntax 2023-09-10 18:57:50 +02:00
pause.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
port.go cli/command/container: runPort: sort ports before printing 2022-12-01 10:58:40 +01:00
port_test.go cli/command/container: runPort: sort ports before printing 2022-12-01 10:58:40 +01:00
prune.go cli/command: RunPrune(): remove name for unused "all" parameter (revive) 2023-03-30 17:05:30 +02:00
rename.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
restart.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
rm.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
rm_test.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
run.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
run_test.go container: validate --pull option on create and run 2022-06-28 13:58:50 +02:00
signals.go Fix typo 2021-11-05 18:10:51 +01:00
signals_test.go format code with gofumpt 2022-09-30 11:59:11 +02:00
signals_unix.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
signals_unix_test.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
signals_windows.go Ignore SIGURG on Darwin too 2021-05-24 19:37:53 +01:00
start.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
stats.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
stats_helpers.go cli/command/container: use RWMutex for stats to allow concurrent reads 2022-05-13 21:39:03 +02:00
stats_helpers_test.go calculateMemUsageUnixNoCache: subtract total_inactive_file, not cache 2020-04-11 08:13:21 +09:00
stats_unit_test.go use char to check blockIO type 2019-03-11 10:01:22 +08:00
stop.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
top.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
tty.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
tty_test.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
unpause.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
update.go cmd: set double quotes as code delimiter 2023-01-06 19:15:33 +01:00
utils.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
utils_test.go cli/command/container: waitExitOrRemoved: take APIClient as argument 2023-07-24 09:54:11 +02:00
wait.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00