DockerCLI/cli-plugins/manager
Sebastiaan van Stijn 4cf04988ae
remove uses of golang.org/x/sys/execabs
the "golang.org/x/sys/execabs" package was introduced to address a security
issue on Windows, and changing the default behavior of os/exec was considered
a breaking change. go1.19 applied the behavior that was previously implemented
in the execabs package;

from the release notes: https://go.dev/doc/go1.19#os-exec-path

> Command and LookPath no longer allow results from a PATH search to be found
> relative to the current directory. This removes a common source of security
> problems but may also break existing programs that depend on using, say,
> exec.Command("prog") to run a binary named prog (or, on Windows, prog.exe)
> in the current directory. See the os/exec package documentation for information
> about how best to update such programs.
>
> On Windows, Command and LookPath now respect the NoDefaultCurrentDirectoryInExePath
> environment variable, making it possible to disable the default implicit search
> of “.” in PATH lookups on Windows systems.

With those changes, we no longer need to use the execabs package, and we can
switch back to os/exec.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-26 02:03:45 +02:00
..
candidate.go remove uses of golang.org/x/sys/execabs 2023-05-26 02:03:45 +02:00
candidate_test.go improve plugins listing performance 2023-04-01 16:02:34 +02:00
cobra.go load plugin command stubs when required 2023-03-28 06:16:55 +02:00
error.go Update some uses of errors.Cause() to errors.Is() 2020-05-10 19:56:35 +02:00
error_test.go cli-plugins/manager: TestPluginError: don't use yaml.Marshal 2022-11-17 13:17:51 +01:00
manager.go remove uses of golang.org/x/sys/execabs 2023-05-26 02:03:45 +02:00
manager_test.go format go with gofumpt (with -lang=1.19) 2022-09-30 19:14:36 +02:00
manager_unix.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
manager_windows.go Search Windows CLI plugins also in ProgramFiles 2019-03-20 11:45:03 -07:00
metadata.go cli-plugins/manager: fix deprecation comment of Metadata.Experimental 2023-05-09 22:17:27 +02:00
plugin.go improve plugins listing performance 2023-04-01 16:02:34 +02:00
suffix_unix.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
suffix_windows.go Check for `.exe` case insensitively 2019-01-30 13:45:26 +00:00