DockerCLI/cli
Sebastiaan van Stijn 3d8b49523d
cli/command: PromptUserForCredentials: print error on terminal restore fail
If restoring the terminal state fails, "echo" no longer works, which means
that anything the user types is no longer shown. The login itself may already
have succeeded, so we should not fail the command, but it's good to inform
the user that this happened, which may give them a clue why things no longer
work as they expect them to work.

With this patch:

    docker login -u yourname
    Password:
    Error: failed to restore terminal state to echo input: something bad happened

    Login Succeeded

We should consider printing instructions how  to restore this manually (other
than restarting the shell). e.g., 'run stty echo' when in a Linux or macOS shell,
but PowerShell and CMD.exe may need different instructions.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-19 12:49:44 +02:00
..
command cli/command: PromptUserForCredentials: print error on terminal restore fail 2024-10-19 12:49:44 +02:00
compose cli/compose: implement the ports validation method 2024-10-10 11:50:11 +03:00
config filestore: don't print warning multiple times 2024-08-14 19:48:08 +01:00
connhelper cli/connhelper: getConnectionHelper: move ssh-option funcs out of closure 2024-08-12 17:28:32 +02:00
context cli/context/store: Names(): fix panic when called with nil-interface 2024-07-17 01:25:33 +02:00
debug command: include default otel error handler for the cli 2024-04-03 12:01:28 -05:00
flags cli: move "config" flag to cli/flags/ClientOptions.InstallFlags() 2023-06-28 16:04:09 +02:00
hints login: Add message about using PATs 2023-08-03 10:35:04 +02:00
internal/oauth Merge pull request #5376 from laurazard/fix-oauth-login-timer 2024-09-03 13:14:54 +02:00
manifest linting: fmt.Sprintf can be replaced with string concatenation (perfsprint) 2024-06-10 21:19:32 +02:00
registry/client use local ConvertToHostname() implementation 2024-06-14 00:25:21 +02:00
streams cli/streams: minor refactoring and docs touch-ups 2023-04-03 11:27:26 +02:00
trust chore: remove deprecated DualStack field 2024-04-15 17:53:35 +08:00
version Move versioning variables to a separate package. 2019-01-29 11:26:40 +00:00
winresources Use goversioninfo to create Windows Version Info 2021-10-11 16:54:22 +02:00
cobra.go cli: FlagErrorFunc: don't print long usage output for invalid flags 2024-07-17 13:22:31 +02:00
cobra_test.go cli: use custom annotation for aliases 2022-06-28 17:32:09 +02:00
error.go cli: make cli.StatusError slightly prettier 2024-07-04 22:08:18 +02:00
required.go cli: rename args that collided with builtins (predeclard) 2024-08-26 13:55:28 +02:00
required_test.go cli: improve argument validation output 2024-07-05 03:35:14 +02:00