Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
The Docker CLI
5,996 Commits 11 Branches 241 Tags 240 MiB
Go 91.3%
Shell 5.8%
Go-Checksums 1.3%
Dockerfile 1.1%
Makefile 0.3%
Other 0.2%
Go to file
Ian Campbell 3af168c7df Ensure plugins can use PersistentPreRunE again. 
I got a bit carried away in d4ced2ef77 ("allow plugins to have argument
which match a top-level flag.") and broke the ability of a plugin to use the
`PersistentPreRun(E)` hook on its top-level command (by unconditionally
overwriting it) and also broke the plugin framework if a plugin's subcommand
used those hooks (because they would shadow the root one). This could result in
either `dockerCli.Client()` returning `nil` or whatever initialisation the
plugin hoped to do not occuring.

This change revert the relevant bits and reinstates the requirement that a
plugin calls `plugin.PersistentPreRunE` if it uses that hook itself.

It is at least a bit nicer now since we avoid the need for the global struct
since the interesting state is now encapsulated in `tcmd` (and the closure).

In principal this could be done even more simply (by calling `tcmd.Initialize`
statically between `tcmd.HandleGlobalFlags` and `cmd.Execute`) however this has
the downside of _always_ initialising the cli (and therefore dialing the
daemon) even for the `docker-cli-plugin-metadata` command but also for the
`help foo` and `foo --help` commands (Cobra short-circuits the hooks in this
case).

Signed-off-by: Ian Campbell <ijc@docker.com>
 		2019-03-14 14:29:09 +00:00
.github Remove myself from codeowners 😅 2019-01-10 17:32:07 +01:00
cli Use a copy of root flagset in `HandleGlobalFlags` 2019-03-13 11:28:17 +00:00
cli-plugins Ensure plugins can use PersistentPreRunE again. 2019-03-14 14:29:09 +00:00
cmd/docker allow plugins to have argument which match a top-level flag. 2019-03-13 11:28:17 +00:00
contrib/completion Update to shellcheck v0.6.0 2019-02-26 15:12:52 +01:00
dockerfiles Update to shellcheck v0.6.0 2019-02-26 15:12:52 +01:00
docs Merge pull request #1665 from jcrben/patch-1 2019-02-26 16:56:31 +01:00
e2e e2e/cli-plugins: explicitly check that PersistentPreRunE works 2019-03-14 14:20:19 +00:00
experimental Fix link to Kubernetes blog 2018-12-29 01:39:54 +01:00
internal Update containerd to 1.2.1 2019-02-02 13:30:55 +01:00
kubernetes Handle version v1alpha3 2019-01-24 20:24:45 +01:00
man Introduce functional arguments to NewDockerCli for a more stable API. 2019-01-28 14:52:58 +01:00
opts support --mount type=bind,bind-nonrecursive,... 2019-01-10 12:07:46 +09:00
scripts Update to shellcheck v0.6.0 2019-02-26 15:12:52 +01:00
service/logs Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
templates Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
types Remove unused helath check func 2018-10-02 20:52:34 +02:00
vendor Update containerd 1.2.4 and dependencies 2019-03-02 13:44:57 +01:00
.dockerignore make go build and docker build operations faster 2017-04-27 15:06:57 -07:00
.gitignore Update gitignore 2017-09-27 16:45:35 +02:00
.mailmap Update authors 2019-02-04 08:25:01 +01:00
AUTHORS Update authors 2019-02-04 08:25:01 +01:00
CONTRIBUTING.md Add Contribution guidelines 2017-07-28 11:33:19 -07:00
Jenkinsfile Add a Jenkinsfile 2017-08-16 10:46:43 -04:00
LICENSE Add project files 2017-04-17 17:49:33 -04:00
MAINTAINERS Remove outdated completion reviewers file 2018-08-01 15:08:36 +02:00
Makefile Better coverage output, removing unnecessary unit scripts. 2019-02-01 11:16:20 +01:00
NOTICE Add project files 2017-04-17 17:49:33 -04:00
README.md Add jenkins build status to readme 2017-09-15 15:08:28 +02:00
TESTING.md Update TESTING.md to replace testify by gotest.tools 2018-07-02 09:24:28 +02:00
VERSION Bump version to 19.03.0-dev 2018-09-11 13:06:49 +02:00
appveyor.yml Bump Golang 1.11.5 (CVE-2019-6486) 2019-01-24 02:50:10 +01:00
circle.yml Fix storing test results on circle ci. 2019-02-01 11:56:27 +01:00
codecov.yml Fix PR comments 2018-01-03 10:23:32 +01:00
docker.Makefile Use `$(DOCKER_RUN)` for cli plugins build. 2019-03-04 10:17:58 +00:00
gometalinter.json Add support for kubernetes in docker cli 2017-12-26 11:22:32 +01:00
poule.yml Add github templates and initial poule configuration 2017-05-09 16:57:46 +02:00
vendor.conf Update containerd 1.2.4 and dependencies 2019-03-02 13:44:57 +01:00

README.md

build status Build Status

docker/cli

This repository is the home of the cli used in the Docker CE and Docker EE products.

Development

docker/cli is developed using Docker.

Build a linux binary:

$ make -f docker.Makefile binary

Build binaries for all supported platforms:

$ make -f docker.Makefile cross

Run all linting:

$ make -f docker.Makefile lint

List all the available targets:

$ make help

In-container development environment

Start an interactive development environment:

$ make -f docker.Makefile shell

In the development environment you can run many tasks, including build binaries:

$ make binary

Legal

Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.

Use and transfer of Docker may be subject to certain restrictions by the United States and other governments.

It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.

For more information, please see https://www.bis.doc.gov

Licensing

docker/cli is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.