DockerCLI/cli/connhelper/commandconn
Sebastiaan van Stijn 4cf04988ae
remove uses of golang.org/x/sys/execabs
the "golang.org/x/sys/execabs" package was introduced to address a security
issue on Windows, and changing the default behavior of os/exec was considered
a breaking change. go1.19 applied the behavior that was previously implemented
in the execabs package;

from the release notes: https://go.dev/doc/go1.19#os-exec-path

> Command and LookPath no longer allow results from a PATH search to be found
> relative to the current directory. This removes a common source of security
> problems but may also break existing programs that depend on using, say,
> exec.Command("prog") to run a binary named prog (or, on Windows, prog.exe)
> in the current directory. See the os/exec package documentation for information
> about how best to update such programs.
>
> On Windows, Command and LookPath now respect the NoDefaultCurrentDirectoryInExePath
> environment variable, making it possible to disable the default implicit search
> of “.” in PATH lookups on Windows systems.

With those changes, we no longer need to use the execabs package, and we can
switch back to os/exec.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-26 02:03:45 +02:00
..
commandconn.go remove uses of golang.org/x/sys/execabs 2023-05-26 02:03:45 +02:00
commandconn_unix_test.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
pdeathsig_linux.go commandconn: set SysProcAttr.Setsid 2019-03-06 13:22:54 +09:00
pdeathsig_nolinux.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
session_unix.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
session_windows.go commandconn: set SysProcAttr.Setsid 2019-03-06 13:22:54 +09:00