1b400f6284
Currently `--publish-rm` only accepts `<TargetPort>` or `<TargetPort>[/Protocol]` though there are some confusions. Since `--publish-add` accepts `<PublishedPort>:<TargetPort>[/Protocol]`, some user may provide `--publish-rm 80:80`. However, there is no error checking so the incorrect provided argument is ignored silently. This fix adds the check to make sure `--publish-rm` only accepts `<TargetPort>[/Protocol]` and returns error if the format is invalid. The `--publish-rm` itself may needs to be revisited to have a better UI/UX experience, see discussions on: https://github.com/docker/swarmkit/issues/1396 https://github.com/docker/docker/issues/25200#issuecomment-236213242 https://github.com/docker/docker/issues/25338#issuecomment-240787002 This fix is short term measure so that end users are not misled by the silently ignored error of `--publish-rm`. This fix is related to (but is not a complete fix): https://github.com/docker/swarmkit/issues/1396 Signed-off-by: Yong Tang <yong.tang.github@outlook.com> |
||
|---|---|---|
| .github | ||
| cli | ||
| cmd/docker | ||
| dockerfiles | ||
| opts | ||
| script/validate | ||
| scripts/build | ||
| vendor | ||
| .dockerignore | ||
| .gitignore | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| NOTICE | ||
| README.md | ||
| circle.yml | ||
| docker.Makefile | ||
| gometalinter.json | ||
| poule.yml | ||
| vendor.conf | ||
README.md
docker/cli
This repository is the home of the cli used in the Docker CE and Docker EE products.
It's composed of 3 main folders
/cli- all the commands code./cmd/docker- the entrypoint of the cli, aka the main.
Development
Build locally
$ make build
$ make clean
You will need gox for this one:
$ make cross
If you don't have gox, you can use the "in-container" version of make cross, listed below.
Build inside container
$ make -f docker.Makefile build
$ make -f docker.Makefile clean
$ make -f docker.Makefile cross
In-container development environment
$ make -f docker.Makefile dev
Then you can use the build locally commands:
$ make build
$ make clean
Legal
Brought to you courtesy of our legal counsel. For more context, please see the NOTICE document in this repo.
Use and transfer of Docker may be subject to certain restrictions by the United States and other governments.
It is your responsibility to ensure that your use and/or transfer does not violate applicable laws.
For more information, please see https://www.bis.doc.gov
Licensing
docker/cli is licensed under the Apache License, Version 2.0. See LICENSE for the full license text.