DockerCLI/cli-plugins
Ian Campbell 0b794e0620 e2e/cli-plugins: explicitly check that PersistentPreRunE works
I regressed this in d4ced2ef77 ("allow plugins to have argument which match a
top-level flag.") by unconditionally overwriting any `PersistentRunE` that the
user may have supplied.

We need to ensure two things:

1. That the user can use `PersistentRunE` (or `PersistentRun`) for their own
   purposes.
2. That our initialisation always runs, even if the user has used
   `PersistentRun*`, since that will shadow the root.

To do this add a `PersistentRunE` to the helloworld plugin which logs (covers 1
above) and then use it when calling the `apiversion` subcommand (which covers 2
since that uses the client)

Signed-off-by: Ian Campbell <ijc@docker.com>
2019-03-14 14:20:19 +00:00
..
examples/helloworld e2e/cli-plugins: explicitly check that PersistentPreRunE works 2019-03-14 14:20:19 +00:00
manager harden config.Path() to disallow directory traversal 2019-03-07 14:40:53 +00:00
plugin allow plugins to have argument which match a top-level flag. 2019-03-13 11:28:17 +00:00