DockerCLI/cli/command/container
Sebastiaan van Stijn 91bc4ddde2
Fix: proxy-configuration being ignored on docker create
Proxies configured in config.json were only taking effect
when using `docker run`, but were being ignored when
using `docker create`.

Before this change:

    echo '{"proxies":{"default":{"httpProxy":"httpProxy","httpsProxy":"httpsProxy","noProxy":"noProxy","ftpProxy":"ftpProxy"}}}' > config.json
    docker inspect --format '{{.Config.Env}}' $(docker --config=./ create busybox)
    [PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin]

With this change applied:

    echo '{"proxies":{"default":{"httpProxy":"httpProxy","httpsProxy":"httpsProxy","noProxy":"noProxy","ftpProxy":"ftpProxy"}}}' > config.json
    docker inspect --format '{{.Config.Env}}' $(docker --config=./ create busybox)
    [NO_PROXY=noProxy no_proxy=noProxy FTP_PROXY=ftpProxy ftp_proxy=ftpProxy HTTP_PROXY=httpProxy http_proxy=httpProxy HTTPS_PROXY=httpsProxy https_proxy=httpsProxy PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin]

Reported-by: Silvano Cirujano Cuesta <Silvanoc@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-01-19 12:33:33 +01:00
..
testdata Fix warnings not being printed on "create", only on "run" 2018-12-13 14:21:34 +01:00
attach.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
attach_test.go Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
client_test.go moved integration test TestExportContainerWithOutputAndImportImage from moby/moby to docker/cli. 2018-09-18 12:30:49 -04:00
cmd.go Update gometalinter 2017-10-26 12:21:02 -04:00
commit.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
cp.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
cp_test.go Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
create.go Fix: proxy-configuration being ignored on docker create 2019-01-19 12:33:33 +01:00
create_test.go Fix: proxy-configuration being ignored on docker create 2019-01-19 12:33:33 +01:00
diff.go formatter package heavy refactoring 2018-10-23 17:05:44 +02:00
exec.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
exec_test.go Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
export.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
export_test.go moved integration test TestExportContainerWithOutputAndImportImage from moby/moby to docker/cli. 2018-09-18 12:30:49 -04:00
formatter_diff.go formatter package heavy refactoring 2018-10-23 17:05:44 +02:00
formatter_diff_test.go formatter package heavy refactoring 2018-10-23 17:05:44 +02:00
formatter_stats.go formatter package heavy refactoring 2018-10-23 17:05:44 +02:00
formatter_stats_test.go formatter package heavy refactoring 2018-10-23 17:05:44 +02:00
hijack.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
inspect.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
kill.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
list.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
list_test.go Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
logs.go don't need to type ssh password twice when docker logs with ssh 2018-10-26 08:22:49 +08:00
logs_test.go Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
opts.go support --mount type=bind,bind-nonrecursive,... 2019-01-10 12:07:46 +09:00
opts_test.go cli: add a separate --domainname flag 2018-12-08 00:03:56 +11:00
pause.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
port.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
prune.go build: add options to builder prune 2018-09-05 00:01:16 +00:00
ps_test.go Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
rename.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
restart.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
rm.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
run.go support --mount type=bind,bind-nonrecursive,... 2019-01-10 12:07:46 +09:00
run_test.go TestRunLabel: pass detach as argument 2018-12-13 13:23:30 +01:00
start.go Mark checkpoint feature as Linux-only, and homogenize error messages 2018-05-31 22:25:06 +02:00
stats.go formatter package heavy refactoring 2018-10-23 17:05:44 +02:00
stats_helpers.go formatter package heavy refactoring 2018-10-23 17:05:44 +02:00
stats_helpers_test.go Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
stats_unit_test.go Add line length linter 2017-05-08 15:57:56 -04:00
stop.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
top.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
tty.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
unpause.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
update.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
utils.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
utils_test.go Update tests to use gotest.tools 👼 2018-06-08 18:24:26 +02:00
wait.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00