package convert import ( "context" "os" "strings" "testing" "time" composetypes "github.com/docker/cli/cli/compose/types" "github.com/docker/docker/api/types" "github.com/docker/docker/api/types/container" "github.com/docker/docker/api/types/swarm" "github.com/docker/docker/client" "github.com/pkg/errors" "gotest.tools/v3/assert" is "gotest.tools/v3/assert/cmp" ) func TestConvertRestartPolicyFromNone(t *testing.T) { policy, err := convertRestartPolicy("no", nil) assert.NilError(t, err) assert.Check(t, is.DeepEqual((*swarm.RestartPolicy)(nil), policy)) } func TestConvertRestartPolicyFromUnknown(t *testing.T) { _, err := convertRestartPolicy("unknown", nil) assert.Error(t, err, "unknown restart policy: unknown") } func TestConvertRestartPolicyFromAlways(t *testing.T) { policy, err := convertRestartPolicy("always", nil) expected := &swarm.RestartPolicy{ Condition: swarm.RestartPolicyConditionAny, } assert.NilError(t, err) assert.Check(t, is.DeepEqual(expected, policy)) } func TestConvertRestartPolicyFromFailure(t *testing.T) { policy, err := convertRestartPolicy("on-failure:4", nil) attempts := uint64(4) expected := &swarm.RestartPolicy{ Condition: swarm.RestartPolicyConditionOnFailure, MaxAttempts: &attempts, } assert.NilError(t, err) assert.Check(t, is.DeepEqual(expected, policy)) } func strPtr(val string) *string { return &val } func TestConvertEnvironment(t *testing.T) { source := map[string]*string{ "foo": strPtr("bar"), "key": strPtr("value"), } env := convertEnvironment(source) assert.Check(t, is.DeepEqual([]string{"foo=bar", "key=value"}, env)) } func TestConvertEnvironmentWhenNilValueExists(t *testing.T) { source := map[string]*string{ "key": strPtr("value"), "keyWithNoValue": nil, } env := convertEnvironment(source) assert.Check(t, is.DeepEqual([]string{"key=value", "keyWithNoValue"}, env)) } func TestConvertExtraHosts(t *testing.T) { source := composetypes.HostsList{ "zulu:127.0.0.2", "alpha:127.0.0.1", "zulu:ff02::1", } assert.Check(t, is.DeepEqual([]string{"127.0.0.2 zulu", "127.0.0.1 alpha", "ff02::1 zulu"}, convertExtraHosts(source))) } func TestConvertResourcesFull(t *testing.T) { source := composetypes.Resources{ Limits: &composetypes.ResourceLimit{ NanoCPUs: "0.003", MemoryBytes: composetypes.UnitBytes(300000000), }, Reservations: &composetypes.Resource{ NanoCPUs: "0.002", MemoryBytes: composetypes.UnitBytes(200000000), }, } resources, err := convertResources(source) assert.NilError(t, err) expected := &swarm.ResourceRequirements{ Limits: &swarm.Limit{ NanoCPUs: 3000000, MemoryBytes: 300000000, }, Reservations: &swarm.Resources{ NanoCPUs: 2000000, MemoryBytes: 200000000, }, } assert.Check(t, is.DeepEqual(expected, resources)) } func TestConvertResourcesOnlyMemory(t *testing.T) { source := composetypes.Resources{ Limits: &composetypes.ResourceLimit{ MemoryBytes: composetypes.UnitBytes(300000000), }, Reservations: &composetypes.Resource{ MemoryBytes: composetypes.UnitBytes(200000000), }, } resources, err := convertResources(source) assert.NilError(t, err) expected := &swarm.ResourceRequirements{ Limits: &swarm.Limit{ MemoryBytes: 300000000, }, Reservations: &swarm.Resources{ MemoryBytes: 200000000, }, } assert.Check(t, is.DeepEqual(expected, resources)) } func TestConvertHealthcheck(t *testing.T) { retries := uint64(10) timeout := composetypes.Duration(30 * time.Second) interval := composetypes.Duration(2 * time.Millisecond) startPeriod := composetypes.Duration(time.Minute) startInterval := composetypes.Duration(1 * time.Second) source := &composetypes.HealthCheckConfig{ Test: []string{"EXEC", "touch", "/foo"}, Timeout: &timeout, Interval: &interval, Retries: &retries, StartPeriod: &startPeriod, StartInterval: &startInterval, } expected := &container.HealthConfig{ Test: source.Test, Timeout: time.Duration(timeout), Interval: time.Duration(interval), StartPeriod: time.Duration(startPeriod), StartInterval: time.Duration(startInterval), Retries: 10, } healthcheck, err := convertHealthcheck(source) assert.NilError(t, err) assert.Check(t, is.DeepEqual(expected, healthcheck)) } func TestConvertHealthcheckDisable(t *testing.T) { source := &composetypes.HealthCheckConfig{Disable: true} expected := &container.HealthConfig{ Test: []string{"NONE"}, } healthcheck, err := convertHealthcheck(source) assert.NilError(t, err) assert.Check(t, is.DeepEqual(expected, healthcheck)) } func TestConvertHealthcheckDisableWithTest(t *testing.T) { source := &composetypes.HealthCheckConfig{ Disable: true, Test: []string{"EXEC", "touch"}, } _, err := convertHealthcheck(source) assert.Error(t, err, "test and disable can't be set at the same time") } func TestConvertEndpointSpec(t *testing.T) { source := []composetypes.ServicePortConfig{ { Protocol: "udp", Target: 53, Published: 1053, Mode: "host", }, { Target: 8080, Published: 80, }, } endpoint := convertEndpointSpec("vip", source) expected := swarm.EndpointSpec{ Mode: swarm.ResolutionMode(strings.ToLower("vip")), Ports: []swarm.PortConfig{ { TargetPort: 8080, PublishedPort: 80, }, { Protocol: "udp", TargetPort: 53, PublishedPort: 1053, PublishMode: "host", }, }, } assert.Check(t, is.DeepEqual(expected, *endpoint)) } func TestConvertServiceNetworksOnlyDefault(t *testing.T) { networkConfigs := networkMap{} configs, err := convertServiceNetworks( nil, networkConfigs, NewNamespace("foo"), "service") expected := []swarm.NetworkAttachmentConfig{ { Target: "foo_default", Aliases: []string{"service"}, }, } assert.NilError(t, err) assert.Check(t, is.DeepEqual(expected, configs)) } func TestConvertServiceNetworks(t *testing.T) { networkConfigs := networkMap{ "front": composetypes.NetworkConfig{ External: composetypes.External{External: true}, Name: "fronttier", }, "back": composetypes.NetworkConfig{}, } networks := map[string]*composetypes.ServiceNetworkConfig{ "front": { Aliases: []string{"something"}, }, "back": { Aliases: []string{"other"}, }, } configs, err := convertServiceNetworks( networks, networkConfigs, NewNamespace("foo"), "service") expected := []swarm.NetworkAttachmentConfig{ { Target: "foo_back", Aliases: []string{"other", "service"}, }, { Target: "fronttier", Aliases: []string{"something", "service"}, }, } assert.NilError(t, err) assert.Check(t, is.DeepEqual(expected, configs)) } func TestConvertServiceNetworksCustomDefault(t *testing.T) { networkConfigs := networkMap{ "default": composetypes.NetworkConfig{ External: composetypes.External{External: true}, Name: "custom", }, } networks := map[string]*composetypes.ServiceNetworkConfig{} configs, err := convertServiceNetworks( networks, networkConfigs, NewNamespace("foo"), "service") expected := []swarm.NetworkAttachmentConfig{ { Target: "custom", Aliases: []string{"service"}, }, } assert.NilError(t, err) assert.Check(t, is.DeepEqual(expected, configs)) } func TestConvertDNSConfigEmpty(t *testing.T) { dnsConfig := convertDNSConfig(nil, nil) assert.Check(t, is.DeepEqual((*swarm.DNSConfig)(nil), dnsConfig)) } var ( nameservers = []string{"8.8.8.8", "9.9.9.9"} search = []string{"dc1.example.com", "dc2.example.com"} ) func TestConvertDNSConfigAll(t *testing.T) { dnsConfig := convertDNSConfig(nameservers, search) assert.Check(t, is.DeepEqual(&swarm.DNSConfig{ Nameservers: nameservers, Search: search, }, dnsConfig)) } func TestConvertDNSConfigNameservers(t *testing.T) { dnsConfig := convertDNSConfig(nameservers, nil) assert.Check(t, is.DeepEqual(&swarm.DNSConfig{ Nameservers: nameservers, Search: nil, }, dnsConfig)) } func TestConvertDNSConfigSearch(t *testing.T) { dnsConfig := convertDNSConfig(nil, search) assert.Check(t, is.DeepEqual(&swarm.DNSConfig{ Nameservers: nil, Search: search, }, dnsConfig)) } func TestConvertCredentialSpec(t *testing.T) { tests := []struct { name string in composetypes.CredentialSpecConfig out *swarm.CredentialSpec configs []*swarm.ConfigReference expectedErr string }{ { name: "empty", }, { name: "config-and-file", in: composetypes.CredentialSpecConfig{Config: "0bt9dmxjvjiqermk6xrop3ekq", File: "somefile.json"}, expectedErr: `invalid credential spec: cannot specify both "Config" and "File"`, }, { name: "config-and-registry", in: composetypes.CredentialSpecConfig{Config: "0bt9dmxjvjiqermk6xrop3ekq", Registry: "testing"}, expectedErr: `invalid credential spec: cannot specify both "Config" and "Registry"`, }, { name: "file-and-registry", in: composetypes.CredentialSpecConfig{File: "somefile.json", Registry: "testing"}, expectedErr: `invalid credential spec: cannot specify both "File" and "Registry"`, }, { name: "config-and-file-and-registry", in: composetypes.CredentialSpecConfig{Config: "0bt9dmxjvjiqermk6xrop3ekq", File: "somefile.json", Registry: "testing"}, expectedErr: `invalid credential spec: cannot specify both "Config", "File", and "Registry"`, }, { name: "missing-config-reference", in: composetypes.CredentialSpecConfig{Config: "missing"}, expectedErr: "invalid credential spec: spec specifies config missing, but no such config can be found", configs: []*swarm.ConfigReference{ { ConfigName: "someName", ConfigID: "missing", }, }, }, { name: "namespaced-config", in: composetypes.CredentialSpecConfig{Config: "name"}, configs: []*swarm.ConfigReference{ { ConfigName: "namespaced-config_name", ConfigID: "someID", }, }, out: &swarm.CredentialSpec{Config: "someID"}, }, { name: "config", in: composetypes.CredentialSpecConfig{Config: "someName"}, configs: []*swarm.ConfigReference{ { ConfigName: "someOtherName", ConfigID: "someOtherID", }, { ConfigName: "someName", ConfigID: "someID", }, }, out: &swarm.CredentialSpec{Config: "someID"}, }, { name: "file", in: composetypes.CredentialSpecConfig{File: "somefile.json"}, out: &swarm.CredentialSpec{File: "somefile.json"}, }, { name: "registry", in: composetypes.CredentialSpecConfig{Registry: "testing"}, out: &swarm.CredentialSpec{Registry: "testing"}, }, } for _, tc := range tests { tc := tc t.Run(tc.name, func(t *testing.T) { namespace := NewNamespace(tc.name) swarmSpec, err := convertCredentialSpec(namespace, tc.in, tc.configs) if tc.expectedErr != "" { assert.Error(t, err, tc.expectedErr) } else { assert.NilError(t, err) } assert.DeepEqual(t, swarmSpec, tc.out) }) } } func TestConvertUpdateConfigOrder(t *testing.T) { // test default behavior updateConfig := convertUpdateConfig(&composetypes.UpdateConfig{}) assert.Check(t, is.Equal("", updateConfig.Order)) // test start-first updateConfig = convertUpdateConfig(&composetypes.UpdateConfig{ Order: "start-first", }) assert.Check(t, is.Equal(updateConfig.Order, "start-first")) // test stop-first updateConfig = convertUpdateConfig(&composetypes.UpdateConfig{ Order: "stop-first", }) assert.Check(t, is.Equal(updateConfig.Order, "stop-first")) } func TestConvertFileObject(t *testing.T) { namespace := NewNamespace("testing") config := composetypes.FileReferenceConfig{ Source: "source", Target: "target", UID: "user", GID: "group", Mode: uint32Ptr(0o644), } swarmRef, err := convertFileObject(namespace, config, lookupConfig) assert.NilError(t, err) expected := swarmReferenceObject{ Name: "testing_source", File: swarmReferenceTarget{ Name: config.Target, UID: config.UID, GID: config.GID, Mode: os.FileMode(0o644), }, } assert.Check(t, is.DeepEqual(expected, swarmRef)) } func lookupConfig(key string) (composetypes.FileObjectConfig, error) { if key != "source" { return composetypes.FileObjectConfig{}, errors.New("bad key") } return composetypes.FileObjectConfig{}, nil } func TestConvertFileObjectDefaults(t *testing.T) { namespace := NewNamespace("testing") config := composetypes.FileReferenceConfig{Source: "source"} swarmRef, err := convertFileObject(namespace, config, lookupConfig) assert.NilError(t, err) expected := swarmReferenceObject{ Name: "testing_source", File: swarmReferenceTarget{ Name: config.Source, UID: "0", GID: "0", Mode: os.FileMode(0o444), }, } assert.Check(t, is.DeepEqual(expected, swarmRef)) } func TestServiceConvertsIsolation(t *testing.T) { src := composetypes.ServiceConfig{ Isolation: "hyperv", } result, err := Service("1.35", Namespace{name: "foo"}, src, nil, nil, nil, nil) assert.NilError(t, err) assert.Check(t, is.Equal(container.IsolationHyperV, result.TaskTemplate.ContainerSpec.Isolation)) } func TestConvertServiceSecrets(t *testing.T) { namespace := Namespace{name: "foo"} secrets := []composetypes.ServiceSecretConfig{ {Source: "foo_secret"}, {Source: "bar_secret"}, } secretSpecs := map[string]composetypes.SecretConfig{ "foo_secret": { Name: "foo_secret", }, "bar_secret": { Name: "bar_secret", }, } apiClient := &fakeClient{ secretListFunc: func(opts types.SecretListOptions) ([]swarm.Secret, error) { assert.Check(t, is.Contains(opts.Filters.Get("name"), "foo_secret")) assert.Check(t, is.Contains(opts.Filters.Get("name"), "bar_secret")) return []swarm.Secret{ {Spec: swarm.SecretSpec{Annotations: swarm.Annotations{Name: "foo_secret"}}}, {Spec: swarm.SecretSpec{Annotations: swarm.Annotations{Name: "bar_secret"}}}, }, nil }, } ctx := context.Background() refs, err := convertServiceSecrets(ctx, apiClient, namespace, secrets, secretSpecs) assert.NilError(t, err) expected := []*swarm.SecretReference{ { SecretName: "bar_secret", File: &swarm.SecretReferenceFileTarget{ Name: "bar_secret", UID: "0", GID: "0", Mode: 0o444, }, }, { SecretName: "foo_secret", File: &swarm.SecretReferenceFileTarget{ Name: "foo_secret", UID: "0", GID: "0", Mode: 0o444, }, }, } assert.DeepEqual(t, expected, refs) } func TestConvertServiceConfigs(t *testing.T) { namespace := Namespace{name: "foo"} service := composetypes.ServiceConfig{ Configs: []composetypes.ServiceConfigObjConfig{ {Source: "foo_config"}, {Source: "bar_config"}, }, CredentialSpec: composetypes.CredentialSpecConfig{ Config: "baz_config", }, } configSpecs := map[string]composetypes.ConfigObjConfig{ "foo_config": { Name: "foo_config", }, "bar_config": { Name: "bar_config", }, "baz_config": { Name: "baz_config", }, } apiClient := &fakeClient{ configListFunc: func(opts types.ConfigListOptions) ([]swarm.Config, error) { assert.Check(t, is.Contains(opts.Filters.Get("name"), "foo_config")) assert.Check(t, is.Contains(opts.Filters.Get("name"), "bar_config")) assert.Check(t, is.Contains(opts.Filters.Get("name"), "baz_config")) return []swarm.Config{ {Spec: swarm.ConfigSpec{Annotations: swarm.Annotations{Name: "foo_config"}}}, {Spec: swarm.ConfigSpec{Annotations: swarm.Annotations{Name: "bar_config"}}}, {Spec: swarm.ConfigSpec{Annotations: swarm.Annotations{Name: "baz_config"}}}, }, nil }, } ctx := context.Background() refs, err := convertServiceConfigObjs(ctx, apiClient, namespace, service, configSpecs) assert.NilError(t, err) expected := []*swarm.ConfigReference{ { ConfigName: "bar_config", File: &swarm.ConfigReferenceFileTarget{ Name: "bar_config", UID: "0", GID: "0", Mode: 0o444, }, }, { ConfigName: "baz_config", Runtime: &swarm.ConfigReferenceRuntimeTarget{}, }, { ConfigName: "foo_config", File: &swarm.ConfigReferenceFileTarget{ Name: "foo_config", UID: "0", GID: "0", Mode: 0o444, }, }, } assert.DeepEqual(t, expected, refs) } type fakeClient struct { client.Client secretListFunc func(types.SecretListOptions) ([]swarm.Secret, error) configListFunc func(types.ConfigListOptions) ([]swarm.Config, error) } func (c *fakeClient) SecretList(_ context.Context, options types.SecretListOptions) ([]swarm.Secret, error) { if c.secretListFunc != nil { return c.secretListFunc(options) } return []swarm.Secret{}, nil } func (c *fakeClient) ConfigList(_ context.Context, options types.ConfigListOptions) ([]swarm.Config, error) { if c.configListFunc != nil { return c.configListFunc(options) } return []swarm.Config{}, nil } func TestConvertUpdateConfigParallelism(t *testing.T) { parallel := uint64(4) // test default behavior updateConfig := convertUpdateConfig(&composetypes.UpdateConfig{}) assert.Check(t, is.Equal(uint64(1), updateConfig.Parallelism)) // Non default value updateConfig = convertUpdateConfig(&composetypes.UpdateConfig{ Parallelism: ¶llel, }) assert.Check(t, is.Equal(parallel, updateConfig.Parallelism)) } func TestConvertServiceCapAddAndCapDrop(t *testing.T) { tests := []struct { title string in, out composetypes.ServiceConfig }{ { title: "default behavior", }, { title: "some values", in: composetypes.ServiceConfig{ CapAdd: []string{"SYS_NICE", "CAP_NET_ADMIN"}, CapDrop: []string{"CHOWN", "CAP_NET_ADMIN", "DAC_OVERRIDE", "CAP_FSETID", "CAP_FOWNER"}, }, out: composetypes.ServiceConfig{ CapAdd: []string{"CAP_NET_ADMIN", "CAP_SYS_NICE"}, CapDrop: []string{"CAP_CHOWN", "CAP_DAC_OVERRIDE", "CAP_FOWNER", "CAP_FSETID"}, }, }, { title: "adding ALL capabilities", in: composetypes.ServiceConfig{ CapAdd: []string{"ALL", "CAP_NET_ADMIN"}, CapDrop: []string{"CHOWN", "CAP_NET_ADMIN", "DAC_OVERRIDE", "CAP_FSETID", "CAP_FOWNER"}, }, out: composetypes.ServiceConfig{ CapAdd: []string{"ALL"}, CapDrop: []string{"CAP_CHOWN", "CAP_DAC_OVERRIDE", "CAP_FOWNER", "CAP_FSETID", "CAP_NET_ADMIN"}, }, }, { title: "dropping ALL capabilities", in: composetypes.ServiceConfig{ CapAdd: []string{"CHOWN", "CAP_NET_ADMIN", "DAC_OVERRIDE", "CAP_FSETID", "CAP_FOWNER"}, CapDrop: []string{"ALL", "CAP_NET_ADMIN", "CAP_FOO"}, }, out: composetypes.ServiceConfig{ CapAdd: []string{"CAP_CHOWN", "CAP_DAC_OVERRIDE", "CAP_FOWNER", "CAP_FSETID", "CAP_NET_ADMIN"}, CapDrop: []string{"ALL"}, }, }, } for _, tc := range tests { tc := tc t.Run(tc.title, func(t *testing.T) { result, err := Service("1.41", Namespace{name: "foo"}, tc.in, nil, nil, nil, nil) assert.NilError(t, err) assert.Check(t, is.DeepEqual(result.TaskTemplate.ContainerSpec.CapabilityAdd, tc.out.CapAdd)) assert.Check(t, is.DeepEqual(result.TaskTemplate.ContainerSpec.CapabilityDrop, tc.out.CapDrop)) }) } }