Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
308 Commits 11 Branches 242 Tags 241 MiB
Commit Graph

5 Commits

Author SHA1 Message Date
Boaz Shuster c1da6dc7ac Add unit tests to cli/command/formatter/stats.go 
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
 2016-10-27 18:00:38 +03:00
John Howard dff7842790 Windows: Fix stats CLI 
Signed-off-by: John Howard <jhoward@microsoft.com>
 2016-10-25 19:57:47 -07:00
Amit Krishnan 15bbb61711 Correct go-units import in cli/command/formatter/stats.go 
from src/github.com/docker/go-units -> github.com/docker/go-units

Signed-off-by: Amit Krishnan <krish.amit@gmail.com>
 2016-10-24 15:06:58 -07:00
Boaz Shuster 3bc50c45ba Hide the mutex in formatter.ContainerStats 
The formatter.ContainerStats struct exposes its Mutex.
This is a bad design and should be fixed.

To fix that, I separated the statistics
attributes from ContainerStats to StatsEntry and
hid the mutex. Notice that the mutex protects both
the `err` field and the statistics attributes.

Then, implemented SetStatistics, SetError, GetStatistics
and GetError to avoid races.

Moreover, to make this less granular, I decided to
replace the read-write mutex with the regular mutex and
to pass a StatsEntry slice to formatter.ContainerStatsWrite

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
 2016-10-10 21:52:53 +03:00
Boaz Shuster a4f3442403 Add the format switch to the stats command 
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
 2016-09-18 14:16:13 +03:00