CrazyMax
e14f5fc1a7
revert "improve plugins discovery performance"
...
This reverts commit 62f2358b99
.
Spawning a goroutine for each iteration in the loop when listing
plugins is racy unfortunately. `plugins` slice is protected with
a mutex so not sure why it fails.
I tried using a channel to collect the plugins instead of a slice
to guarantee that they will be appended to the list in the order
they are processed but no dice.
I also tried without errgroup package and simply use sync.WaitGroup
but same. I have also created an extra channel to receive errors
from the goroutines but racy too.
I think the change in this function is not related to the race
condition but newPlugin is. So revert in the meantime :(
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-03-31 16:20:42 +02:00
Sebastiaan van Stijn
bfa79fd75a
vendor: github.com/docker/docker master (v24.0.0-dev)
...
- updates VolumeList() calls for docker/docker master
- update fakeClient signature, and suppress err output in tests
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:28 +02:00
Sebastiaan van Stijn
e86d2f4113
vendor: github.com/moby/buildkit v0.11.5
...
full diff: https://github.com/moby/buildkit/compare/v0.11.4...v0.11.5
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:28 +02:00
Sebastiaan van Stijn
cd9c6a4c02
vendor: github.com/klauspost/compress v1.16.3
...
full diff: https://github.com/klauspost/compress/compare/v1.15.12...v1.16.3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:28 +02:00
Sebastiaan van Stijn
5843fbd5f5
vendor: github.com/imdario/mergo v0.3.13
...
full diff: https://github.com/imdario/mergo/compare/v0.3.12...v0.3.13
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:27 +02:00
Sebastiaan van Stijn
149d289638
vendor: golang.org/x/sys v0.6.0
...
full diff: https://github.com/golang/sys/compare/v0.5.0..v0.6.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:27 +02:00
Sebastiaan van Stijn
6dca335d05
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230315203717-e28e8ba9bc83
...
full diff: a745a8755c...e28e8ba9bc
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:27 +02:00
Sebastiaan van Stijn
4389c966f8
vendor: github.com/opencontainers/runc v1.1.5
...
full diff: https://github.com/opencontainers/runc/compare/v1.1.3...v1.1.5
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:26 +02:00
Sebastiaan van Stijn
a9fff59809
Merge pull request #4129 from crazy-max/fix-perf-reg-2
...
improve and load plugin command stubs when required
2023-03-30 17:05:16 +02:00
Sebastiaan van Stijn
a39958846d
vendor: github.com/docker/docker v23.0.2
...
- migrate away from things deprecated in Go 1.20 (removes use of archive/tar.TypeRegA)
full diff: https://github.com/docker/docker/compare/v23.0.1...v23.0.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-28 18:35:05 +02:00
CrazyMax
62f2358b99
improve plugins discovery performance
...
We are currently loading plugin commands stubs for every
command invocation to add support for Cobra v2 completion.
This cause a significant performance hit if there is a
lot of plugins in the user space (7 atm in Docker Desktop):
`docker --version` takes in current 23.0.1 ~93ms
Instead of removing completion for plugins to fix the
regression, we can slightly improve plugins discovery by
spawning a goroutine for each iteration in the loop when
listing plugins:
`docker --version` now takes ~38ms
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-03-28 06:16:55 +02:00
Sebastiaan van Stijn
e60c748c14
vendor: github.com/moby/buildkit v0.11.4
...
full diff: https://github.com/moby/buildkit/compare/v0.10.6..v0.11.4
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:42:09 +01:00
Sebastiaan van Stijn
6c8cc226f0
vendor: google.golang.org/grpc v1.50.1
...
full diff: https://github.com/grpc/grpc-go/compare/v1.48.0...v1.50.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:42:09 +01:00
Sebastiaan van Stijn
d213548bd0
vendor: golang.org/x/net v0.7.0
...
full diff: https://github.com/golang/net/compare/v0.5.0...v0.7.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:42:00 +01:00
Sebastiaan van Stijn
3a0d492d1c
vendor: golang.org/x/term v0.5.0
...
full diff: https://github.com/golang/term/compare/v0.4.0...v0.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:38:48 +01:00
Sebastiaan van Stijn
f40bbf4f7f
vendor: golang.org/x/time v0.3.0
...
full diff: https://github.com/golang/time/compare/v0.1.0...v0.3.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:35:57 +01:00
Sebastiaan van Stijn
a85537d346
vendor: golang.org/x/text v0.7.0
...
full diff: https://github.com/golang/text/compare/v0.6.0...v0.7.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:34:10 +01:00
Sebastiaan van Stijn
3e9c6e84ce
vendor: golang.org/x/sys v0.5.0
...
full diff: https://github.com/golang/sys/compare/v0.4.0...v0.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:32:29 +01:00
Sebastiaan van Stijn
ca8783ef43
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230309194213-a745a8755ce3
...
full diff: 904c221ac2...a745a8755c
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:03:04 +01:00
Sebastiaan van Stijn
33806760a4
vendor: github.com/containerd/containerd v1.6.19
...
full diff: https://github.com/containerd/containerd/compare/v1.6.16...v1.6.19
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:03:04 +01:00
Sebastiaan van Stijn
71e495aa54
vendor: github.com/docker/docker v23.0.1
...
full diff: https://github.com/docker/docker/compare/v23.0.0...v23.0.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:02:58 +01:00
Sebastiaan van Stijn
bbebebaedf
vendor: github.com/docker/docker v23.0.0
...
- client: improve error messaging on crash
full diff: https://github.com/docker/docker/compare/v23.0.0-rc.3...v23.0.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-02-04 13:30:07 +01:00
Sebastiaan van Stijn
5195db1ff5
vendor: github.com/containerd/containerd v1.6.16
...
no changes in vendored code
full diff: https://github.com/containerd/containerd/compare/v1.6.15...v1.6.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-02-04 13:28:11 +01:00
Sebastiaan van Stijn
8672540f8c
vendor: github.com/docker/docker v23.0.0-rc.3
...
full diff: https://github.com/docker/docker/compare/v23.0.0-rc.2...v23.0.0-rc.3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-23 11:59:16 +01:00
Sebastiaan van Stijn
c4fff9da13
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230119195359-904c221ac281
...
full diff: 0da442b278...904c221ac2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-23 11:59:16 +01:00
Sebastiaan van Stijn
526e5e7c95
vendor: golang.org/x/net v0.5.0
...
full diff: https://github.com/golang/net/compare/v0.4.0...v0.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-23 11:59:15 +01:00
Sebastiaan van Stijn
d7f21ea9c8
vendor: golang.org/x/term v0.4.0
...
full diff: https://github.com/golang/term/compare/v0.3.0...v0.4.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-23 11:59:01 +01:00
Sebastiaan van Stijn
ae43eb0e04
vendor: golang.org/x/text v0.6.0
...
no changes in vendored code
full diff: https://github.com/golang/text/compare/v0.5.0...v0.6.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-23 11:48:03 +01:00
Sebastiaan van Stijn
caf8b152c6
vendor: golang.org/x/sys v0.4.0
...
full diff: https://github.com/golang/sys/compare/v0.3.0...v0.4.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-23 11:45:55 +01:00
Sebastiaan van Stijn
c453cc6873
vendor: github.com/docker/docker v23.0.0-rc.2
...
full diff: https://github.com/docker/docker/compare/v23.0.0-rc.1...v23.0.0-rc.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-12 13:45:27 +01:00
Sebastiaan van Stijn
0d16330dd2
vendor: github.com/containerd/containerd v1.6.15
...
no changes to vendored code
full diff: https://github.com/conainerd/containerd/compare/v1.6.14...v1.6.15
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-12 13:43:35 +01:00
Sebastiaan van Stijn
112f4ec38d
Merge pull request #3934 from thaJeztah/update_engine
...
vendor: github.com/docker/docker v23.0.0-rc.1 (use tag)
2022-12-27 16:04:28 +01:00
Sebastiaan van Stijn
6fe14e61f2
vendor: github.com/docker/docker v23.0.0-rc.1 (use tag)
...
no changes in code, as this is the same commit, but now using the tag
full diff: https://github.com/docker/docker/compare/cba986b34090...v23.0.0-rc.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-27 13:48:20 +01:00
Sebastiaan van Stijn
c5982f373c
vendor: github.com/inconshreveable/mousetrap v1.1.0
...
removes compatibility code for go1.3 and older;
https://github.com/inconshreveable/mousetrap/compare/v1.0.1...v1.1.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-27 13:45:16 +01:00
Sebastiaan van Stijn
cc859412c8
vendor: github.com/docker/docker v23.0.0-beta.1.0.20221221173850-cba986b34090
...
full diff: https://github.com/docker/docker/compare/v23.0.0-beta.1...cba986b34090
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 23:06:38 +01:00
Sebastiaan van Stijn
70d24e854b
vendor: github.com/moby/swarmkit/v2 v2.0.0-20221215132206-0da442b2780f
...
full diff: b17f02f0a0...0da442b278
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 23:04:12 +01:00
Sebastiaan van Stijn
bab905a442
vendor: golang.org/x/crypto v0.2.0
...
full diff: https://github.com/golang/crypto/compare/v0.1.0...v0.2.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 23:02:17 +01:00
Sebastiaan van Stijn
929f23fcf9
vendor: golang.org/x/net v0.4.0
...
full diff: https://github.com/golang/net/compare/v0.1.0...v0.4.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 23:00:49 +01:00
Sebastiaan van Stijn
2df9ff91e1
vendor: golang.org/x/term v0.3.0
...
full diff: https://github.com/golang/term/compare/v0.1.0...v0.3.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 22:59:45 +01:00
Sebastiaan van Stijn
1b75c7c52a
vendor: golang.org/x/text v0.5.0
...
full diff: https://github.com/golang/text/compare/v0.4.0...v0.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 22:53:24 +01:00
Sebastiaan van Stijn
e3e0b7a6c8
vendor: golang.org/x/sys v0.3.0
...
full diff: https://github.com/golang/sys/compare/v0.2.0...v0.3.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 22:51:19 +01:00
Sebastiaan van Stijn
6f2f021b6d
vendor: github.com/prometheus/client_golang v1.14.0
...
full diff: https://github.com/prometheus/client_golang/compare/v1.13.0...v1.14.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 22:48:55 +01:00
Sebastiaan van Stijn
dedbcec469
vendor: github.com/opencontainers/runc v1.1.3
...
full diff: https://github.com/opencontainers/runc/compare/v1.1.2...v1.1.3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 22:46:56 +01:00
Sebastiaan van Stijn
cd2098c461
vendor: github.com/klauspost/compress v1.15.12
...
full diff: https://github.com/klauspost/compress/compare/v1.15.9...v1.15.12
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 22:45:42 +01:00
Sebastiaan van Stijn
d7869beade
vendor: github.com/containerd/containerd v1.6.14
...
full diff: https://github.com/containerd/containerd/compare/v1.6.10...v1.6.14
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-22 22:43:11 +01:00
Sebastiaan van Stijn
0f6023a9c3
vendor: github.com/docker/docker v23.0.0-beta.1
...
Allows us to remove the replace rule, although we probably need to
add it back if we want to update to a newer version from the release
branch (as go mod doesn't support release branches :(( ).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-07 23:14:19 +01:00
Sebastiaan van Stijn
60b09ea7fb
vendor: docker/docker v20.10.3-0.20221201203946-b21e8f72f254 (v23.0.0-dev)
...
full diff: bb2eab21c6...b21e8f72f2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-01 22:09:01 +01:00
Sebastiaan van Stijn
25c06c755c
vendor: docker/docker v20.10.3-0.20221201081640-bb2eab21c6db (v23.0.0-dev)
...
full diff: a913b5ad7e...bb2eab21c6
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-01 09:48:58 +01:00
Sebastiaan van Stijn
536aef9c63
vendor: update github.com/moby/term to fix interrupt handling
...
On termios platforms, interrupt signals are not generated in raw mode terminals
as the ISIG setting is not enabled. Remove interrupt handler as it does nothing
for raw mode and prevents other uses of INT signal with this library.
This code seems to go back all the way to moby/moby#214 where signal handling was
improved for monolithic docker repository. Raw mode -ISIG got reintroduced in
https://github.com/moby/moby/commit/3f63b878076 , but the INT handler was left
behind.
full diff: abb19827d3...c43b287e0e
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-11-28 10:28:21 +01:00
Sebastiaan van Stijn
a52d922f80
vendor: golang_protobuf_extensions v1.0.4 - prevent incompatible versions
...
This module made a whoopsie, and updated to `google.golang.org/protobuf`
in a patch release, but `google.golang.org/protobuf` is not backward
compatible with `github.com/golang/protobuf`.
Updating the minimum version to v1.0.4 which corrects this, to prevent
users of containerd as a module from accidentally pulling in the wrong
version:
- v1.0.3 switched to use `google.golang.org/protobuf`; https://github.com/matttproud/golang_protobuf_extensions/compare/v1.0.2..v1.0.3
- This was reverted in v1.0.4 (which is the same as v1.0.2); https://github.com/matttproud/golang_protobuf_extensions/compare/v1.0.3..v1.0.4
- And a `v2` was created instead; https://github.com/matttproud/golang_protobuf_extensions/releases/tag/v2.0.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-11-25 15:24:05 +01:00