5 Commits

Author	SHA1	Message	Date
Laura Brehm	2d5f041bde	commandconn: return original error while closing ... Changes the `Read` and `Write` error handling logic to return the original error while closing the connection. We still skip calling `handleEOF` if already closing the connection. Fixes the flaky `TestCloseWhileWriting` and `TestCloseWhileReading` tests. Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Laura Brehm <laurabrehm@hey.com> (cherry picked from commit d5f564adaa) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2023-06-30 19:23:36 +02:00
Laura Brehm	520e3600ee	commandconn: don't return error if command closed successfully ... --- commandconn: fix race on `Close()` During normal operation, if a `Read()` or `Write()` call results in an EOF, we call `onEOF()` to handle the terminating command, and store it's exit value. However, if a Read/Write call was blocked while `Close()` is called the in/out pipes are immediately closed which causes an EOF to be returned. Here, we shouldn't call `onEOF()`, since the reason why we got an EOF is because we're already terminating the connection. This also prevents a race between two calls to the commands `Wait()`, in the `Close()` call and `onEOF()` --- Add CLI init timeout to SSH connections --- connhelper: add 30s ssh default dialer timeout (same as non-ssh dialer) Signed-off-by: Laura Brehm <laurabrehm@hey.com> (cherry picked from commit a5ebe2282a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2023-06-30 19:23:12 +02:00
Sebastiaan van Stijn	a0f0578299	gofmt with go1.17 ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2022-03-26 20:21:00 +01:00
Sebastiaan van Stijn	2c0e93063b	bump gotest.tools v3.0.1 for compatibility with Go 1.14 ... full diff: https://github.com/gotestyourself/gotest.tools/compare/v2.3.0...v3.0.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2020-02-23 00:28:55 +01:00
Akihiro Suda	dbe7afbd04	connhelper: export functions for other projects ... Exposed functions are planned to be used by `buildctl`: https://github.com/moby/buildkit/issues/769 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>	2019-03-02 21:11:49 +09:00

Renamed from cli/connhelper/connhelper_unix_test.go (Browse further)