d2b87a0a3b
Merge pull request #5553 from thaJeztah/login_idempotent
...
cli/config/credentials: skip saving config-file if credentials didn't change
2024-10-21 15:23:26 +02:00
24ee5f228a
Merge pull request #5551 from thaJeztah/fix_ConfigureAuth_deprecation
...
cli/command: ConfigureAuth: fix deprecation comment
2024-10-21 14:28:43 +02:00
8b6133a2b7
Merge pull request #5544 from thaJeztah/bump_engine_28
...
vendor: github.com/docker/docker 36a3bd090489 (master, v28.0-dev)
2024-10-21 13:28:35 +02:00
d3f6867e4d
cli/config/credentials: skip saving config-file if credentials didn't change
...
Before this change, the config-file was always updated, even if there
were no changes to save. This could cause issues when the config-file
already had credentials set and was read-only for the current user.
For example, on NixOS, this poses a problem because `config.json` is a
symlink to a write-protected file;
$ readlink ~/.docker/config.json
/home/username/.config/sops-nix/secrets/ghcr_auth
$ readlink -f ~/.docker/config.json
/run/user/1000/secrets.d/28/ghcr_auth
Which causes `docker login` to fail, even if no changes were to be made;
Error saving credentials: rename /home/derek/.docker/config.json2180380217 /home/username/.config/sops-nix/secrets/ghcr_auth: invalid cross-device link
This patch updates the code to only update the config file if changes
were detected. It there's nothing to save, it skips updating the file,
as well as skips printing the warning about credentials being stored
insecurely.
With this patch applied:
$ docker login -u yourname
Password:
WARNING! Your credentials are stored unencrypted in '/root/.docker/config.json'.
Configure a credential helper to remove this warning. See
https://docs.docker.com/go/credential-store/
Login Succeeded
$ docker login -u yourname
Password:
Login Succeeded
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-21 00:19:52 +02:00
062eecf14a
Merge pull request #5554 from albers/fix-completion-events-filter-daemon
...
Fix bash completion for `events --filter daemon=`
2024-10-19 17:55:12 +02:00
3f7b156c85
Fix bash completion for `events --filter daemon=`
...
Signed-off-by: Harald Albers <github@albersweb.de>
2024-10-19 15:40:07 +00:00
54e3685bcd
cli/command: ConfigureAuth: fix deprecation comment
...
Deprecation comments must have an empty line before them, otherwise tools
and linters may not recognise them. While fixing this, also updated the
reference to PromptUserForCredentials to be a docs-link to make it clickable.
Updates 6e4818e7d6
2024-10-19 13:05:31 +02:00
9b525bc9d1
vendor: github.com/docker/docker 36a3bd090489 (master, v28.0-dev)
...
full diff: 164cae56ed...36a3bd0904
2024-10-18 17:48:05 +02:00
8a7c5ae68f
Merge pull request #5542 from thaJeztah/base_completion_tests
...
cmd/docker: add tests for flag-completions, and refactor
2024-10-18 12:07:02 +02:00
da9e984231
Merge pull request #5541 from thaJeztah/template_coverage
...
templates: add test for HeaderFunctions
2024-10-18 11:42:00 +02:00
670f81803f
cmd/docker: add tests for flag-completions, and refactor
...
Remove the registerCompletionFuncForGlobalFlags for now, as
the error it returned was ignored, so it didn't add much
benefit, other than abstracting things.
Split the underlying completion-functions to separate
functions, and add some basic tests for them.
Remove the completions helper, as it now didn't add much,
and it saved having the dependency on the package.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-18 11:23:55 +02:00
38653277af
Merge pull request #5539 from thaJeztah/bump_swarmkit
...
vendor: github.com/moby/swarmkit/v2 v2.0.0-20241017191044-e8ecf83ee08e
2024-10-18 10:44:41 +02:00
12dcc6e25c
templates: add test for HeaderFunctions
...
Before:
go test -test.coverprofile -
PASS
coverage: 65.2% of statements
ok github.com/docker/cli/templates 0.607s
After:
go test -test.coverprofile -
PASS
coverage: 95.7% of statements
ok github.com/docker/cli/templates 0.259s
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-18 10:07:33 +02:00
cbbb917323
vendor: github.com/moby/swarmkit/v2 v2.0.0-20241017191044-e8ecf83ee08e
...
- add Unwrap error to custom error types
- removes dependency on github.com/rexray/gocsi
- fix CSI plugin load issue
full diff: ea1a7cec35...e8ecf83ee0
2024-10-17 23:01:19 +02:00
3590f946a3
Merge pull request #5535 from dvdksn/fix-image-tag-spec
...
docs: update prose about image tag/name format
2024-10-17 12:46:46 +02:00
2c6b80491b
docs: update prose about image tag/name format
...
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
2024-10-17 12:36:32 +02:00
09e16fc9c6
Merge pull request #5537 from dvdksn/correct_events_limit
...
docs: corrected the max events returned
2024-10-17 11:26:09 +02:00
dba4b15d6b
Merge pull request #5534 from thaJeztah/container_testfixes
2024-10-16 22:08:22 +01:00
50ef0c58c2
docs: corrected the max events returned
...
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
2024-10-16 12:21:51 +02:00
35d7b1a7a6
cli/command/container: TestWaitExitOrRemoved use subtests
...
=== RUN TestWaitExitOrRemoved
=== RUN TestWaitExitOrRemoved/normal-container
=== RUN TestWaitExitOrRemoved/give-me-exit-code-42
=== RUN TestWaitExitOrRemoved/i-want-a-wait-error
time="2024-10-13T18:48:14+02:00" level=error msg="Error waiting for container: removal failed"
=== RUN TestWaitExitOrRemoved/non-existent-container-id
time="2024-10-13T18:48:14+02:00" level=error msg="error waiting for container: no such container: non-existent-container-id"
--- PASS: TestWaitExitOrRemoved (0.00s)
--- PASS: TestWaitExitOrRemoved/normal-container (0.00s)
--- PASS: TestWaitExitOrRemoved/give-me-exit-code-42 (0.00s)
--- PASS: TestWaitExitOrRemoved/i-want-a-wait-error (0.00s)
--- PASS: TestWaitExitOrRemoved/non-existent-container-id (0.00s)
PASS
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-16 12:03:17 +02:00
3b38dc67be
cli/command/container: set empty args in tests and discard output
...
Prevent some tests from failing when running from a pre-compiled
testbinary, and discard output to make the output less noisy.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-16 12:01:25 +02:00
31eeed7ca4
Merge pull request #5533 from thaJeztah/completions_coverage
...
cli/command/completion: add more unit-tests
2024-10-14 17:38:02 +02:00
089448ba6d
Merge pull request #5532 from thaJeztah/update_badges
...
README: update pkg.go.dev badge, add OpenSSF scorecard
2024-10-14 17:18:23 +02:00
6ed137f7dd
Merge pull request #5529 from thaJeztah/bump_deps
...
vendor assorted dependencies in preparation of engine update
2024-10-14 13:29:16 +02:00
e1c472a436
completion: add test for VolumeNames
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 19:08:56 +02:00
302d73f990
completion: add test for NetworkNames
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 19:08:52 +02:00
ab418a38d8
completion: add test for ImageNames
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 19:08:26 +02:00
f3b4094eb0
completion: add test for ContainerNames
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 19:07:52 +02:00
be197da6b8
completion: add test for NoComplete
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 17:54:40 +02:00
51713196c9
completion: add test for FromList
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 17:53:19 +02:00
a5ca5b33f1
completion: add test for FileNames
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 17:52:50 +02:00
8f2e5662e7
completion: add test for EnvVarNames
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 17:48:49 +02:00
b8cddc63ad
completion: ContainerNames: don't panic on nil filter
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-13 17:47:07 +02:00
a58faf7971
README: update pkg.go.dev badge, add OpenSSF scorecard
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 22:12:38 +02:00
b6d27ff60e
vendor: google.golang.org/grpc v1.66.2
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 21:52:41 +02:00
200225f530
vendor: google.golang.org/protobuf v1.34.1
...
full diff: https://github.com/protocolbuffers/protobuf-go/compare/v1.33.0...v1.34.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 21:49:59 +02:00
9599251d07
vendor: github.com/cespare/xxhash/v2 v2.3.0
...
full diff: https://github.com/cespare/xxhash/compare/v2.2.0...v2.3.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 21:48:45 +02:00
ea8aa2a419
vendor: golang.org/x/net v0.29.0
...
no changes in vendored code
full diff: https://github.com/golang/net/compare/v0.28.0...v0.29.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 21:47:34 +02:00
61867feecf
vendor: golang.org/x/crypto v0.27.0
...
no changes in vendored code
full diff: https://github.com/golang/crypto/compare/v0.26.0...v0.27.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 21:46:59 +02:00
843ae6d7e2
vendor: golang.org/x/term v0.24.0
...
full diff: https://github.com/golang/term/compare/v0.23.0...v0.24.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 21:46:04 +02:00
bea4ee6588
vendor: golang.org/x/text v0.18.0
...
no changes in vendored code
full diff: https://github.com/golang/text/compare/v0.17.0...v0.18.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 21:43:36 +02:00
a88ee33f71
vendor: golang.org/x/sys v0.25.0
...
full diff: https://github.com/golang/sys/compare/v0.24.0...v0.25.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-12 21:42:42 +02:00
21eea1e003
Merge pull request #5527 from albers/completion-container-rm
...
Improve completion of containers for `docker rm`
2024-10-11 22:35:25 +02:00
147630a309
Only complete removable containers if --force is not given
...
Signed-off-by: Harald Albers <github@albersweb.de>
2024-10-10 21:34:38 +00:00
88f1e99e8e
Merge pull request #5507 from p-rogalski/link-supported-go-duration-strings
...
docs: Link supported Go duration strings
2024-10-10 18:04:19 +02:00
f483aacd6b
Merge pull request #5331 from vvoland/c8d-saveload-platform
...
c8d: Add `--platform` flag to history, save and load
2024-10-10 17:33:08 +02:00
d085e2445c
image/history: Add `--platform` flag
...
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-10 17:00:43 +02:00
b0bb4ba7f2
image/load: Add `--platform`
...
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-10 16:35:07 +02:00
a20eb45b26
image/save: Add `--platform`
...
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-10 16:35:03 +02:00
6a78e9231a
Merge pull request #5524 from Stavrospanakakis/compose-ports-validation
...
cli/compose: implement the ports validation method
2024-10-10 14:34:09 +02:00
Paweł Gronowski
Sebastiaan van Stijn
Sebastiaan van Stijn
Harald Albers
David Karlsson
Laura Brehm