74973adaa5
cli/command: embed "Streams" interface in "Cli"
...
The DockerCLI interface was repeating the Streams interface. Embed
the interface to make it more transparent that they're the same.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-15 13:46:43 +01:00
fc6be6ad30
cli: pass dockerCLI's in/out/err to cobra cmds
...
Both the DockerCLI and Cobra Commands provide accessors for Input, Output,
and Error streams (usually STDIN, STDOUT, STDERR). While we were already
passing DockerCLI's Output to Cobra, we were not doing so for the other
streams (and were passing none for plugin commands), potentially resulting
in DockerCLI output/input to mean something else than a Cobra Command's
intput/output/error.
This patch sets them to the same streams when constructing the Cobra
command.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-15 13:44:33 +01:00
d347678cde
README: fix badges
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-01-13 19:18:26 +01:00
d0a4b6f497
Merge pull request #3966 from crazy-max/fix-docs-anchore
...
docs: fix duplicated format anchor in plugin_ls
2023-01-13 18:15:32 +01:00
e04f3dd0df
docs: fix duplicated format anchor in plugin_ls
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-01-13 16:22:26 +01:00
1af9f22c7e
Merge pull request #2998 from pseyfert/completion/zsh/volume
...
[completion/zsh] add volume completion
2023-01-13 12:22:14 +01:00
2753057c40
contrib/completion: bash `nounset` mode fixes
...
Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
2023-01-12 17:27:24 +02:00
f1f12a3332
Merge pull request #3963 from thaJeztah/engine_23.0_rc2
...
vendor: github.com/docker/docker v23.0.0-rc.2
2023-01-12 14:08:40 +01:00
c453cc6873
vendor: github.com/docker/docker v23.0.0-rc.2
...
full diff: https://github.com/docker/docker/compare/v23.0.0-rc.1...v23.0.0-rc.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-12 13:45:27 +01:00
0d16330dd2
vendor: github.com/containerd/containerd v1.6.15
...
no changes to vendored code
full diff: https://github.com/conainerd/containerd/compare/v1.6.14...v1.6.15
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-12 13:43:35 +01:00
257ff41304
Merge pull request #3958 from thaJeztah/bump_go_1.19.5
...
update to go1.19.5
2023-01-11 14:45:52 +01:00
b9e1ad3d19
update to go1.19.5
...
go1.19.5 (released 2023-01-10) includes fixes to the compiler, the linker,
and the crypto/x509, net/http, sync/atomic, and syscall packages. See the
Go 1.19.5 milestone on the issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.19.5+label%3ACherryPickApproved
full diff: https://github.com/golang/go/compare/go1.19.4...go1.19.5
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-11 00:41:55 +01:00
f163d2441e
Merge pull request #3956 from thaJeztah/update_btrfs_status
...
deprecated: update deprecation for btrfs on CentOS/RHEL 7
2023-01-10 10:30:18 +01:00
d1f02a2733
deprecated: update deprecation for btrfs on CentOS/RHEL 7
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-09 19:04:33 +01:00
4c0a3c3288
Merge pull request #3954 from thaJeztah/deprecate_centos7_btrfs
...
deprecation: mark btrfs driver as deprecated for CentOS 7 and RHEL7
2023-01-09 14:51:26 +01:00
bdc7e37b30
deprecation: mark btrfs driver as deprecated for CentOS 7 and RHEL7
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-09 14:34:59 +01:00
f3ed6db2b1
Merge pull request #3952 from thaJeztah/docs_inspect_trailing_whitespace
...
docs: inspect: remove trailing whitespace from example
2023-01-07 12:48:46 +01:00
35d7fbc818
docs: inspect: remove trailing whitespace from example
...
Current versions of the docs generator take this into account, but on
the 20.10 branch, the trailing whitespace can make the YAML generator
switch to use "compact" formatting, which is hard to read, and hard
to review diffs when updating.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-07 12:24:14 +01:00
d32f0484eb
Merge pull request #3924 from crazy-max/docs-ref-code-delim
...
cmd: set double quotes as code delimiter
2023-01-06 23:18:23 +01:00
79c9e527a3
docs: generate markdown
...
Keep frontmatter for docker, dockerd and index markdown files.
Also needs to move cli.md > docker.md before generation and
then move it back because cli.md is needed for yaml generation on docs
website: https://github.com/docker/cli/pull/3924#discussion_r1059986605
Signed-off-by: Kevin Alvarez <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-06 22:36:47 +01:00
186dcf30b1
docs: fix anchors
...
Signed-off-by: Kevin Alvarez <crazy-max@users.noreply.github.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-06 22:36:03 +01:00
c49f1ccb49
update cli-docs-tool to v0.5.1
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-01-06 19:15:34 +01:00
5a5b7a61d5
contrib: fix engine logging docs link
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-01-06 19:15:34 +01:00
4595ce588c
cmd: set double quotes as code delimiter
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-01-06 19:15:33 +01:00
9d1ace9aeb
Merge pull request #3949 from thaJeztah/fix_more_anchors
...
docs: fix some more anchors
2023-01-06 19:12:13 +01:00
81b051298e
docs: fix some more anchors
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-06 18:45:32 +01:00
99023cb372
Merge pull request #3948 from thaJeztah/fix_anchor_links
...
docs: fix anchor links
2023-01-06 17:45:52 +01:00
71e561780a
docs: fix anchor links
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-06 17:29:40 +01:00
3613fcc864
docs: deprecated: fix link to Docker Desktop 3.2.0 release notes
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-01-06 16:55:50 +01:00
e5b29b8975
Merge pull request #3943 from vvoland/fix-test-removeforce
...
cli/rm_test: Fix TestRemoveForce race condition
2023-01-06 15:39:39 +01:00
b811057181
cli/rm_test: Fix TestRemoveForce race condition
...
Synchronize append on the `removed` slice with mutex because
containerRemoveFunc is called in parallel for each removed container by
`container rm` cli command.
Also reduced the shared access area by separating the scopes of test
cases.
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2023-01-04 10:57:45 +01:00
850fb6921c
Merge pull request #3936 from thaJeztah/strings_cut
...
Replace uses of `strings.Split(N)` with `strings.Cut()`
2022-12-29 19:02:20 +01:00
42de5cc7f0
service/logs: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:31 +01:00
3fa18636ec
internal/test: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:31 +01:00
c8bd8932a1
cli/config: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:31 +01:00
3bed830a27
cli/compose: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:31 +01:00
cb19bf9f7d
cli/command: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:31 +01:00
acc45f5494
cli/command/volume: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:30 +01:00
806f9eab68
cli/command/swarm: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:30 +01:00
b3557b2840
cli/command/stack: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:30 +01:00
2b06c0c42c
cli/command/service: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:30 +01:00
f29992c0f1
cli/command/network: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:30 +01:00
424401233f
cli/command/container: use strings.Cut
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:19:24 +01:00
6c39bc1f60
opts: use strings.Cut for handling key/value pairs
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:14:15 +01:00
a473c5b38a
opts: rename logOptsValidator, fix unhandled errors in tests
...
This validator was not specific to "log options", so renaming it to make this
clearer; also updating values used in the tests to make it clear they're not
"actual" valid values, just for testing, and while updating, also fixed some
unhandled errors in tests.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:14:14 +01:00
d84256132d
remove redundant conversions and braces
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-29 15:14:14 +01:00
0359f8eeee
Merge pull request #3939 from vvoland/docs-run-fix-blog
...
docs/run: Fix url to blog "Docker can now run within Docker"
2022-12-29 15:03:15 +01:00
720a6a8239
docs/run: Fix url to blog "Docker can now run within Docker"
...
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2022-12-29 14:33:34 +01:00
b1db70ded7
Merge pull request #3931 from danger89/patch-1
...
Missing exec_die event
2022-12-28 18:11:16 +01:00
946bb9471b
Missing exec_die event
...
Add also `exec_die` event.
Signed-off-by: Melroy van den Berg <melroy@melroy.org>
2022-12-28 01:50:50 +01:00
Sebastiaan van Stijn
CrazyMax
Sebastiaan van Stijn
Ville Skyttä
Paweł Gronowski
Melroy van den Berg