6 Commits

Author	SHA1	Message	Date
Patrick Daigle	e547881e27	Fix ssh process killed when context is done ... Signed-off-by: Patrick Daigle <114765035+pdaig@users.noreply.github.com>	2022-12-04 22:09:17 -05:00
Sebastiaan van Stijn	1da95ff6aa	format code with gofumpt ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2022-09-30 11:59:11 +02:00
Sebastiaan van Stijn	82427d1a07	format (GoDoc) comments with Go 1.19 to prepare for go updates ... Older versions of Go do not format these comments, so we can already reformat them ahead of time to prevent gofmt linting failing once we update to Go 1.19 or up. Result of: gofmt -s -w $(find . -type f -name '*.go' | grep -v "/vendor/") With some manual adjusting. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2022-07-19 19:10:16 +02:00
Tibor Vass	8d199d5bba	Use golang.org/x/sys/execabs ... On Windows, the os/exec.{Command,CommandContext,LookPath} functions resolve command names that have neither path separators nor file extension (e.g., "git") by first looking in the current working directory before looking in the PATH environment variable. Go maintainers intended to match cmd.exe's historical behavior. However, this is pretty much never the intended behavior and as an abundance of precaution this patch prevents that when executing commands. Example of commands that docker.exe may execute: `git`, `docker-buildx` (or other cli plugin), `docker-credential-wincred`, `docker`. Note that this was prompted by the [Go 1.15.7 security fixes](https://blog.golang.org/path-security), but unlike in `go.exe`, the windows path lookups in docker are not in a code path allowing remote code execution, thus there is no security impact on docker. Signed-off-by: Tibor Vass <tibor@docker.com>	2021-01-26 17:18:04 +00:00
Akihiro Suda	62a15c16fc	commandconn: set SysProcAttr.Setsid ... Setting `Setsid` is needed for SSH connection helper with `ProxyCommand` config, so as to detach TTY. e.g. $ cat ~/.ssh/config Host foo Hostname foo ProxyCommand ssh -W %h:%p bastion $ DOCKER_HOST=ssh://foo docker run -it --rm alpine / # Fix #1707 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>	2019-03-06 13:22:54 +09:00
Akihiro Suda	dbe7afbd04	connhelper: export functions for other projects ... Exposed functions are planned to be used by `buildctl`: https://github.com/moby/buildkit/issues/769 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>	2019-03-02 21:11:49 +09:00