a5ebe2282a
commandconn: don't return error if command closed successfully
...
---
commandconn: fix race on `Close()`
During normal operation, if a `Read()` or `Write()` call results
in an EOF, we call `onEOF()` to handle the terminating command,
and store it's exit value.
However, if a Read/Write call was blocked while `Close()` is called
the in/out pipes are immediately closed which causes an EOF to be
returned. Here, we shouldn't call `onEOF()`, since the reason why
we got an EOF is because we're already terminating the connection.
This also prevents a race between two calls to the commands `Wait()`,
in the `Close()` call and `onEOF()`
---
Add CLI init timeout to SSH connections
---
connhelper: add 30s ssh default dialer timeout
(same as non-ssh dialer)
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
2023-06-09 11:24:19 +02:00
db5e1fa544
vendor: update docker/docker to latest v25.0.0-dev
...
full diff: 88f4bf4ae4...cf4df9d8ae
2023-05-24 01:24:56 +02:00
353e0a942d
vendor: github.com/docker/distribution v2.8.2
...
CI
- Dockerfile: fix filenames of artifacts
Bugfixes
- Fix panic in inmemory driver
- Add code to handle pagination of parts. Fixes max layer size of 10GB bug
- Parse http forbidden as denied
- Revert "registry/client: set Accept: identity header when getting layers
Runtime
- Update to go1.19.9
- Dockerfile: update xx to v1.2.1 ([#3907 ](https://github.com/distribution/distribution/pull/3907 ))
Security
- Fix [CVE-2022-28391](https://www.cve.org/CVERecord?id=CVE-2022-28391 ) by bumping alpine from 3.14 to 3.16
- Fix [CVE-2023-2253](https://www.cve.org/CVERecord?id=CVE-2023-2253 ) runaway allocation on /v2/_catalog [`521ea3d9`](521ea3d973https://github.com/docker/distribution/compare/v2.8.1...v2.8.2-beta.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-11 19:13:41 +02:00
28bc90f3b4
vendor: update docker/docker to v25.0.0-dev, API v1.44
...
full diff: https://github.com/docker/docker/compare/v24.0.0-rc.2...88f4bf4ae4bace73608b73df9fb974081d2bed1a
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-08 08:57:22 +02:00
1d8e2b6525
vendor: github.com/docker/docker v24.0.0-rc.2
...
no diff, because it's the same as the previous commit, but now tagged;
8d9a40a820
2023-05-06 13:52:37 +02:00
4f97f55999
vendor: github.com/docker/docker v24.0.0-rc.1.0.20230505222407-8d9a40a82034
...
This will be v24.0.0-rc.2
full diff: https://github.com/docker/docker/compare/v24.0.0-rc.1...8d9a40a820349860405e142249c55215aa4da8e3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-06 00:34:34 +02:00
0428418d6b
vendor: github.com/containerd/containerd v1.6.21
...
no changes in vendored files
full diff: https://github.com/containerd/containerd/compare/v1.6.20...v1.6.21
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-06 00:30:50 +02:00
05bf6fff2e
vendor: github.com/opencontainers/runc v1.1.7
...
full diff: https://github.com/opencontainers/runc/compare/v1.1.6...v1.1.7
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-06 00:27:51 +02:00
44fce07069
vendor: github.com/mattn/go-runewidth v0.0.14
...
Contains various performance optimisations.
full diff: https://github.com/mattn/go-runewidth/compare/v0.0.13...v0.0.14
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-05 02:37:12 +02:00
f233becf91
vendor: github.com/moby/term v0.5.0
...
- split exported functions from implementation
- windows: IsConsole(): fix deprecation comment
- deprecate Termios in favor of unix.Termios
- windows: keyToString(): fix string conversion
- gha: update actions, add macOS, and add Go1.20
- gha: add windows
full diff: https://github.com/moby/term/compare/c43b287e0e0f...v0.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-02 14:22:36 +02:00
bd2c26328f
vendor: github.com/docker/docker v24.0.0-rc.1
...
full diff: https://github.com/docker/docker/compare/v24.0.0-beta.2...v24.0.0-rc.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-28 17:56:17 +02:00
962e22c311
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230406225228-75e92ce14ff7
...
full diff: e28e8ba9bc...75e92ce14f
2023-04-27 02:22:45 +02:00
72192c75c2
vendor: github.com/moby/buildkit v0.11.6
...
no changes in vendored files
full diff: https://github.com/moby/buildkit/compare/v0.11.5...v0.11.6
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-27 02:21:59 +02:00
c177e2060d
vendor: github.com/creack/pty v1.1.18
...
full diff: https://github.com/creack/pty/compare/v1.1.11...v1.1.18
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-27 02:20:43 +02:00
a4bcabc7d2
vendor: github.com/docker/docker v24.0.0-beta.2
...
full diff: https://github.com/docker/docker/compare/v24.0.0-beta.1...v24.0.0-beta.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-17 23:14:51 +02:00
0286e36bbe
vendor: github.com/opencontainers/runc v1.1.6
...
full diff: https://github.com/opencontainers/runc/compare/v1.1.5...v1.1.6
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-17 23:13:21 +02:00
1f1a6c5a82
vendor: golang.org/x/net v0.8.0
...
full diff: https://github.com/golang/net/compare/v0.7.0...v0.8.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-17 23:12:23 +02:00
6e2163a712
vendor: golang.org/x/text v0.8.0
...
full diff: https://github.com/golang/text/compare/v0.7.0...v0.8.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-17 23:11:05 +02:00
551d519b57
vendor: golang.org/x/term v0.6.0
...
full diff: https://github.com/golang/term/compare/v0.5.0...v0.6.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-17 23:10:07 +02:00
c25b8f803e
vendor: github.com/spf13/cobra v1.7.0
...
release notes: https://github.com/spf13/cobra/releases/tag/v1.7.0
Features
- Allow to preserve ordering of completions in bash, zsh, pwsh, & fish
- Add support for PowerShell 7.2+ in completions
- Allow sourcing zsh completion script
Bug fixes
- Don't remove flag values that match sub-command name
- Fix powershell completions not returning single word
- Remove masked template import variable name
- Correctly detect completions with dash in argument
Testing & CI/CD
- Deprecate Go 1.15 in CI
- Deprecate Go 1.16 in CI
- Add testing for Go 1.20 in CI
- Add tests to illustrate unknown flag bug
Maintenance
- Update main image to better handle dark backgrounds
- Fix stale.yaml mispellings
- Remove stale bot from GitHub actions
- Add makefile target for installing dependencies
- Add Sia to projects using Cobra
- Add Vitess and Arewefastyet to projects using cobra
- Fixup for Kubescape github org
- Fix route for GitHub workflows badge
- Fixup for GoDoc style documentation
- Various bash scripting improvements for completion
- Add Constellation to projects using Cobra
Documentation
- Add documentation about disabling completion descriptions
- Improve MarkFlagsMutuallyExclusive example in user guide
- Update shell_completions.md
- Update copywrite year
- Document suggested layout of subcommands
- Replace deprecated ExactValidArgs with MatchAll in doc
full diff: https://github.com/spf13/cobra/compare/v1.6.1...v1.7.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-09 23:10:56 +02:00
966e191d30
Merge pull request #4151 from crazy-max/improve-plugins-list
...
improve plugins listing performance
2023-04-03 14:35:15 +02:00
89583b92b7
improve plugins listing performance
...
We can slightly improve plugins listing by spawning a
goroutine for each iteration.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-04-01 16:02:34 +02:00
fc560038ea
vendor: github.com/docker/docker v24.0.0-beta.1
...
full diff: https://github.com/docker/docker/compare/7c93e4a09be1...v24.0.0-beta.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-04-01 01:44:04 +02:00
33961a79f1
Merge pull request #4142 from thaJeztah/update_engine2
...
vendor: docker/docker master (v24.0.0-dev), containerd v1.6.20
2023-03-31 22:49:28 +02:00
e14f5fc1a7
revert "improve plugins discovery performance"
...
This reverts commit 62f2358b99
2023-03-31 16:20:42 +02:00
05cffcbedf
vendor: github.com/docker/docker 7c93e4a09be1 (v24.0.0-dev)
...
full diff: 54130b542d...7c93e4a09b
2023-03-31 01:00:05 +02:00
a36a54d3ca
vendor: github.com/containerd/containerd v1.6.20
...
full diff: https://github.com/containerd/containerd/compare/v1.6.19...v1.6.20
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-31 00:58:01 +02:00
f4b22fb6cf
vendor: github.com/opencontainers/image-spec v1.1.0-rc2.0.20221005185240-3a7f492d3f1b
...
full diff: 02efb9a75e...3a7f492d3f
2023-03-31 00:57:04 +02:00
bfa79fd75a
vendor: github.com/docker/docker master (v24.0.0-dev)
...
- updates VolumeList() calls for docker/docker master
- update fakeClient signature, and suppress err output in tests
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:28 +02:00
e86d2f4113
vendor: github.com/moby/buildkit v0.11.5
...
full diff: https://github.com/moby/buildkit/compare/v0.11.4...v0.11.5
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:28 +02:00
cd9c6a4c02
vendor: github.com/klauspost/compress v1.16.3
...
full diff: https://github.com/klauspost/compress/compare/v1.15.12...v1.16.3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:28 +02:00
5843fbd5f5
vendor: github.com/imdario/mergo v0.3.13
...
full diff: https://github.com/imdario/mergo/compare/v0.3.12...v0.3.13
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:27 +02:00
149d289638
vendor: golang.org/x/sys v0.6.0
...
full diff: https://github.com/golang/sys/compare/v0.5.0..v0.6.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:27 +02:00
6dca335d05
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230315203717-e28e8ba9bc83
...
full diff: a745a8755c...e28e8ba9bc
2023-03-30 19:56:27 +02:00
4389c966f8
vendor: github.com/opencontainers/runc v1.1.5
...
full diff: https://github.com/opencontainers/runc/compare/v1.1.3...v1.1.5
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-30 19:56:26 +02:00
a9fff59809
Merge pull request #4129 from crazy-max/fix-perf-reg-2
...
improve and load plugin command stubs when required
2023-03-30 17:05:16 +02:00
a39958846d
vendor: github.com/docker/docker v23.0.2
...
- migrate away from things deprecated in Go 1.20 (removes use of archive/tar.TypeRegA)
full diff: https://github.com/docker/docker/compare/v23.0.1...v23.0.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-28 18:35:05 +02:00
62f2358b99
improve plugins discovery performance
...
We are currently loading plugin commands stubs for every
command invocation to add support for Cobra v2 completion.
This cause a significant performance hit if there is a
lot of plugins in the user space (7 atm in Docker Desktop):
`docker --version` takes in current 23.0.1 ~93ms
Instead of removing completion for plugins to fix the
regression, we can slightly improve plugins discovery by
spawning a goroutine for each iteration in the loop when
listing plugins:
`docker --version` now takes ~38ms
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2023-03-28 06:16:55 +02:00
e60c748c14
vendor: github.com/moby/buildkit v0.11.4
...
full diff: https://github.com/moby/buildkit/compare/v0.10.6..v0.11.4
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:42:09 +01:00
6c8cc226f0
vendor: google.golang.org/grpc v1.50.1
...
full diff: https://github.com/grpc/grpc-go/compare/v1.48.0...v1.50.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:42:09 +01:00
d213548bd0
vendor: golang.org/x/net v0.7.0
...
full diff: https://github.com/golang/net/compare/v0.5.0...v0.7.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:42:00 +01:00
3a0d492d1c
vendor: golang.org/x/term v0.5.0
...
full diff: https://github.com/golang/term/compare/v0.4.0...v0.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:38:48 +01:00
f40bbf4f7f
vendor: golang.org/x/time v0.3.0
...
full diff: https://github.com/golang/time/compare/v0.1.0...v0.3.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:35:57 +01:00
a85537d346
vendor: golang.org/x/text v0.7.0
...
full diff: https://github.com/golang/text/compare/v0.6.0...v0.7.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:34:10 +01:00
3e9c6e84ce
vendor: golang.org/x/sys v0.5.0
...
full diff: https://github.com/golang/sys/compare/v0.4.0...v0.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:32:29 +01:00
ca8783ef43
vendor: github.com/moby/swarmkit/v2 v2.0.0-20230309194213-a745a8755ce3
...
full diff: 904c221ac2...a745a8755c
2023-03-15 01:03:04 +01:00
33806760a4
vendor: github.com/containerd/containerd v1.6.19
...
full diff: https://github.com/containerd/containerd/compare/v1.6.16...v1.6.19
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:03:04 +01:00
71e495aa54
vendor: github.com/docker/docker v23.0.1
...
full diff: https://github.com/docker/docker/compare/v23.0.0...v23.0.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-03-15 01:02:58 +01:00
bbebebaedf
vendor: github.com/docker/docker v23.0.0
...
- client: improve error messaging on crash
full diff: https://github.com/docker/docker/compare/v23.0.0-rc.3...v23.0.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-02-04 13:30:07 +01:00
5195db1ff5
vendor: github.com/containerd/containerd v1.6.16
...
no changes in vendored code
full diff: https://github.com/containerd/containerd/compare/v1.6.15...v1.6.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-02-04 13:28:11 +01:00
Laura Brehm
Sebastiaan van Stijn
Sebastiaan van Stijn
Kevin Alvarez