4 Commits

Author	SHA1	Message	Date
Ian Campbell	935d47bbe9	Ignore unknown arguments on the top-level command. ... This allows passing argument to plugins, otherwise they are caught by the parse loop, since cobra does not know about each plugin at this stage (to avoid having to always scan for all plugins) this means that e.g. `docker plugin --foo` would accumulate `plugin` as an arg to the `docker` command, then choke on the unknown `--foo`. This allows unknown global args only, unknown arguments on subcommands (e.g. `docker ps --foo`) are still correctly caught. Add an e2e test covering this case. Signed-off-by: Ian Campbell <ijc@docker.com>	2019-01-30 13:45:26 +00:00
Ian Campbell	e5e578abc7	Allow plugins to make use of the cobra `PersistentPreRun` hooks. ... Previously a plugin which used these hooks would overwrite the top-level plugin command's use of this hook, resulting in the dockerCli object not being fully initialised. Provide a function which plugins can use to chain to the required behaviour. This required some fairly ugly arrangements to preserve state (which was previously in-scope in `newPluginCOmmand`) to be used by the new function. Signed-off-by: Ian Campbell <ijc@docker.com>	2019-01-30 13:45:26 +00:00
Ian Campbell	20a284721c	Integrate CLI plugins with `docker help «foo»` ... Signed-off-by: Ian Campbell <ijc@docker.com>	2019-01-30 13:45:18 +00:00
Ian Campbell	5db336798c	Add some simple e2e tests for executing CLI plugins ... To help with this add a bad plugin which produces invalid metadata and arrange for it to be built in the e2e container. Signed-off-by: Ian Campbell <ijc@docker.com>	2019-01-30 13:44:05 +00:00