Sebastiaan van Stijn
b45477bffa
Merge pull request #5591 from noahsilas/docs-run-exit-code
...
docs: Correct `run` exit code 126 description
2024-11-04 17:27:25 +01:00
Noah Silas
0c999fe95b
docs: Correct `run` exit code 126 description
...
The command to run inside the container is `/etc`. The semicolon is a
statement terminator, which ends the command `docker run busybox /etc`,
while `echo $?` prints the exit code of that full docker command.
Having this mistake could confuse someone who thinks that `/etc; echo
$?` is all run inside the container, which wouldn't help the reader
understand the exit code of the `docker run` command itself.
Signed-off-by: Noah Silas <noah@hustle.com>
2024-11-04 00:21:33 +00:00
Sebastiaan van Stijn
5f1311ae8d
vendor: github.com/docker/docker 6ac445c42bad (master, v28.0-dev)
...
full diff: 36a3bd0904...6ac445c42b
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 14:10:15 +01:00
Sebastiaan van Stijn
10c5a57927
vendor: go.opentelemetry.io/contrib/instrumentation/xxx v0.53.0
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 14:10:09 +01:00
Sebastiaan van Stijn
5e40d288c7
vendor: go.opentelemetry.io/otel v1.28.0
...
aligning all related packages to v1.28.0 as well
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 14:08:45 +01:00
Sebastiaan van Stijn
9ba73a1a05
vendor: github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0
...
full diff: https://github.com/grpc-ecosystem/grpc-gateway/compare/v2.16.0...v2.20.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 14:04:41 +01:00
Sebastiaan van Stijn
f3cf1b4213
vendor: go.etcd.io/etcd/raft/v3 v3.5.16
...
no changes in vendored code
full diff: https://github.com/etcd-io/etcd/compare/v3.5.6...v3.5.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:54:25 +01:00
Sebastiaan van Stijn
cae19e3928
vendor: github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6
...
no changes in vendored code
full diff: ced1acdcaa...e8a1dd7889
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:46:38 +01:00
Sebastiaan van Stijn
074d1028b5
vendor: update prometheus dependencies
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:44:05 +01:00
Sebastiaan van Stijn
1dbcce2057
vendor: google.golang.org/grpc v1.67.1
...
full diff:
- https://github.com/grpc/grpc-go/compare/v1.66.2...v1.67.1
- ef581f9131...5fefd90f89
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:39:15 +01:00
Sebastiaan van Stijn
1bba009944
vendor: google.golang.org/protobuf v1.35.1
...
full diff: https://github.com/protocolbuffers/protobuf-go/compare/v1.34.1...v1.35.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:31:29 +01:00
Sebastiaan van Stijn
e3942d46a0
vendor: github.com/klauspost/compress v1.17.11
...
full diff: https://github.com/klauspost/compress/compare/v1.17.9...v1.17.11
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:28:47 +01:00
Sebastiaan van Stijn
97ff1b7c0a
vendor: github.com/go-logr/logr v1.4.2
...
full diff: https://github.com/go-logr/logr/compare/v1.4.1...v1.4.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:25:17 +01:00
Sebastiaan van Stijn
4c85feb4dd
vendor: github.com/cenkalti/backoff/v4 v4.3.0
...
full diff: https://github.com/cenkalti/backoff/compare/v4.2.1...v4.3.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:23:39 +01:00
Sebastiaan van Stijn
3b48a57b04
vendor: github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161
...
documentation changes only, no changes in vendored code
full diff: d185dfc1b5...306776ec81
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:20:48 +01:00
Sebastiaan van Stijn
36e6c42977
vendor: golang.org/x/net v0.30.0
...
full diff: https://github.com/golang/net/compare/v0.29.0...v0.30.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:17:57 +01:00
Sebastiaan van Stijn
84bfa52a6c
vendor: golang.org/x/crypto v0.28.0
...
no changes in vendored code
full diff: https://github.com/golang/crypto/compare/v0.27.0...v0.28.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:16:26 +01:00
Sebastiaan van Stijn
7a94f592ed
vendor: golang.org/x/text v0.19.0
...
no changes in vendored code
full diff: https://github.com/golang/text/compare/v0.18.0...v0.19.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:14:25 +01:00
Sebastiaan van Stijn
ef197f7314
vendor: golang.org/x/term v0.25.0
...
no changes in vendored code
full diff: https://github.com/golang/term/compare/v0.24.0...v0.25.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:12:59 +01:00
Sebastiaan van Stijn
02b92c699d
vendor: golang.org/x/sys v0.26.0
...
full diff: https://github.com/golang/sys/compare/v0.25.0...v0.26.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-11-01 13:11:15 +01:00
Laura Brehm
2995631498
Merge pull request #5586 from Giedriusj1/master
2024-10-31 13:29:09 +00:00
Paweł Gronowski
fb103cb982
Merge pull request #5583 from thaJeztah/bump_golang_1.23.2
...
update to go1.23.2
2024-10-31 13:10:28 +00:00
Sebastiaan van Stijn
42cda38840
update to go1.23.2
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-31 13:04:02 +01:00
Sebastiaan van Stijn
5e51513a8b
Merge pull request #5585 from thaJeztah/bump_golangci_lint
...
bump golangci-lint to v1.61.0 and cleanup config
2024-10-31 13:03:00 +01:00
Giedrius Jonikas
0b16070ae6
Buffer 'docker stats' text to avoid terminal flickering
...
This change reduces the flickering of the terminal when
running `docker stats` by buffering the formatted stats
text and printing it in one write.
Should also consume less CPU as we now only have to issue
a single syscall to write the stats text to the terminal.
Signed-off-by: Giedrius Jonikas <giedriusj1@gmail.com>
2024-10-31 11:23:57 +00:00
Sebastiaan van Stijn
9af049c618
bump golangci-lint to v1.61.0
...
Also updating a linter that was deprecated;
The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-30 15:54:47 +01:00
Sebastiaan van Stijn
745629bd55
golangci-lint: update comment, and disable "exclude-dirs-use-default"
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-30 15:52:18 +01:00
Sebastiaan van Stijn
7451339ab0
golangci-lint: move gosec excludes to linters-settings
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-30 15:52:18 +01:00
Sebastiaan van Stijn
020f3a7ad9
golangci-lint: enable G204, add #nosec comments instead
...
There's only 3 locations where it's hit, so putting #gosec ignore comments
in those locations.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-30 15:52:18 +01:00
Sebastiaan van Stijn
aa331e94cc
Merge pull request #5579 from thaJeztah/remove_warning
...
cli/command/container: parse: remove client-side warning
2024-10-30 10:50:34 +01:00
Sebastiaan van Stijn
1875d9fdcb
Merge pull request #5538 from albers/completion-events--filter
...
Completion for `events --filter`
2024-10-29 17:58:16 +01:00
Harald Albers
e1c5180dba
Add tests for completions that call the API
...
Signed-off-by: Harald Albers <github@albersweb.de>
2024-10-29 15:58:17 +00:00
Harald Albers
d4f4cf1418
Add completion for `events --filter`
...
Signed-off-by: Harald Albers <github@albersweb.de>
2024-10-29 15:58:17 +00:00
Sebastiaan van Stijn
59b90305f7
cli/command/container: parse: remove client-side warning
...
remove a client-side warning about volume drivers combined with "mounts"
in favor of producing the warning on the daemon side.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-28 23:13:31 +01:00
Sebastiaan van Stijn
32ff200fe6
Merge pull request #5573 from thaJeztah/inspect_add_configs
...
docker inspect: add support for swarm configs
2024-10-25 17:38:47 +02:00
Sebastiaan van Stijn
e9ae9f788b
docker inspect: add support for swarm configs
...
The docker inspect command did not inspect configs. This patch adds support for
it, and while at it, also sorts the list of objects in runInspect.
Before this patch:
docker config create myconfig ./codecov.yml
danpeyh8qzb30vgdj9fr665l1
docker inspect --format='{{.ID}}' myconfig
[]
Error: No such object: myconfig
docker inspect --format='{{.ID}}' --type=config myconfig
"config" is not a valid value for --type
With this patch:
docker inspect --format='{{.ID}}' myconfig
danpeyh8qzb30vgdj9fr665l1
docker inspect --format='{{.ID}}' --type=config myconfig
danpeyh8qzb30vgdj9fr665l1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-24 18:32:32 +02:00
Sebastiaan van Stijn
61baf2a3d9
Merge pull request #5570 from thaJeztah/credentials_coverage
...
cli/config/credentials: add test for save being idempotent
2024-10-22 16:36:58 +02:00
Sebastiaan van Stijn
c34b80bc65
Merge pull request #5567 from thaJeztah/config_fix_err
...
cli/config: improve error when failing to parse config file
2024-10-22 14:05:45 +02:00
Sebastiaan van Stijn
ea511f0de2
Merge pull request #5549 from thaJeztah/remove_cli_errors
...
cli: remove deprecated Errors type
2024-10-22 12:35:42 +02:00
Sebastiaan van Stijn
3c78069240
cli/config/credentials: add test for save being idempotent
...
Test case for d3f6867e4d
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-22 12:22:54 +02:00
Sebastiaan van Stijn
0dd6f7f1b3
cil/config/credentials: remove newStore() test-utility
...
This function was names slightly confusing, as it returns a fakeStore,
and it didn't do any constructing, so didn't provide value above just
constructing the type.
I'm planning to add more functionality to the fakeStore, but don't want
to maintain a full-fledged constructor for all of that, so let's remove
this utility.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-22 10:58:29 +02:00
Sebastiaan van Stijn
5f4b14950e
cli: remove deprecated Errors type
...
The Errors type was deprecated in d3bafa5f3e
,
which has been included in the 27.4.0 release.
This patch removes the type, as there are no external consumers.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-22 10:43:24 +02:00
Sebastiaan van Stijn
1aab64dd90
Merge pull request #5547 from thaJeztah/plugin_better_error
...
cli/command/plugins: use errors.Join instead of custom cli.Errors, and deprecate cli.Errors
2024-10-22 10:42:26 +02:00
Sebastiaan van Stijn
0ab0eca8bd
Merge pull request #5550 from thaJeztah/login_minor_refactor
...
cli/command: PromptUserForCredentials: assorted minor improvements and (linting) fixes
2024-10-21 23:23:06 +02:00
Sebastiaan van Stijn
d96f8b7f91
cli/config: improve error when failing to parse config file
...
The format had a stray colon and space included. While fixing that, also
updating the error message to clarify the error happened while parsing
the file (not so much "loading" it).
Before:
WARNING: Error loading config file: /root/.docker/config.json: : json: cannot unmarshal bool into Go struct field ConfigFile.features of type string
After:
WARNING: Error parsing config file (/root/.docker/config.json): json: cannot unmarshal bool into Go struct field ConfigFile.features of type string
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-10-21 18:26:02 +02:00
Sebastiaan van Stijn
abb8e9b78a
Merge pull request #5546 from thaJeztah/hints_coverage
...
cli/hints: add tests
2024-10-21 18:08:28 +02:00
Laura Brehm
7029147458
Merge pull request #5557 from thaJeztah/minor_linting_issues
2024-10-21 17:00:40 +01:00
Paweł Gronowski
d2b87a0a3b
Merge pull request #5553 from thaJeztah/login_idempotent
...
cli/config/credentials: skip saving config-file if credentials didn't change
2024-10-21 15:23:26 +02:00
Sebastiaan van Stijn
24ee5f228a
Merge pull request #5551 from thaJeztah/fix_ConfigureAuth_deprecation
...
cli/command: ConfigureAuth: fix deprecation comment
2024-10-21 14:28:43 +02:00
Sebastiaan van Stijn
8b6133a2b7
Merge pull request #5544 from thaJeztah/bump_engine_28
...
vendor: github.com/docker/docker 36a3bd090489 (master, v28.0-dev)
2024-10-21 13:28:35 +02:00