ce3d069936
Fix: Warning Message
...
Signed-off-by: Vimal-Raghubir <vraghubir0418@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-07-13 13:39:24 +02:00
13eb2aa125
Configure CircleCI remote daemon to use version 18.03.1
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-07-13 11:51:41 +02:00
d57cc1782e
Merge pull request #1208 from thaJeztah/update-linting
...
Update gometalinter to v2.0.6, remove nakedret
2018-07-13 11:41:59 +02:00
e2a56c47da
Update CircleCI Docker version to 18.03
...
17.06 has reached EOL a long time ago; let's use a current
version in CI as well :D
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-07-13 11:26:07 +02:00
9847e96765
Update hints for linting
...
- remove some hints that are no longer needed
- added a nolint: unparam for removeSingleSigner() (return bool is only used in tests)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-07-13 11:18:50 +02:00
f3811e865e
Update gometalinter to v2.0.6 and remove alexkohler/nakedret
...
alexkohler/nakedret is now installed by default with gometalinter,
so it's no longer needed to install this manually
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-07-13 11:17:43 +02:00
d97f378009
Merge pull request #1210 from albers/completion-service-create--init
...
Add bash completion for `service create|update --init`
2018-07-13 09:44:11 +02:00
97d312e02a
Add bash completion for `service create|update --init`
...
Signed-off-by: Harald Albers <github@albersweb.de>
2018-07-13 09:05:29 +02:00
ee8cdb3850
Merge pull request #1204 from thaJeztah/improve-version-align
...
Improve version output alignment
2018-07-12 10:53:50 +02:00
0f7ae34ea9
Adapt min-column width to component information
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-07-12 01:34:34 +02:00
55ff66d967
Extend version-align test with components
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-07-12 01:31:23 +02:00
c8b9c21ef9
Merge pull request #1178 from cyli/fix-swarm-ca-command
...
Propagate the provided external CA certificate to the external CA object in swarm
2018-07-10 01:31:32 +02:00
b91953f507
Merge pull request #1196 from adshmh/use-sort-slice-for-sorting-cli-compose
...
refactored commands to use sort.Slice
2018-07-09 07:18:11 -07:00
71d650ee17
refactored cli/compose and cli/command/trust to use sort.Slice and removed custom types used for sorting
...
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2018-07-08 15:08:17 -04:00
2b221d8f1c
Merge pull request #1194 from adshmh/use-sort-slice-for-sorting-output
...
use sort.Slice for sorting commands' output
2018-07-07 18:13:12 +02:00
ceed42217d
refactored all commands under cli/command/ to use sort.Slice instead of declaring custom types for sorting
...
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2018-07-06 15:49:32 -04:00
2634562119
Merge pull request #1102 from sfluor/1074-fix-mapping-a-range-of-host-ports-to-a-single-container-port
...
Fix mapping a range of host ports to a single container port
2018-07-06 14:41:00 +02:00
8160759013
Merge pull request #1166 from adshmh/add-sort-to-plugin-list
...
Sort plugin names in a natural order
2018-07-05 16:34:25 -07:00
249c8652a2
For docker/docker.github.io/issues/6987
...
Signed-off-by: Peter Kehl <peter.kehl@gmail.com>
2018-07-05 14:12:47 -07:00
26151d910a
The output of plugin list command is sorted by plugin name
...
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
2018-07-05 12:35:53 -04:00
29612ccefe
Adding support of the long syntax publish notation
...
Signed-off-by: Sami Tabet <salph.tabet@gmail.com>
2018-07-05 00:33:13 +02:00
f285fe67e9
Merge pull request #1163 from thaJeztah/bump_engine
...
bump docker and dependencies
2018-07-04 16:17:12 +02:00
5f6d5c7328
Bump docker and dependencies
...
Updates docker/docker to 1436dc8f8d0f6f60b6e335fbd918d6b22ee6574d,
matching 18.06.0-rc1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-07-04 01:14:40 +00:00
bded5beb78
Merge pull request #1186 from tiborvass/buildkit-envvar-zero
...
build: use strconv.ParseBool to parse DOCKER_BUILDKIT to allow value "0"
2018-07-04 01:28:03 +02:00
721000e6c9
build: use strconv.ParseBool to parse DOCKER_BUILDKIT to allow value "0"
...
Signed-off-by: Tibor Vass <tibor@docker.com>
2018-07-03 23:14:06 +00:00
7b255e653a
Merge pull request #1176 from tiborvass/buildkit-iidfile
...
build: --iidfile support with buildkit
2018-07-03 15:36:23 -07:00
c7e85c09d2
build: --iidfile support with buildkit
...
Signed-off-by: Tibor Vass <tibor@docker.com>
2018-07-03 19:11:11 +00:00
69e1743e3d
Merge pull request #1156 from dmcgowan/fix-manifest-list-size
...
Fix manifest lists to always use correct size
2018-07-03 11:27:19 -07:00
4243440e1f
Propagate the provided external CA certificate to the external CA object
...
in swarm.
Also, fix some CLI command confusions:
1. If the --external-ca flag is provided, require a --ca-cert flag as well, otherwise
the external CA is set but the CA certificate is actually rotated to an internal
cert
2. If a --ca-cert flag is provided, require a --ca-key or --external-ca flag be
provided as well, otherwise either the server will say that the request is
invalid, or if there was previously an external CA corresponding to the cert, it
will succeed. While that works, it's better to require the user to explicitly
set all the parameters of the new desired root CA.
This also changes the `swarm update` function to set the external CA's CACert field,
which while not strictly necessary, makes the CA list more explicit.
Signed-off-by: Ying Li <ying.li@docker.com>
2018-07-02 17:14:21 -07:00
f5393c904a
Merge pull request #1175 from vdemeester/bump-k8s
...
Bump kubernetes dependencies to 1.8.14
2018-07-02 17:12:35 +02:00
b59c41b2a7
Bump kubernetes dependencies to 1.8.14
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-07-02 16:32:07 +02:00
95a9b4d5fe
Merge pull request #1172 from vdemeester/no-need-to-check-files
...
Remove composefiles length check on k8s RunDeploy
2018-07-02 15:06:50 +02:00
847e0c22d4
Remove composefiles lenght check on k8s RunDeploy..
...
The compose file(s) are already loaded at that point.
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-07-02 15:00:19 +02:00
a2b4d30cd0
Merge pull request #1171 from silvin-lubecki/fix-doc-typo
...
Fix Format example typo"
2018-07-02 14:47:39 +02:00
d0ddf91539
Fixing issue #1167 "Format example typo"
...
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
2018-07-02 14:21:10 +02:00
18091ea7e2
Merge pull request #1170 from vdemeester/omit-silvin
...
Add omitempty on compose config top-level types
2018-07-02 14:16:53 +02:00
f05ab2b1fb
Add omitempty on compose config top-level types
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-07-02 12:04:09 +02:00
981c099b96
Merge pull request #1169 from silvin-lubecki/schema-vendoring
...
Add a doc.go file so the compose/schema/data directory can be vendore…
2018-07-02 10:47:25 +02:00
1c69e83034
Merge pull request #1168 from vdemeester/update-testing
...
Update TESTING.md to replace testify by gotest.tools
2018-07-02 10:34:28 +02:00
3a8ef767f8
Add a doc.go file so the compose/schema/data directory can be vendored in another project, without being pruned.
...
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
2018-07-02 10:08:25 +02:00
9e36ff4491
Merge pull request #1160 from euank/simpler-pass
...
config/credentials: don't run 'pass' to detect it
2018-07-02 09:40:47 +02:00
057bf6f4d1
Update TESTING.md to replace testify by gotest.tools
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-07-02 09:24:28 +02:00
b91fd12996
add test for zero length variable name
...
parsing an environment file should give an error in case a zero-length
variable name (definition w/o a variable name) is encountered.
previously these lines went through unnoticed not informing the user about
a potential configuration error.
Signed-off-by: Tom Klingenberg <tklingenberg@lastflood.net>
2018-07-02 07:52:02 +02:00
96c026eb30
import environment variables that are present
...
previously docker did import environment variables if they were present
but created them if they were not when it was asked via a --env-file
cli option to import but not create them.
fix is to only import the variable into the environment if it is present.
additionally do not import variable names of zero-length (which are lines
w/ a potential variable definition w/o a variable name).
refs:
- https://github.com/docker/for-linux/issues/284
Signed-off-by: Tom Klingenberg <tklingenberg@lastflood.net>
2018-07-02 07:37:12 +02:00
1e89745704
add test for undefined variable environment file import
...
test to show current behavior is wrong at parsing an environment file
defining an undefined variable - it must not be defined!
NOTE: this test assume the $HOME variable is always set (see POSIX, this
normally is the case, e.g. the test suite remains stable).
Signed-off-by: Tom Klingenberg <tklingenberg@lastflood.net>
2018-07-02 07:33:44 +02:00
34ba66b0c5
Merge pull request #1157 from AzureCR/master
...
Updated the go-winio library to release 0.4.8 that has the fix for Windows Container
2018-06-29 21:11:53 +02:00
056015c3d8
config/credentials: don't run 'pass' to detect it
...
'CheckInitialized' in the credential-helper library actually invokes
`pass`, which isn't desirable (see #699 ).
This moves the check to be simpler, and then pass will only be invoked
when it's needed (such as for `docker login` or when pulling from a
private registry).
This logic could also reasonably live in the credential-helper library,
but it's simple enough it seems fine in either location.
Signed-off-by: Euan Kemp <euank@euank.com>
2018-06-29 11:38:39 -07:00
c98c4080a3
Updated the go-winio library to release 0.4.8 that has the fix for Windows containers
...
Signed-off-by: Tejaswini Duggaraju <naduggar@microsoft.com>
2018-06-29 10:49:52 -07:00
da59ccb601
Merge pull request #1145 from Vimal-Raghubir/590-Add-missing-option
...
Add: Add missing option
2018-06-29 17:16:25 +02:00
9faf728089
Merge pull request #1155 from adshmh/add-unit-tests-to-plugin-list
...
added unit tests to cover plugin list command
2018-06-29 15:49:30 +02:00
Vimal Raghubir
Sebastiaan van Stijn
Vincent Demeester
Sebastiaan van Stijn
Harald Albers
Silvin
Brian Goff
Arash Deshmeh
Peter Kehl
Sami Tabet
Tibor Vass
Tibor Vass
Tõnis Tiigi
Ying Li
Vincent Demeester
Silvin Lubecki
Tom Klingenberg
Euan Kemp
Tejaswini Duggaraju