7 Commits

Author	SHA1	Message	Date
Aaron Lehmann	6029def4cb	Remove pkg/testutil/assert in favor of testify ... I noticed that we're using a homegrown package for assertions. The functions are extremely similar to testify, but with enough slight differences to be confusing (for example, Equal takes its arguments in a different order). We already vendor testify, and it's used in a few places by tests. I also found some problems with pkg/testutil/assert. For example, the NotNil function seems to be broken. It checks the argument against "nil", which only works for an interface. If you pass in a nil map or slice, the equality check will fail. In the interest of avoiding NIH, I'm proposing replacing pkg/testutil/assert with testify. The test code looks almost the same, but we avoid the confusion of having two similar but slightly different assertion packages, and having to maintain our own package instead of using a commonly-used one. In the process, I found a few places where the tests should halt if an assertion fails, so I've made those cases (that I noticed) use "require" instead of "assert", and I've vendored the "require" package from testify alongside the already-present "assert" package. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>	2017-04-14 12:03:21 -07:00
Vincent Demeester	26c5b4b7b8	Move debug functions to cli/debug package ... Signed-off-by: Vincent Demeester <vincent@sbr.pm>	2016-12-12 09:33:58 +01:00
Daniel Nephin	004fc6b9e4	exit with status 1 if help is called on an invalid command. ... Signed-off-by: Daniel Nephin <dnephin@docker.com>	2016-11-23 15:13:58 -05:00
Daniel Nephin	b2c77abc35	Move api/client -> cli/command ... Using gomvpkg -from github.com/docker/docker/api/client -to github.com/docker/docker/cli/command -vcs_mv_cmd 'git mv {{.Src}} {{.Dst}}' Signed-off-by: Daniel Nephin <dnephin@docker.com>	2016-09-08 15:46:29 -04:00
Daniel Nephin	58a14cd18c	Update unit tests for new cobra root command. ... Cleanup cobra integration Update windows files for cobra and pflags Cleanup SetupRootcmd, and remove unnecessary SetFlagErrorFunc. Use cobra command traversal Signed-off-by: Daniel Nephin <dnephin@docker.com>	2016-08-25 13:09:04 -04:00
Daniel Nephin	08784d7e0e	Convert docker root command to use pflag and cobra ... Fix the daemon proxy for cobra commands. Signed-off-by: Daniel Nephin <dnephin@docker.com>	2016-08-25 13:09:03 -04:00
Daniel Nephin	ec6cc96fa1	Consolidate the files in client/ ... Signed-off-by: Daniel Nephin <dnephin@docker.com>	2016-04-27 14:53:36 -04:00

Renamed from client_test.go (Browse further)