Zander Mackie
965664d89b
Improve flow pull behavior before container creation.
...
- Also improve test coverage
Signed-off-by: Zander Mackie <zmackie@gmail.com>
2019-05-06 14:16:26 -07:00
Ravi Shekhar Jethani
a06b5db594
Update cli/command/container/create.go
...
Co-Authored-By: Zanadar <zmackie@gmail.com>
Signed-off-by: Zander Mackie <zmackie@gmail.com>
2019-05-06 14:16:26 -07:00
Zander Mackie
22cd418967
Adds flag modifying pull behavior for running and creating containers
...
- Follows the proposal on issue [#34394 ](https://github.com/moby/moby/issues/34394 )
- Maintains current behavior as default (Pull image if missing)
- Adds tristate flag allowing modification (PullMissing, PullAlways, PullNever)
Signed-off-by: Zander Mackie <zmackie@gmail.com>
2019-05-06 14:16:26 -07:00
Brian Goff
15130e3043
Support GOARM and windows .exe in binary target
...
This just makes it easier to build a targeted binary for the
goos/goach/goarm version.
This of course will not work for all cases but is nice to get things
going.
Specifically cross-compiling pkcs for yubikey support requires some
extra work whichis not tackled here.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2019-05-06 10:43:18 -07:00
Ian Campbell
af200f14ed
cli-plugins: fix when plugin does not use PersistentPreRun* hooks
...
This regressed in 3af168c7df
("Ensure plugins can use `PersistentPreRunE`
again.") but this wasn't noticed because the helloworld test plugin has it's
own `PersistentPreRunE` which has the effect of deferring the resolution of the
global variable. In the case where the hook isn't used the variable is resolved
during `newPluginCommand` which is before the global variable was set.
Initialize the plugin command with a stub function wrapping the call to the
(global) hook, this defers resolving the variable until after it has been set,
otherwise the initial value (`nil`) is used in the struct.
Signed-off-by: Ian Campbell <ijc@docker.com>
2019-04-30 10:45:29 +01:00
Vincent Demeester
3273c2e235
Merge pull request #1851 from thaJeztah/update_authors2
...
Update AUTHORS and mailmap
2019-04-29 07:31:59 +02:00
Sebastiaan van Stijn
ffc168ed51
Update AUTHORS and mailmap
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-27 17:39:39 -07:00
Sebastiaan van Stijn
55879706ce
Merge pull request #1848 from albers/completion-storage-driver-overlay
...
Remove deprecated storage drivers from bash completion
2019-04-26 10:38:32 -07:00
Ian Campbell
7d0645c5fe
Use command.Cli instead of command.DockerCli
...
The linter is complaining:
cmd/docker/docker.go:72:23⚠️ dockerCli can be github.com/docker/cli/cli/command.Cli (interfacer)
Unclear precisely which change in the preceeding commits caused it to notice
this possibility.
Signed-off-by: Ian Campbell <ijc@docker.com>
2019-04-26 15:43:03 +01:00
Ian Campbell
40a6cf7c47
Include CLI plugins in help output on unknown flag.
...
Previously `docker --badopt` output would not include CLI plugins.
Fixes #1813
Signed-off-by: Ian Campbell <ijc@docker.com>
2019-04-26 15:21:20 +01:00
Ian Campbell
79a75da0fd
Hide experimental builtin commands in help output on unknown flag.
...
Previously `docker --badopt` would always include experimental commands even if
experimental was not enabled.
Signed-off-by: Ian Campbell <ijc@docker.com>
2019-04-26 15:09:09 +01:00
Ian Campbell
d57175aa2e
Move subtests of TestGlobalHelp into actual subtests
...
Signed-off-by: Ian Campbell <ijc@docker.com>
2019-04-26 10:43:03 +01:00
Vincent Demeester
301c638d83
Merge pull request #1849 from albers/completion-systempaths-unconfined
...
Add bash completion for `--security-opt systempaths=unconfined`
2019-04-26 09:05:29 +02:00
Harald Albers
1648d6c4a4
Add bash completion for `--security-opt systempaths=unconfined`
...
Signed-off-by: Harald Albers <github@albersweb.de>
2019-04-25 23:49:30 +02:00
Harald Albers
bfa43d2989
Remove deprecated storage drivers from bash completion
...
Signed-off-by: Harald Albers <github@albersweb.de>
2019-04-25 23:06:39 +02:00
Silvin Lubecki
f28d9cc929
Merge pull request #1846 from andrewhsu/v
...
update vndr docker/docker ac48309 and related packages
2019-04-24 21:43:12 +02:00
Andrew Hsu
eb2bfeccf7
update vndr coreos/etcd d57e8b8
...
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
2019-04-24 18:29:33 +00:00
Andrew Hsu
c1a4fb4922
update vndr moby/buildkit 8818c67
...
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
2019-04-24 18:26:58 +00:00
Andrew Hsu
e243174b30
update vndr Microsoft/go-winio 84b4ab4
...
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
2019-04-24 18:24:26 +00:00
Andrew Hsu
af053bc278
update vndr Microsoft/hcsshim 672e52e
...
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
2019-04-24 18:14:51 +00:00
Andrew Hsu
30cc5d96b3
update vndr docker/docker to ac48309
...
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
2019-04-24 18:10:45 +00:00
Tõnis Tiigi
70f48f2231
Merge pull request #1840 from tiborvass/cli-plugin-aliases
...
cli-plugins: alias an existing allowed command (only builder for now)
2019-04-23 19:13:51 -07:00
Silvin Lubecki
9a0b171192
Merge pull request #1844 from thaJeztah/bump_go_units
...
bump docker/go-units v0.4.0
2019-04-23 17:14:49 +02:00
Sebastiaan van Stijn
c94308fa99
bump docker/go-units v0.4.0
...
relevant changes:
- docker/go-units#33 Fix handling of unlimited (-1) ulimit values
- docker/go-units#34 Revert 46 minute threshold
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-23 17:01:07 +02:00
Tibor Vass
1ed02c40fe
cli-plugins: alias an existing allowed command (only builder for now)
...
With this patch it is possible to alias an existing allowed command.
At the moment only builder allows an alias.
This also properly puts the build command under builder, instead of image
where it was for historical reasons.
Signed-off-by: Tibor Vass <tibor@docker.com>
2019-04-19 01:26:45 +00:00
Sebastiaan van Stijn
8ca1f0bb7d
Merge pull request #1715 from AkihiroSuda/fix-bastion
...
commandconn: set SysProcAttr.Setsid (Fix DOCKER_HOST=ssh://host-behind-bastion)
2019-04-18 19:55:53 +02:00
Sebastiaan van Stijn
59952a0146
Merge pull request #1839 from thaJeztah/bump_engine3
...
bump docker/docker 92a6266c9d4f1bacbfb68d1c6b9c94f673d6cfde
2019-04-18 19:32:32 +02:00
Sebastiaan van Stijn
ba8388f052
bump github.com/davecgh/go-spew v1.1.1
...
full diff: https://github.com/davecgh/go-spew/compare/v1.1.0...v1.1.1
- davecgh/go-spew#79 simpler, more robust bypass
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-18 19:20:31 +02:00
Sebastiaan van Stijn
6a562c9b33
bump beorn7/perks e7f67b54abbeac9c40a31de0f81159e4cafebd6a
...
no local changes
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-18 19:14:39 +02:00
Sebastiaan van Stijn
df4dc54374
bump docker/swarmkit 59163bf75df38489d4a10392265d27156dc473c5
...
full diff: 18e7e58ea1...59163bf75d
- Add missing return when configuring VXLAN port
- Prevent possible panic in cnmallocator.IsAttachmentAllocated()
- update github.com/pivotal-golang/clock
- new name for package: code.cloudfoundry.org/clock
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-18 19:13:13 +02:00
Sebastiaan van Stijn
84dc462ea4
bump containerd/go-runc 7d11b49dc0769f6dbb0d1b19f3d48524d1bad9ad
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-18 19:12:10 +02:00
Sebastiaan van Stijn
ac234326a6
bump containerd/fifo a9fb20d87448d386e6d50b1f2e1fa70dcf0de43c
...
- containerd/fifo#17 Expose underlying file's `SyscallConn` method
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-18 19:10:16 +02:00
Sebastiaan van Stijn
eeaa4e543a
bump syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
...
full diff: 2c00daeb6c...d98352740c
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-18 19:07:59 +02:00
Sebastiaan van Stijn
1962ec66bb
bump docker/docker 92a6266c9d4f1bacbfb68d1c6b9c94f673d6cfde
...
full diff: ed07e11528...92a6266c9d
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-04-18 19:06:05 +02:00
Sebastiaan van Stijn
d365225c32
Merge pull request #1838 from simonferquel/remove-context-in-function-names
...
Remove "context" from context store interfaces function names
2019-04-18 18:38:01 +02:00
Sebastiaan van Stijn
fe19be2530
Merge pull request #1810 from albers/completion-buildkit
...
Add BuildKit specific options to bash completion
2019-04-18 17:56:12 +02:00
Sebastiaan van Stijn
5ad82fafb3
Merge pull request #1829 from thaJeztah/bump_gotestsum_v0.3.4
...
bump gotestsum v0.3.4
2019-04-18 17:55:12 +02:00
Sebastiaan van Stijn
f99e0b00e9
Merge pull request #1828 from thaJeztah/bump_shlex
...
bump github.com/google/shlex c34317bd91bf98fab745d77b03933cf8769299fe
2019-04-18 17:55:02 +02:00
Sebastiaan van Stijn
04751fd58e
Merge pull request #1830 from thaJeztah/use_google_shlex
...
Switch to google/shlex
2019-04-18 17:53:37 +02:00
Sebastiaan van Stijn
438426e0fc
Merge pull request #1811 from thaJeztah/bump_grpc_1.12.2
...
bump google.golang.org/grpc v1.12.2
2019-04-18 17:49:19 +02:00
Sebastiaan van Stijn
71570160c1
Merge pull request #1826 from thaJeztah/bump_engine2
...
bump docker/docker ed07e1152879a4d156dff2e86abca3c4c811e743
2019-04-18 17:48:44 +02:00
Simon Ferquel
a3efd5d195
Cleanup context store interfaces
...
This remove the term "context" from context store interfaces, to make
them more concise
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
2019-04-18 15:49:36 +02:00
Sebastiaan van Stijn
84b3805feb
Merge pull request #1836 from simonferquel/context-export-source
...
Split the context store interface
2019-04-18 15:36:13 +02:00
Simon Ferquel
225c9b189a
Split the context store interface
...
This is to make it easier to implement support for exporting contexts in
3rd party code, or to create mocks in tests.
2 exemples where it simplify things:
- docker-app desktop-specific context decorator (which rewrites parts of
the docker context to simplify UX when using on Docker Desktop contexts)
- ucp for including a context in the connection bundle
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
2019-04-18 15:03:46 +02:00
Sebastiaan van Stijn
552e8d1a73
Merge pull request #1832 from thaJeztah/bump_golang_1.12.4
...
Bump Golang 1.12.4
2019-04-18 01:53:53 +02:00
Tibor Vass
2432af701a
Merge pull request #1808 from martencassel/securityopt-systempaths-unconfined
...
add cli integration for unconfined systempaths
2019-04-16 11:48:43 -07:00
Sebastiaan van Stijn
49bd6b729d
Merge pull request #1835 from dhiltgen/refined_login_warning
...
Refine warning for storing registry passwords
2019-04-16 10:36:24 +02:00
Daniel Hiltgen
5b3f171482
Add unit test coverage for token auth
...
Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
2019-04-15 16:13:55 -07:00
Silvin Lubecki
f02d94afbb
Merge pull request #1825 from thaJeztah/bump_gotest_2.3.0
...
bump gotest.tools v2.3.0
2019-04-15 11:56:37 +02:00
Vincent Demeester
c61435b9c7
Merge pull request #1834 from thaJeztah/end_of_upstream_packages
...
vendor.conf: reserve space for downstream projects
2019-04-15 09:49:07 +02:00