395957155f
cli/command/container: don't leak context
...
Switch from x/net/context to context made "go vet" see the previously
unseen errors:
> cli/command/container/start.go:57::error: the cancelFun function is
> not used on all paths (possible context leak) (vet)
> cli/command/container/start.go:63::error: this return statement may be
> reached without using the cancelFun var defined on line 57 (vet)
> cli/command/container/run.go:159::error: the cancelFun function is not
> used on all paths (possible context leak) (vet)
> cli/command/container/run.go:164::error: this return statement may be
> reached without using the cancelFun var defined on line 159 (vet)
Do call the cancel function.
Note we might end up calling it twice which is fine as long as I can see
from the Go 1.10 source code.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2018-05-11 16:50:04 -07:00
6f8070deb2
Switch from x/net/context to context
...
Since go 1.7, "context" is a standard package. Since go 1.9,
x/net/context merely provides some types aliased to those in
the standard context package.
The changes were performed by the following script:
for f in $(git ls-files \*.go | grep -v ^vendor/); do
sed -i 's|golang.org/x/net/context|context|' $f
goimports -w $f
for i in 1 2; do
awk '/^$/ {e=1; next;}
/\t"context"$/ {e=0;}
{if (e) {print ""; e=0}; print;}' < $f > $f.new && \
mv $f.new $f
goimports -w $f
done
done
[v2: do awk/goimports fixup twice]
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2018-05-11 16:49:43 -07:00
0ff5f52051
Merge pull request #922 from kolyshkin/man-fixes
...
Man page fixes
2018-05-03 07:34:06 -10:00
e956159572
Merge pull request #1005 from eiais/fishupdate
...
Update Attach, Build, Commit, Cp, Create subcommand fish completions
2018-05-03 10:28:53 +02:00
e9731e9d0f
Merge pull request #1006 from essamhassan/908_show_secrets_configs_srv_inspect
...
908 - Adding configs/secrets to service inspect pretty
2018-05-03 10:12:51 +02:00
222b0245f7
Merge pull request #1030 from thaJeztah/bump-version-to-v18.06-dev
...
Bump version to 18.06.0-dev
2018-05-02 11:39:52 -07:00
deb8bd740b
Bump version to 18.06.0-dev
...
Docker-CE 18.05.0-rc1 was cut off from these commits;
- docker-ce 18.05 branch created for code freeze: https://github.com/docker/docker-ce/tree/18.05
- engine: https://github.com/moby/moby/tree/1a57535
- cli: https://github.com/docker/cli/tree/4970824
- packaging: https://github.com/docker/docker-ce-packaging/tree/c216602
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-05-02 12:11:23 +02:00
784430737b
Merge pull request #1026 from dhiltgen/expose_pull
...
Export pull as a public function
2018-05-02 12:07:49 +02:00
f42c66bd24
Merge pull request #1024 from clnperez/manifest-token-perms
...
manifest list: request specific permissions
2018-04-30 20:22:11 +02:00
8103326311
Merge pull request #1028 from nstapelbroek/feature/exec-die-event
...
Add exec_die to the list of known container events
2018-04-30 12:26:28 +02:00
3a55cd709c
Merge pull request #973 from silvin-lubecki/orchestrator-column
...
Orchestrator column
2018-04-30 12:16:41 +02:00
13d0c9c695
Add an orchestrator column in the docker stack ls command
...
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
2018-04-30 12:04:02 +02:00
8963ab993e
Merge pull request #903 from silvin-lubecki/add-warnings-client-side
...
Add warnings client side before deployment on Kubernetes
2018-04-30 12:01:55 +02:00
36591a2282
Print warnings on stderr for each unsupported features while parsing a compose file for deployment on Kubernetes.
...
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
2018-04-30 11:56:14 +02:00
7ad30360c8
Merge pull request #899 from silvin-lubecki/handle-multiple-stack-api-versions
...
Handle multiple stack api versions
2018-04-30 11:33:04 +02:00
f958c66a6d
Add a common interface between different Kubernetes Stack API versions and use it in kubernetes stack commands
...
* Add kubernetes Stack API v1beta2 client
* Upgrade v1beta1 client to remove generated code
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
2018-04-30 11:27:22 +02:00
4d91812b88
Add exec_die to the list of known container events
...
Signed-off-by: Nico Stapelbroek <nstapelbroek@gmail.com>
2018-04-29 14:52:08 +02:00
812f113685
Export pull as a public function
...
It will be helpful to expose the pull implementation which supports
pulling private images for other CLI commands that rely on helper images.
Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
2018-04-27 12:21:19 -07:00
99bd7ed693
Merge pull request #1017 from thaJeztah/warn-when-using-host-ip
...
Warn when using host-ip for published ports
2018-04-25 17:09:42 -04:00
8238644796
testing config/secrets are showing in pretty print
...
Signed-off-by: Essam A. Hassan <es.hassan187@gmail.com>
2018-04-25 17:22:18 +02:00
2b1f27ea5e
add config and secret to service in inspect test
...
Signed-off-by: Essam A. Hassan <es.hassan187@gmail.com>
2018-04-25 17:22:18 +02:00
3ae2d4b24c
adding configs/secrets to service inspect pretty
...
Signed-off-by: Essam A. Hassan <es.hassan187@gmail.com>
2018-04-25 17:21:31 +02:00
c26e2264fb
specify specific permissions
...
When creating manifest lists, don't use "*" as the permission when
creating the token handler. This causes problems with gitlab's repos.
Fixes https://github.com/docker/cli/issues/1010
Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
2018-04-24 17:01:57 -05:00
4970824bea
Merge pull request #1022 from silvin-lubecki/clean-manifest-documentation
...
Cleaning some manifest documentation typos
2018-04-24 17:07:14 +02:00
55c5e7aa88
Cleaning some manifest documentation typos
...
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
2018-04-24 15:00:39 +02:00
c889ea1bca
Merge pull request #1020 from vdemeester/todo-tada
...
Handle some TODOs in tests
2018-04-23 09:33:41 -04:00
740d260cd2
Remove more TODOs
...
- Some of them don't make sense anymore
- Some are deprecated and removed from the engine since a few versions
already.
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-04-23 14:57:29 +02:00
58173b3c69
Remote FIXME(s) in vendor.conf
...
It's coming from dependencies, doesn't make sense here
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-04-23 14:14:45 +02:00
ae03dd7f46
Handle some TODOs in tests
...
Use more gotestyourself for `env.Patch`, and `icmd.RunCommand`
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-04-23 14:13:52 +02:00
c790f387e1
Merge pull request #1011 from vdemeester/mark-test-helpers
...
Make testing helpers as such…
2018-04-23 11:20:12 +02:00
363335ec9b
Warn when using host-ip for published ports
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-04-21 12:49:47 -07:00
b491ad1589
update docker Create subcommand fish completions
...
Signed-off-by: Kyle Spiers <kyle@spiers.me>
2018-04-20 12:09:44 -07:00
49d8604875
update docker Cp subcommand fish completions
...
Signed-off-by: Kyle Spiers <kyle@spiers.me>
2018-04-20 11:58:05 -07:00
67a80e3c89
update docker Commit subcommand fish completions
...
Signed-off-by: Kyle Spiers <kyle@spiers.me>
2018-04-20 11:57:33 -07:00
44168f52b3
update docker Build subcommand fish completions
...
Signed-off-by: Kyle Spiers <kyle@spiers.me>
2018-04-20 11:56:09 -07:00
ee5aad8646
update docker Attach subcommand fish completions
...
Signed-off-by: Kyle Spiers <kyle@spiers.me>
2018-04-20 11:48:57 -07:00
6c9232a568
Merge pull request #1013 from thaJeztah/update-authors
...
Update AUTHORS and mailmap
2018-04-18 13:46:30 -07:00
01778ee9d5
Merge pull request #1012 from thaJeztah/add-silvin-maintainer
...
Add Silvin as maintainer
2018-04-18 16:35:40 -04:00
a761eff8c5
Update AUTHORS and mailmap
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-04-18 13:31:07 -07:00
60b371506c
Add Silvin as maintainer
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-04-18 13:21:33 -07:00
0685bb29db
Merge pull request #1004 from albers/completion--template-driver
...
Add bash completion for `secret|config create --template-driver`
2018-04-18 19:04:29 +02:00
b29844f8ca
Make testing helpers as such…
...
That way, those lines won't be reported in the failure.
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-04-18 17:02:21 +02:00
8618838bdb
Merge pull request #1008 from n4ss/revert-unencrypted-prompt
...
Revert unencryted storage warning prompt
2018-04-18 00:01:13 -07:00
771ccaf4ed
Merge pull request #999 from perlun/patch-1
...
build.md: Document --build-arg without value
2018-04-17 10:39:20 -07:00
f3bf6928da
Merge pull request #1007 from HenryNe/patch-1
...
docs: Typofix in example "docker image ls"
2018-04-17 10:10:19 +02:00
3acf5d2e47
Revert unencryted storage warning prompt
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
2018-04-16 12:48:03 -07:00
79c489d812
docker load: Typofix in examples
...
Remove the double "docker docker" from example
Signed-off-by: Henry Ne <henrynmail-github@yahoo.de>
2018-04-16 16:39:54 +02:00
82c23208ee
build.md: Document --build-arg without value
...
This use case is currently _working correctly_, which is nice, but there is no documentation to be found about it. This PR fixes that.
Signed-off-by: Per Lundberg <perlun@gmail.com>
2018-04-16 07:52:13 +03:00
43024e2d57
Add bash completion for `secret|config create --template-driver`
...
Signed-off-by: Harald Albers <github@albersweb.de>
2018-04-14 14:46:19 +02:00
e5980c541a
Merge pull request #970 from cowlinator/temp2
...
Clarify --build-arg documentation
2018-04-13 18:54:16 -07:00
Kir Kolyshkin
Tibor Vass
Vincent Demeester
Victor Vieux
Sebastiaan van Stijn
Sebastiaan van Stijn
Silvin Lubecki
Nico Stapelbroek
Daniel Hiltgen
Brian Goff
Essam A. Hassan
Christy Norman
Vincent Demeester
Silvin
Kyle Spiers
Nassim 'Nass' Eddequiouaq
Henry N
Per Lundberg
Harald Albers