Guest24897/DockerCLI

Commit Graph

Author	SHA1	Message	Date
Kir Kolyshkin	bc4ed69a23	TestSigProxyWithTTY: fix exec.CombinedOutput should not be used here because: - it redirects cmd Stdout and Stderr and we want it to be the tty - it calls cmd.Run which we already did While at it - use pty.Start() as it is cleaner - make sure we don't leave a zombie running, by calling Wait() in defer - use test.Name() for containerName Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>	2019-07-30 17:40:31 -07:00
Sebastiaan van Stijn	f290a80846	switch kr/pty to creack/pty v1.1.7 kr/pty was moved to creak/pty and the old location was archived. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2019-07-29 16:45:41 -07:00
Sebastiaan van Stijn	7cf1a8d4c9	Add test for --sig-proxy with a TTY Add a test to verify that killing the docker CLI forwards the signal to the container. Test-case for moby/moby 28872 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2019-06-25 16:29:24 +02:00

Author

SHA1

Message

Date

Kir Kolyshkin

bc4ed69a23

TestSigProxyWithTTY: fix

exec.CombinedOutput should not be used here because:
 - it redirects cmd Stdout and Stderr and we want it to be the tty
 - it calls cmd.Run which we already did

While at it
 - use pty.Start() as it is cleaner
 - make sure we don't leave a zombie running, by calling Wait() in defer
 - use test.Name() for containerName

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

2019-07-30 17:40:31 -07:00

Sebastiaan van Stijn

f290a80846

switch kr/pty to creack/pty v1.1.7

kr/pty was moved to creak/pty and the old location was
archived.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2019-07-29 16:45:41 -07:00

Sebastiaan van Stijn

7cf1a8d4c9

Add test for --sig-proxy with a TTY

Add a test to verify that killing the docker CLI forwards
the signal to the container. Test-case for moby/moby 28872

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2019-06-25 16:29:24 +02:00

3 Commits