Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5510 from austinvazquez/cherry-pick-daea277ee839742be94e1f41d5c477f114a81273-to-26.1 

[26.1 backport] volume/update: require 1 argument/fix panic
This commit is contained in:
Sebastiaan van Stijn 2024-10-08 10:48:35 +02:00 committed by GitHub
parent 3c827aba41 23a8d38e25
commit fb622dba9c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cli/command/volume/update.go
View File

@ -18,7 +18,7 @@ func newUpdateCommand(dockerCli command.Cli) *cobra.Command {
cmd := &cobra.Command{ cmd := &cobra.Command{
Use: "update [OPTIONS] [VOLUME]", Use: "update [OPTIONS] [VOLUME]",
Short: "Update a volume (cluster volumes only)", Short: "Update a volume (cluster volumes only)",
Args: cli.RequiresMaxArgs(1), Args: cli.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
return runUpdate(cmd.Context(), dockerCli, args[0], availability, cmd.Flags()) return runUpdate(cmd.Context(), dockerCli, args[0], availability, cmd.Flags())
}, },

22
cli/command/volume/update_test.go Normal file
View File

@ -0,0 +1,22 @@
package volume
import (
"io"
"testing"
"github.com/docker/cli/internal/test"
"gotest.tools/v3/assert"
)
func TestUpdateCmd(t *testing.T) {
cmd := newUpdateCommand(
test.NewFakeCli(&fakeClient{}),
)
cmd.SetArgs([]string{})
cmd.SetOut(io.Discard)
cmd.SetErr(io.Discard)
err := cmd.Execute()
assert.ErrorContains(t, err, "requires exactly 1 argument")
}