Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #29041 from aaronlehmann/hide-updatestatus 

api: Hide UpdateStatus when it is not present
This commit is contained in:
Sebastiaan van Stijn 2016-12-08 13:55:13 +01:00 committed by GitHub
parent 4b7ad6c23e 8a379d7bce
commit e2b06ebc88
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
command/formatter/service.go
View File

@ -28,7 +28,9 @@ Service Mode:
{{- if .HasUpdateStatus }} {{- if .HasUpdateStatus }}
UpdateStatus: UpdateStatus:
State: {{ .UpdateStatusState }} State: {{ .UpdateStatusState }}
{{- if .HasUpdateStatusStarted }}
Started: {{ .UpdateStatusStarted }} Started: {{ .UpdateStatusStarted }}
{{- end }}
{{- if .UpdateIsCompleted }} {{- if .UpdateIsCompleted }}
Completed: {{ .UpdateStatusCompleted }} Completed: {{ .UpdateStatusCompleted }}
{{- end }} {{- end }}
@ -172,23 +174,27 @@ func (ctx *serviceInspectContext) ModeReplicatedReplicas() *uint64 {
} }
func (ctx *serviceInspectContext) HasUpdateStatus() bool { func (ctx *serviceInspectContext) HasUpdateStatus() bool {
return ctx.Service.UpdateStatus.State != "" return ctx.Service.UpdateStatus != nil && ctx.Service.UpdateStatus.State != ""
} }
func (ctx *serviceInspectContext) UpdateStatusState() swarm.UpdateState { func (ctx *serviceInspectContext) UpdateStatusState() swarm.UpdateState {
return ctx.Service.UpdateStatus.State return ctx.Service.UpdateStatus.State
} }
func (ctx *serviceInspectContext) HasUpdateStatusStarted() bool {
return ctx.Service.UpdateStatus.StartedAt != nil
}
func (ctx *serviceInspectContext) UpdateStatusStarted() string { func (ctx *serviceInspectContext) UpdateStatusStarted() string {
return units.HumanDuration(time.Since(ctx.Service.UpdateStatus.StartedAt)) return units.HumanDuration(time.Since(*ctx.Service.UpdateStatus.StartedAt))
} }
func (ctx *serviceInspectContext) UpdateIsCompleted() bool { func (ctx *serviceInspectContext) UpdateIsCompleted() bool {
return ctx.Service.UpdateStatus.State == swarm.UpdateStateCompleted return ctx.Service.UpdateStatus.State == swarm.UpdateStateCompleted && ctx.Service.UpdateStatus.CompletedAt != nil
} }
func (ctx *serviceInspectContext) UpdateStatusCompleted() string { func (ctx *serviceInspectContext) UpdateStatusCompleted() string {
return units.HumanDuration(time.Since(ctx.Service.UpdateStatus.CompletedAt)) return units.HumanDuration(time.Since(*ctx.Service.UpdateStatus.CompletedAt))
} }
func (ctx *serviceInspectContext) UpdateStatusMessage() string { func (ctx *serviceInspectContext) UpdateStatusMessage() string {

6
command/service/inspect_test.go
View File

@ -74,9 +74,9 @@ func formatServiceInspect(t *testing.T, format formatter.Format, now time.Time)
}, },
}, },
}, },
UpdateStatus: swarm.UpdateStatus{ UpdateStatus: &swarm.UpdateStatus{
StartedAt: now, StartedAt: &now,
CompletedAt: now, CompletedAt: &now,
}, },
} }