Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Skip inspect of builtin networks on service create 

Signed-off-by: Trapier Marshall <trapier.marshall@docker.com>
This commit is contained in:
Trapier Marshall 2019-08-16 15:51:31 -04:00
parent d88565df0c
commit e193234f14
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cli/command/service/opts.go
View File

@ -613,9 +613,16 @@ func (options *serviceOptions) ToService(ctx context.Context, apiClient client.N
networks := convertNetworks(options.networks)
for i, net := range networks {
nwID, err := resolveNetworkID(ctx, apiClient, net.Target)
if err != nil {
return service, err
var nwID string
if !container.NetworkMode(net.Target).IsUserDefined() {
// Networks that are not user defined always exist on all nodes as
// local-scoped networks, so there's no need to inspect them.
nwID = net.Target
} else {
nwID, err = resolveNetworkID(ctx, apiClient, net.Target)
if err != nil {
return service, err
}
}
networks[i].Target = nwID
}