mirror of https://github.com/docker/cli.git
volume/update: require 1 argument/fix panic
This command was declaring that it requires at least 1 argument, when it needs exactly 1 argument. This was causing the CLI to panic when the command was invoked with no argument: `docker volume update` Signed-off-by: Laura Brehm <laurabrehm@hey.com>
This commit is contained in:
parent
6372ec9c75
commit
daea277ee8
|
@ -18,7 +18,7 @@ func newUpdateCommand(dockerCli command.Cli) *cobra.Command {
|
||||||
cmd := &cobra.Command{
|
cmd := &cobra.Command{
|
||||||
Use: "update [OPTIONS] [VOLUME]",
|
Use: "update [OPTIONS] [VOLUME]",
|
||||||
Short: "Update a volume (cluster volumes only)",
|
Short: "Update a volume (cluster volumes only)",
|
||||||
Args: cli.RequiresMaxArgs(1),
|
Args: cli.ExactArgs(1),
|
||||||
RunE: func(cmd *cobra.Command, args []string) error {
|
RunE: func(cmd *cobra.Command, args []string) error {
|
||||||
return runUpdate(cmd.Context(), dockerCli, args[0], availability, cmd.Flags())
|
return runUpdate(cmd.Context(), dockerCli, args[0], availability, cmd.Flags())
|
||||||
},
|
},
|
||||||
|
|
|
@ -0,0 +1,22 @@
|
||||||
|
package volume
|
||||||
|
|
||||||
|
import (
|
||||||
|
"io"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/docker/cli/internal/test"
|
||||||
|
"gotest.tools/v3/assert"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestUpdateCmd(t *testing.T) {
|
||||||
|
cmd := newUpdateCommand(
|
||||||
|
test.NewFakeCli(&fakeClient{}),
|
||||||
|
)
|
||||||
|
cmd.SetArgs([]string{})
|
||||||
|
cmd.SetOut(io.Discard)
|
||||||
|
cmd.SetErr(io.Discard)
|
||||||
|
|
||||||
|
err := cmd.Execute()
|
||||||
|
|
||||||
|
assert.ErrorContains(t, err, "requires 1 argument")
|
||||||
|
}
|
Loading…
Reference in New Issue