mirror of https://github.com/docker/cli.git
Fix several issues with `go vet` and `go fmt`
For some reason, `go vet` and `go fmt` validate does not capture several issues. The following was the output of `go vet`: ``` ubuntu@ubuntu:~/docker$ go vet ./... 2>&1 | grep -v ^vendor | grep -v '^exit status 1$' cli/command/formatter/container_test.go:393: possible formatting directive in Log call volume/volume_test.go:257: arg mp.RW for printf verb %s of wrong type: bool ``` The following was the output of `go fmt -s`: ``` ubuntu@ubuntu:~/docker$ gofmt -s -l . | grep -v ^vendor cli/command/stack/list.go daemon/commit.go ``` Fixed above issues with `go vet` and `go fmt -s` Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
parent
91aed2e673
commit
d691bce8c9
|
@ -372,7 +372,7 @@ func TestContainerContextWriteJSONField(t *testing.T) {
|
|||
}
|
||||
|
||||
func TestContainerBackCompat(t *testing.T) {
|
||||
containers := []types.Container{types.Container{ID: "brewhaha"}}
|
||||
containers := []types.Container{{ID: "brewhaha"}}
|
||||
cases := []string{
|
||||
"ID",
|
||||
"Names",
|
||||
|
@ -390,7 +390,7 @@ func TestContainerBackCompat(t *testing.T) {
|
|||
for _, c := range cases {
|
||||
ctx := Context{Format: Format(fmt.Sprintf("{{ .%s }}", c)), Output: buf}
|
||||
if err := ContainerWrite(ctx, containers); err != nil {
|
||||
t.Log("could not render template for field '%s': %v", c, err)
|
||||
t.Logf("could not render template for field '%s': %v", c, err)
|
||||
t.Fail()
|
||||
}
|
||||
buf.Reset()
|
||||
|
|
|
@ -72,7 +72,7 @@ func printTable(out io.Writer, stacks []*stack) {
|
|||
|
||||
type stack struct {
|
||||
// Name is the name of the stack
|
||||
Name string
|
||||
Name string
|
||||
// Services is the number of the services
|
||||
Services int
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue