diff --git a/cli/command/formatter/service.go b/cli/command/formatter/service.go index 27200b8be9..0aca42c247 100644 --- a/cli/command/formatter/service.go +++ b/cli/command/formatter/service.go @@ -518,11 +518,11 @@ func (c *serviceContext) Image() string { } func (c *serviceContext) Ports() string { - if c.service.Spec.EndpointSpec == nil || c.service.Spec.EndpointSpec.Ports == nil { + if c.service.Endpoint.Ports == nil { return "" } ports := []string{} - for _, pConfig := range c.service.Spec.EndpointSpec.Ports { + for _, pConfig := range c.service.Endpoint.Ports { if pConfig.PublishMode == swarm.PortConfigPublishModeIngress { ports = append(ports, fmt.Sprintf("*:%d->%d/%s", pConfig.PublishedPort, diff --git a/cli/command/formatter/service_test.go b/cli/command/formatter/service_test.go index e230f80fbf..d7542ef32f 100644 --- a/cli/command/formatter/service_test.go +++ b/cli/command/formatter/service_test.go @@ -96,14 +96,14 @@ bar ID: "id_baz", Spec: swarm.ServiceSpec{ Annotations: swarm.Annotations{Name: "baz"}, - EndpointSpec: &swarm.EndpointSpec{ - Ports: []swarm.PortConfig{ - { - PublishMode: "ingress", - PublishedPort: 80, - TargetPort: 8080, - Protocol: "tcp", - }, + }, + Endpoint: swarm.Endpoint{ + Ports: []swarm.PortConfig{ + { + PublishMode: "ingress", + PublishedPort: 80, + TargetPort: 8080, + Protocol: "tcp", }, }, }, @@ -112,14 +112,14 @@ bar ID: "id_bar", Spec: swarm.ServiceSpec{ Annotations: swarm.Annotations{Name: "bar"}, - EndpointSpec: &swarm.EndpointSpec{ - Ports: []swarm.PortConfig{ - { - PublishMode: "ingress", - PublishedPort: 80, - TargetPort: 8080, - Protocol: "tcp", - }, + }, + Endpoint: swarm.Endpoint{ + Ports: []swarm.PortConfig{ + { + PublishMode: "ingress", + PublishedPort: 80, + TargetPort: 8080, + Protocol: "tcp", }, }, }, @@ -152,14 +152,14 @@ func TestServiceContextWriteJSON(t *testing.T) { ID: "id_baz", Spec: swarm.ServiceSpec{ Annotations: swarm.Annotations{Name: "baz"}, - EndpointSpec: &swarm.EndpointSpec{ - Ports: []swarm.PortConfig{ - { - PublishMode: "ingress", - PublishedPort: 80, - TargetPort: 8080, - Protocol: "tcp", - }, + }, + Endpoint: swarm.Endpoint{ + Ports: []swarm.PortConfig{ + { + PublishMode: "ingress", + PublishedPort: 80, + TargetPort: 8080, + Protocol: "tcp", }, }, }, @@ -168,14 +168,14 @@ func TestServiceContextWriteJSON(t *testing.T) { ID: "id_bar", Spec: swarm.ServiceSpec{ Annotations: swarm.Annotations{Name: "bar"}, - EndpointSpec: &swarm.EndpointSpec{ - Ports: []swarm.PortConfig{ - { - PublishMode: "ingress", - PublishedPort: 80, - TargetPort: 8080, - Protocol: "tcp", - }, + }, + Endpoint: swarm.Endpoint{ + Ports: []swarm.PortConfig{ + { + PublishMode: "ingress", + PublishedPort: 80, + TargetPort: 8080, + Protocol: "tcp", }, }, }, diff --git a/cli/command/stack/testdata/stack-services-without-format.golden b/cli/command/stack/testdata/stack-services-without-format.golden index c892250c20..dcca0dfaee 100644 --- a/cli/command/stack/testdata/stack-services-without-format.golden +++ b/cli/command/stack/testdata/stack-services-without-format.golden @@ -1,2 +1,2 @@ ID NAME MODE REPLICAS IMAGE PORTS -id-foo name-foo replicated 0/2 busybox:latest *:0->3232/tcp +id-foo name-foo replicated 0/2 busybox:latest *:30000->3232/tcp diff --git a/cli/internal/test/builders/service.go b/cli/internal/test/builders/service.go index 71718268e1..29a7bc53f2 100644 --- a/cli/internal/test/builders/service.go +++ b/cli/internal/test/builders/service.go @@ -64,5 +64,11 @@ func ServiceImage(image string) func(*swarm.Service) { func ServicePort(port swarm.PortConfig) func(*swarm.Service) { return func(service *swarm.Service) { service.Spec.EndpointSpec.Ports = append(service.Spec.EndpointSpec.Ports, port) + + assignedPort := port + if assignedPort.PublishedPort == 0 { + assignedPort.PublishedPort = 30000 + } + service.Endpoint.Ports = append(service.Endpoint.Ports, assignedPort) } }