Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

compose/loader: fix TestIsAbs not testing all combinations 

This test was intending to run all tests, but didn't, which was
caught by golangci-lint;

    cli/compose/loader/windows_path_test.go:46:17: SA4010: this result of append is never used, except maybe in other appends (staticcheck)
    	tests := append(isabstests, winisabstests...)
    	               ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 0a21de05d2)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2019-10-29 09:59:48 +01:00
parent 3bc713c157
commit b71d5e32cd
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cli/compose/loader/windows_path_test.go
View File

@ -43,7 +43,8 @@ var winisabstests = []IsAbsTest{
} }
func TestIsAbs(t *testing.T) { func TestIsAbs(t *testing.T) {
tests := append(isabstests, winisabstests...) tests := winisabstests
// All non-windows tests should fail, because they have no volume letter. // All non-windows tests should fail, because they have no volume letter.
for _, test := range isabstests { for _, test := range isabstests {
tests = append(tests, IsAbsTest{test.path, false}) tests = append(tests, IsAbsTest{test.path, false})
@ -53,7 +54,7 @@ func TestIsAbs(t *testing.T) {
tests = append(tests, IsAbsTest{"c:" + test.path, test.isAbs}) tests = append(tests, IsAbsTest{"c:" + test.path, test.isAbs})
} }
for _, test := range winisabstests { for _, test := range tests {
if r := isAbs(test.path); r != test.isAbs { if r := isAbs(test.path); r != test.isAbs {
t.Errorf("IsAbs(%q) = %v, want %v", test.path, r, test.isAbs) t.Errorf("IsAbs(%q) = %v, want %v", test.path, r, test.isAbs)
} }