mirror of https://github.com/docker/cli.git
Fix failure in `docker ps --format` when `.Label` has args
This fix tries to fix the issue in 30279 where `docker ps --format` fails if `.Label` has args. For example: ``` docker ps --format '{{.ID}}\t{{.Names}}\t{{.Label "some.label"}}' ``` The reason for the failure is that during the preprocessing phase to detect the existance of `.Size`, the `listOptionsProcessor` does not has a method of `Label(name string) string`. This results in the failure of ``` template: :1:24: executing "" at <.Label>: Label is not a method but has arguments ``` This fix fixes the issue by adding needed method of `Label(name string) string`. This fix fixes 30279. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
parent
d6f65e40e3
commit
a2afbcbb57
|
@ -73,6 +73,12 @@ func (o listOptionsProcessor) Size() bool {
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Label is needed here as it allows the correct pre-processing
|
||||||
|
// because Label() is a method with arguments
|
||||||
|
func (o listOptionsProcessor) Label(name string) string {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
|
||||||
func buildContainerListOptions(opts *psOptions) (*types.ContainerListOptions, error) {
|
func buildContainerListOptions(opts *psOptions) (*types.ContainerListOptions, error) {
|
||||||
options := &types.ContainerListOptions{
|
options := &types.ContainerListOptions{
|
||||||
All: opts.all,
|
All: opts.all,
|
||||||
|
|
Loading…
Reference in New Issue